bug#67657: [PATCH v2] services: connman: Add 'connman-general-configuration'.

[Maxim Cournoyer <maxim.cournoyer@gmail.com>]

Hi,

muradm <mail@muradm.net> writes:

> ping?
>
> muradm <mail@muradm.net> writes:
>
>> For me connman in default configuration causes conflict with docker
>> generated virtual veth* interfaces. Currently connman has no
>> main.conf as specified in man 5 connman.conf which would allow
>> setting NetworkInterfaceBalcklist and other useful options.
>>
>> This patch adds connman-general-configuration, serializes it and
>> passes to connmad with --config= flag.
>>
>> All configuration fields are 'maybe-*' deliberately. This will not
>> disturb current users. This will not require supporting
>> configuration
>> changes for connmand.
>>
>> * gnu/services/networking.scm:
>> (<connman-general-configuration>): New configuration record
>> to represent main.conf for connmand.
>> (<connman-configuration>)[general-configuration]: New field.
>> (connman-shepherd-service): Honor it.
>> *doc/guix.texi (Networking Services): Add generated configuration.
>>
>> Change-Id: I5d78f49e8b2d5e0b3cbd7b8b604e8a254b6397e8

Pushed with the following typo fixes/improvements to doc:

--8<---------------cut here---------------start------------->8---
2 files changed, 16 insertions(+), 16 deletions(-)
doc/guix.texi               | 16 ++++++++--------
gnu/services/networking.scm | 16 ++++++++--------

modified   doc/guix.texi
@@ -21013,7 +21013,7 @@ Networking Setup
 services from this technology even if not setup and saved to storage.
 
 @item @code{always-connected-technologies} (type: maybe-list)
-List of technoolgies which are always connected regardless of
+List of technologies which are always connected regardless of
 preferred-technologies setting (@code{auto-connect?} @code{#t}).  The
 default value is empty and this feature is disabled unless explicitly
 enabled.
@@ -21060,7 +21060,7 @@ Networking Setup
 List of technologies that are allowed to enable tethering.  The default
 value is @code{"wifi"}, @code{"bluetooth"}, @code{"gadget"}.  Only those
 technologies listed here are used for tethering.  If one wants to tether
-ethernet, then add @code{"ethernet"} in the list.  NOTE that if ethernet
+ethernet, then add @code{"ethernet"} in the list.  Note that if ethernet
 tethering is enabled, then a DHCP server is started on all ethernet
 interfaces.  Tethered ethernet should never be connected to corporate or
 home network as it will disrupt normal operation of these networks.  Due
@@ -21103,14 +21103,14 @@ Networking Setup
 
 @item @code{online-check-initial-interval} (type: maybe-number)
 Range of intervals between two online check requests.  Please refer to
-the README for more detailed information.  Default values is @samp{1}.
+the README for more detailed information.  Default value is @samp{1}.
 
 @item @code{online-check-max-interval} (type: maybe-number)
 Range of intervals between two online check requests.  Please refer to
-the README for more detailed information.  Default values is @samp{1}.
+the README for more detailed information.  Default value is @samp{1}.
 
 @item @code{enable-online-to-ready-transition?} (type: maybe-boolean)
-WARNING: Experimental feature!!! In addition to
+WARNING: This is an experimental feature.  In addition to
 @code{enable-online-check} setting, enable or disable use of HTTP GET to
 detect the loss of end-to-end connectivity.  If this setting is
 @code{#f}, when the default service transitions to ONLINE state, the
@@ -21133,8 +21133,8 @@ Networking Setup
 interface.  If an address conflict occurs for a statically configured
 address, an IPv4LL address will be chosen instead (according to
 RFC3927).  If an address conflict occurs for an address offered via
-DHCP, ConnMan send a DHCP DECLINE once and for the second conflict
-resort to finding an IPv4LL address.  Default value is @code{#f}.
+DHCP, ConnMan sends a DHCP DECLINE once and for the second conflict
+resorts to finding an IPv4LL address.  Default value is @code{#f}.
 
 @item @code{localtime} (type: maybe-string)
 Path to localtime file.  Defaults to @file{/etc/localtime}.
@@ -21142,7 +21142,7 @@ Networking Setup
 @item @code{regulatory-domain-follows-timezone?} (type: maybe-boolean)
 Enable regulatory domain to be changed along timezone changes.  With
 this option set to true each time the timezone changes the first present
-ISO3166 country code is being read from
+ISO3166 country code is read from
 @file{/usr/share/zoneinfo/zone1970.tab} and set as regulatory domain
 value.  Default value is @code{#f}.
 
modified   gnu/services/networking.scm
@@ -1420,7 +1420,7 @@ (define-configuration connman-general-configuration
 from this technology even if not setup and saved to storage.")
   (always-connected-technologies
    maybe-list
-   "List of technoolgies which are always connected regardless of
+   "List of technologies which are always connected regardless of
 preferred-technologies setting (@code{auto-connect?} @code{#t}).  The default
 value is empty and this feature is disabled unless explicitly enabled.")
   (preferred-technologies
@@ -1466,7 +1466,7 @@ (define-configuration connman-general-configuration
 default value is @code{\"wifi\"}, @code{\"bluetooth\"},
 @code{\"gadget\"}.  Only those technologies listed here are used for
 tethering.  If one wants to tether ethernet, then add @code{\"ethernet\"}
-in the list.  NOTE that if ethernet tethering is enabled, then a DHCP
+in the list.  Note that if ethernet tethering is enabled, then a DHCP
 server is started on all ethernet interfaces.  Tethered ethernet should
 never be connected to corporate or home network as it will disrupt normal
 operation of these networks.  Due to this ethernet is not tethered by
@@ -1509,16 +1509,16 @@ (define-configuration connman-general-configuration
   (online-check-initial-interval
    maybe-number
    "Range of intervals between two online check requests.  Please
-refer to the README for more detailed information.  Default values
+refer to the README for more detailed information.  Default value
 is @samp{1}.")
   (online-check-max-interval
    maybe-number
    "Range of intervals between two online check requests.  Please
-refer to the README for more detailed information.  Default values
+refer to the README for more detailed information.  Default value
 is @samp{1}.")
   (enable-online-to-ready-transition?
    maybe-boolean
-   "WARNING: Experimental feature!!! In addition to
+   "WARNING: This is an experimental feature.  In addition to
 @code{enable-online-check} setting, enable or disable use of HTTP GET
 to detect the loss of end-to-end connectivity.  If this setting is
 @code{#f}, when the default service transitions to ONLINE state, the
@@ -1542,8 +1542,8 @@ (define-configuration connman-general-configuration
 address to an interface.  If an address conflict occurs for a
 statically configured address, an IPv4LL address will be chosen
 instead (according to RFC3927).  If an address conflict occurs for
-an address offered via DHCP, ConnMan send a DHCP DECLINE once
-and for the second conflict resort to finding an IPv4LL
+an address offered via DHCP, ConnMan sends a DHCP DECLINE once
+and for the second conflict resorts to finding an IPv4LL
 address.  Default value is @code{#f}.")
   (localtime
    maybe-string
@@ -1552,7 +1552,7 @@ (define-configuration connman-general-configuration
    maybe-boolean
    "Enable regulatory domain to be changed along timezone changes.
 With this option set to true each time the timezone changes the first
-present ISO3166 country code is being read from
+present ISO3166 country code is read from
 @file{/usr/share/zoneinfo/zone1970.tab} and set as regulatory domain
 value.  Default value is @code{#f}.")
   (resolv-conf

[back]
--8<---------------cut here---------------end--------------->8---

-- 
Thanks,
Maxim