unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Rodion Goritskov <rodion.goritskov@gmail.com>
To: Sharlatan Hellseher <sharlatanus@gmail.com>
Cc: 70684@debbugs.gnu.org
Subject: [bug#70684] [PATCH go-team 0/6] Update miniflux to 2.1.3
Date: Tue, 07 May 2024 23:22:06 +0400	[thread overview]
Message-ID: <87v83po2ap.fsf@gmail.com> (raw)
In-Reply-To: <87edajq2uq.fsf@gmail.com> (Sharlatan Hellseher's message of "Thu, 02 May 2024 23:13:33 +0100")

Hi, thank you for review!

> In general the <#:import-path> is what we may see on go.mod after
> <module>. In general <#:unpack-path> is not required to build golang
> module.
>
> According to the <https://github.com/google/go-tpm/blob/v0.9.0/go.mod>
> these two packages may be packed as single one:
> <module github.com/google/go-tpm>.
>
> +(define-public go-github-com-google-go-tpm-legacy-tpm2
> +(define-public go-github-com-google-go-tpm-tpmutil

I have a problem when trying to build these packages as one.
When trying to build the single package (like this):

(define go-github-com-google-go-tpm
  (package
    (name "go-github-com-google-go-tpm")
    (version "0.9.0")
    (source
     (origin
       (method git-fetch)
       (uri (git-reference
             (url "https://github.com/google/go-tpm")
             (commit (string-append "v" version))))
       (file-name (git-file-name name version))
       (sha256
        (base32 "1pv77fmlxrnxasj6fjvzrv9yaf2qb45x1zss3nbsdvzgpwviaiyi"))))
    (build-system go-build-system)
    (arguments
     (list
      #:go go-1.22
      #:import-path "github.com/google/go-tpm"))
    (propagated-inputs (list go-golang-org-x-sys
                             go-golang-org-x-crypto))
    (home-page "https://github.com/google/go-tpm")
    (synopsis "Go-TPM library")
    (description
     "TPM 2.0 library for directly communicating with a TPM device.")
    (license license:asl2.0)))

I get the following error on the "build" phase:

command "go" "install" "-v" "-x" "-ldflags=-s -w" "-trimpath"
"github.com/google/go-tpm" failed with status 1

Actually, it fails with the following go install error (found by running
guix build with -K and running command manually in the build folder):

package github.com/google/go-tpm: no Go files in
/tmp/guix-build-go-github-com-google-go-tpm-0.9.0.drv-0/src/github.com/google/go-tpm

This is true - there are no *.go files in the project's root.
For this project to build succesfully, project directory for "go
install" should end with /... (to build all subfolders recursively), like:

"go" "install" "-v" "-x" "-ldflags=-s -w" "-trimpath"
"github.com/google/go-tpm/..."

So, for now I could remove the build (and check, because it has the same
problem) phases from the build (easy, but, AFAIK, not the best fix). In
this case we still have all the necessary sources, for dependent
packages, but no checks.

Or, maybe, we could add some kind of "recursive" flag to the
go-build-system. In this case, as I see, it will lead to all go packages rebuild
(even if it will not be enabled by default).

What do you think?

> This is one go-module no need to split it into 3 packages, see go.mod
> <https://github.com/go-webauthn/webauthn/blob/v0.10.2/go.mod>
> <module github.com/go-webauthn/webauthn>
>
> +(define-public go-github-com-go-webauthn-webauthn-protocol
> +(define-public go-github-com-go-webauthn-webauthn-metadata
> +(define-public go-github-com-go-webauthn-webauthn-webauthn

For these package I have the same problem (no go files in the root folder).




  reply	other threads:[~2024-05-07 19:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-30 20:18 [bug#70684] [PATCH go-team 0/6] Update miniflux to 2.1.3 Rodion Goritskov
2024-04-30 20:42 ` [bug#70684] [PATCH go-team 1/6] gnu: go-github-com-andybalholm-brotli: Update to 1.1.0 Rodion Goritskov
2024-04-30 20:42 ` [bug#70684] [PATCH go-team 2/6] gnu: Add go-github-com-google-go-tpm Rodion Goritskov
2024-04-30 20:42 ` [bug#70684] [PATCH go-team 3/6] gnu: Add go-github-com-x448-float16 Rodion Goritskov
2024-04-30 20:42 ` [bug#70684] [PATCH go-team 4/6] gnu: Add go-github-com-abadojack-whatlanggo and go-github-com-fxamacker-cbor-v2 Rodion Goritskov
2024-04-30 20:42 ` [bug#70684] [PATCH go-team 5/6] gnu: Add go-github-com-go-webauthn Rodion Goritskov
2024-04-30 20:42 ` [bug#70684] [PATCH go-team 6/6] gnu: miniflux: Update to 2.1.3 Rodion Goritskov
2024-05-02 22:13 ` [bug#70684] [PATCH go-team 0/6] Update miniflux " Sharlatan Hellseher
2024-05-07 19:22   ` Rodion Goritskov [this message]
2024-07-04 11:10 ` [bug#70684] [PATCH v2 0/9] " Sharlatan Hellseher
2024-07-04 11:10   ` [bug#70684] [PATCH v2 1/9] gnu: go-github-com-andybalholm-brotli: Update to 1.1.0 Sharlatan Hellseher
2024-07-04 11:10   ` [bug#70684] [PATCH v2 2/9] gnu: Add go-github-com-google-go-tpm Sharlatan Hellseher
2024-07-04 11:10   ` [bug#70684] [PATCH v2 3/9] gnu: Add go-github-com-x448-float16 Sharlatan Hellseher
2024-07-04 11:10   ` [bug#70684] [PATCH v2 4/9] gnu: Add go-github-com-abadojack-whatlanggo Sharlatan Hellseher
2024-07-04 11:10   ` [bug#70684] [PATCH v2 5/9] gnu: Add go-github-com-fxamacker-cbor-v2 Sharlatan Hellseher
2024-07-04 11:10   ` [bug#70684] [PATCH v2 6/9] gnu: Add go-github-com-go-webauthn-x Sharlatan Hellseher
2024-07-04 11:10   ` [bug#70684] [PATCH v2 7/9] gnu: Add go-github-com-go-webauthn-webauthn Sharlatan Hellseher
2024-07-04 11:10   ` [bug#70684] [PATCH v2 8/9] gnu: miniflux: Update to 2.1.3 Sharlatan Hellseher
2024-07-04 11:10   ` [bug#70684] [PATCH v2 9/9] gnu: miniflux: Adjust indentation Sharlatan Hellseher
2024-07-11 12:12 ` bug#70684: [PATCH go-team 0/6] Update miniflux to 2.1.3 Sharlatan Hellseher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v83po2ap.fsf@gmail.com \
    --to=rodion.goritskov@gmail.com \
    --cc=70684@debbugs.gnu.org \
    --cc=sharlatanus@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).