From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id WMV2NPe9cmbXewEA62LTzQ:P1 (envelope-from ) for ; Wed, 19 Jun 2024 11:16:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id WMV2NPe9cmbXewEA62LTzQ (envelope-from ) for ; Wed, 19 Jun 2024 13:16:07 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=nicolasgoaziou.fr header.s=mailo header.b=k4+z4sOu; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1718795767; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=/XC4dAT6c9woGk7Mp0VpcU88CQOHGV8uxR/h4m8v9gY=; b=Pv0j2OUoZtFBM/XSpDCwndWQ1YFTeJaPu1VNMHiMt9MmkY3pLk/H705F3U247XtcBny6SM 01lvCfy25xNo/f8bdC8/IOOZfWYQYZCS9lTpHq1kSVHtOua3mEV6Eawp3RKoJ72GnUVkCH Q0aspfI8fWAg5sFJCyXNj1P/82c/3qtBlkV0P4HR7qvz04vY6iM7Tc6abDX7Ye3kjzAAwY 0PQ0phNTY2WmS15IyD5YHr2l3EHh8sAb7paYmS9M9dO9jW3ZFEPoB6GCVeWxishupry5Um oCELZVr42xBSHolBtmpfvmdn2M1gxNvhvYpMruZzujbfSThT7wPjPbN2AIBm/w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1718795767; a=rsa-sha256; cv=none; b=YS/6q7SCchZZ9Y93LB6NyZbIHM3u72ewpuGq+UexFIdrupylbrlDm7m3bUSCrLNV11WjVT rDoG6yvr2CmYiaU52azKg3p5Tzf/REcRVTOm46oQLDU/zI+p4+t0ZzVS8PHfcWqKDQISfP ScxnidUH9EC2zcV4bEbFrLE2dmemmLeOf/Lr0PbXIZxYmQMGvqGfl4umouwTyR/Szc0X0j 3K8iNDwDoHwvjgplkYQHxB7uIBunNYfpVQd8BSy0Wik/fd6FygcTfGTu21HoyYTIpP+G2/ v6U/AAk3u7md7hj2vn46XnlFmkTDSDvJqmXkbqhRf1q8MzqYS6FXza3eMTKDAQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=nicolasgoaziou.fr header.s=mailo header.b=k4+z4sOu; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6B97C65BFB for ; Wed, 19 Jun 2024 13:16:06 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJtIG-0002rO-Rv; Wed, 19 Jun 2024 07:16:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJtIF-0002qr-2H for guix-patches@gnu.org; Wed, 19 Jun 2024 07:15:59 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sJtIE-0007wp-JQ for guix-patches@gnu.org; Wed, 19 Jun 2024 07:15:58 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sJtIH-0001cD-NW for guix-patches@gnu.org; Wed, 19 Jun 2024 07:16:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71319] [PATCH v2 3/3] gnu: emacs-ddskk-nicola: Improve package style. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 19 Jun 2024 11:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71319 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: gemmaro Cc: 71319@debbugs.gnu.org, Katherine Cox-Buday , Liliana Marie Prikler , Andrew Tropin Received: via spool by 71319-submit@debbugs.gnu.org id=B71319.17187957066129 (code B ref 71319); Wed, 19 Jun 2024 11:16:01 +0000 Received: (at 71319) by debbugs.gnu.org; 19 Jun 2024 11:15:06 +0000 Received: from localhost ([127.0.0.1]:40270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJtHO-0001am-83 for submit@debbugs.gnu.org; Wed, 19 Jun 2024 07:15:06 -0400 Received: from msg-2.mailo.com ([213.182.54.12]:37930 helo=mailo.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJtHL-0001Zs-Tb for 71319@debbugs.gnu.org; Wed, 19 Jun 2024 07:15:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=nicolasgoaziou.fr; s=mailo; t=1718795693; bh=Rp1bSSsyCeXyQj5PWrrPxrbt70wulepqN/4FCg4twBI=; h=X-EA-Auth:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type; b=k4+z4sOuaLiuOVlhHf+MP7pi/fvcUZ02PXkit6XcvtWuKqY0cq8roTMEmeG3DeHZu ULBro1dHGQxiqq8iiHiMRTsc4xp6aeEPiZwKwjN5hpHz84ktjCJ/MxhAnmIJCJ/91s 0fraonC5cyZtC0Dwpaxk8nnIPLjxdk45c+Okml7o= Received: by b221-2.in.mailobj.net [192.168.90.22] with ESMTP via ip-20.mailobj.net [213.182.54.20] Wed, 19 Jun 2024 13:14:53 +0200 (CEST) X-EA-Auth: ow7GM2+synhYkrDQpGoU1au1usZnaG4+FajfvaGcKHTnctCRWWc2qevNaM51CFShYWhT0OGl30Hqn3eovOJyaoucuvHmmEAkho5MwXgN0Fk= In-Reply-To: <80aa9ac79b1b8577ce04dec98909fb9e2d0bf9fc.1718104831.git.gemmaro.dev@gmail.com> (gemmaro's message of "Tue, 11 Jun 2024 20:20:31 +0900") References: <4328ea3c1b2e79691a6ed1d76e21688a5452f410.1718104831.git.gemmaro.dev@gmail.com> <80aa9ac79b1b8577ce04dec98909fb9e2d0bf9fc.1718104831.git.gemmaro.dev@gmail.com> Date: Wed, 19 Jun 2024 13:14:37 +0200 Message-ID: <87v825421u.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Nicolas Goaziou X-ACL-Warn: , Nicolas Goaziou via Guix-patches From: Nicolas Goaziou via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -2.36 X-Spam-Score: -2.36 X-Migadu-Queue-Id: 6B97C65BFB X-Migadu-Scanner: mx11.migadu.com X-TUID: 15CelTMQaZNu Hello, gemmaro writes: > * gnu/packages/emacs-xyz.scm (emacs-ddskk-nicola)[arguments]: Use newer > package style. This is necessary due to the emacs-ddskk package style update > since emacs-ddskk-nicola inherits this. It also removes the last #t values > from the lambda expressions in phases. Thank you. Some comments follow. > + (append > + (list #:make-flags > + #~(let ((out (assoc-ref %outputs "out"))) You can remove this and use #$output instead. > + (append > + (list (string-append "PREFIX=" out) > + (string-append "LISPDIR=" out "/share/emacs/site-lisp")))) See above. > + #:tests? #f ;no tests in this subtree > + ) Please do not leave dangling parenthesis like this one. > + (substitute-keyword-arguments (package-arguments emacs-ddskk) > + ((#:phases phases) > + #~(modify-phases #$phases > + (add-after 'unpack 'chdir > + (lambda _ > + (chdir "nicola"))) > + (replace 'configure > + (lambda* (#:key outputs #:allow-other-keys) > + (make-file-writable "NICOLA-DDSKK-CFG") > + (emacs-substitute-sexps "NICOLA-DDSKK-CFG" > + ("setq NICOLA-DDSKK_PREFIX" ""))))))))) You can use (lambda _ ...) instead of (lambda* (#:key outputs ...) ...) since you don't make use of OUTPUTS argument. Regards, -- Nicolas Goaziou