From: Nicolas Goaziou via Guix-patches via <guix-patches@gnu.org>
To: gemmaro <gemmaro.dev@gmail.com>
Cc: 71319@debbugs.gnu.org,
Katherine Cox-Buday <cox.katherine.e+guix@gmail.com>,
Liliana Marie Prikler <liliana.prikler@gmail.com>,
Andrew Tropin <andrew@trop.in>
Subject: [bug#71319] [PATCH v2 3/3] gnu: emacs-ddskk-nicola: Improve package style.
Date: Wed, 19 Jun 2024 13:14:37 +0200 [thread overview]
Message-ID: <87v825421u.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <80aa9ac79b1b8577ce04dec98909fb9e2d0bf9fc.1718104831.git.gemmaro.dev@gmail.com> (gemmaro's message of "Tue, 11 Jun 2024 20:20:31 +0900")
Hello,
gemmaro <gemmaro.dev@gmail.com> writes:
> * gnu/packages/emacs-xyz.scm (emacs-ddskk-nicola)[arguments]: Use newer
> package style. This is necessary due to the emacs-ddskk package style update
> since emacs-ddskk-nicola inherits this. It also removes the last #t values
> from the lambda expressions in phases.
Thank you. Some comments follow.
> + (append
> + (list #:make-flags
> + #~(let ((out (assoc-ref %outputs "out")))
You can remove this and use #$output instead.
> + (append
> + (list (string-append "PREFIX=" out)
> + (string-append "LISPDIR=" out "/share/emacs/site-lisp"))))
See above.
> + #:tests? #f ;no tests in this subtree
> + )
Please do not leave dangling parenthesis like this one.
> + (substitute-keyword-arguments (package-arguments emacs-ddskk)
> + ((#:phases phases)
> + #~(modify-phases #$phases
> + (add-after 'unpack 'chdir
> + (lambda _
> + (chdir "nicola")))
> + (replace 'configure
> + (lambda* (#:key outputs #:allow-other-keys)
> + (make-file-writable "NICOLA-DDSKK-CFG")
> + (emacs-substitute-sexps "NICOLA-DDSKK-CFG"
> + ("setq NICOLA-DDSKK_PREFIX" "")))))))))
You can use (lambda _ ...) instead of (lambda* (#:key outputs ...) ...)
since you don't make use of OUTPUTS argument.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2024-06-19 11:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-02 7:56 [bug#71319] [PATCH 0/2] gnu: emacs-ddskk: Update to 17.1 revision 0 gemmaro
2024-06-02 9:08 ` [bug#71319] [PATCH 1/2] " gemmaro
2024-06-02 9:08 ` [bug#71319] [PATCH 2/2] gnu: emacs-ddskk: Improve package style gemmaro
2024-06-11 11:20 ` [bug#71319] [PATCH v2 1/3] gnu: emacs-ddskk: Update to 17.1 revision 0 gemmaro
2024-06-11 11:20 ` [bug#71319] [PATCH v2 2/3] gnu: emacs-ddskk: Improve package style gemmaro
2024-06-19 11:16 ` Nicolas Goaziou via Guix-patches via
2024-06-11 11:20 ` [bug#71319] [PATCH v2 3/3] gnu: emacs-ddskk-nicola: " gemmaro
2024-06-19 11:14 ` Nicolas Goaziou via Guix-patches via [this message]
2024-06-19 11:12 ` [bug#71319] [PATCH v2 1/3] gnu: emacs-ddskk: Update to 17.1 revision 0 Nicolas Goaziou via Guix-patches via
2024-06-19 23:32 ` [bug#71319] [PATCH v3 " gemmaro
2024-06-19 23:32 ` [bug#71319] [PATCH v3 2/3] gnu: emacs-ddskk: Improve package style gemmaro
2024-06-20 16:04 ` Liliana Marie Prikler
2024-06-19 23:32 ` [bug#71319] [PATCH v3 3/3] gnu: emacs-ddskk-nicola: " gemmaro
2024-06-20 16:06 ` Liliana Marie Prikler
2024-06-21 23:02 ` [bug#71319] [PATCH v4 1/3] gnu: emacs-ddskk: Update to 17.1 revision 0 gemmaro
2024-06-21 23:02 ` [bug#71319] [PATCH v4 2/3] gnu: emacs-ddskk: Use newer package style gemmaro
2024-06-21 23:02 ` [bug#71319] [PATCH v4 3/3] gnu: emacs-ddskk-nicola: Use new " gemmaro
2024-06-23 8:16 ` bug#71319: " Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v825421u.fsf@nicolasgoaziou.fr \
--to=guix-patches@gnu.org \
--cc=71319@debbugs.gnu.org \
--cc=andrew@trop.in \
--cc=cox.katherine.e+guix@gmail.com \
--cc=gemmaro.dev@gmail.com \
--cc=liliana.prikler@gmail.com \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).