From: Richard Sent <richard@freakingpenguin.com>
To: vicvbcun <guix@ikherbers.com>
Cc: 71594@debbugs.gnu.org
Subject: [bug#71594] [PATCH] file-systems: Allow specifying CIFS credentials in a file.
Date: Thu, 20 Jun 2024 11:22:15 -0400 [thread overview]
Message-ID: <87v823r654.fsf@freakingpenguin.com> (raw)
In-Reply-To: <ZnQrsGzmiLNYzT0n@localhost> (vicvbcun's message of "Thu, 20 Jun 2024 15:16:32 +0200")
Hi vicvbcun!
vicvbcun <guix@ikherbers.com> writes:
> Hi,
>
> thanks for the review!
>> I believe CIFS will add a password2 mount option in 6.9.4 [1]. We should
>> check if mount.cifs supports putting that option in the credentials file
>> and match their behavior. If that's too much an ask (Guix's mount.cifs
>> may not be new enough), I think a comment or proactive bug report is
>> appropriate.
>
> Looking at the latest version of mount.cifs[0], it doesn't seem to
> handle `password2' intentionally: Passing `password2' on the command
> line should work, but only because the return value of `parse_opt_token'
> is not checked for `OPT_ERROR'; in a credentials file it is accepted (as
> `parse_cred_line' only checks for a "pass" prefix) but passed as
> `password' instead.
>
> I think that being able to specify `password2' in a credentials file
> makes sense and my patch doesn't forbid it.
>
> If exposing an interface identical to that of `mount.cifs' and
> preserving the exact semantics (e.g `mount.cifs' complains when multiple
> passwords are specified and takes the first one) is the ultimate goal,
> I'd just shell out to `mount.cifs'. I certainly won't implement all the
> idiosyncrasies :).
>
> 0: https://git.samba.org/?p=cifs-utils.git;a=blob;f=mount.cifs.c;h=3b7a6b3c22e8c3b563c7ea92ecb9891fdfac01a6;hb=refs/heads/for-next
Agreed, emulating mount.cifs in totality is too much. My concern with
divergences in functionality is most users will read mount.cifs
documentation for CIFS mount-options and whatnot, then potentially get
bit when Guix does something different.
In this case the divergence is small and shouldn't cause issues. I think
a XXX: style comment is appropriate.
--8<---------------cut here---------------start------------->8---
;; Read password, user and domain options from file
;;
;; XXX: Unlike mount.cifs this function reads password2 in the
;; credential file and returns it separately from password.
--8<---------------cut here---------------end--------------->8---
I wouldn't be surprised if mount.cifs eventually adopts the same
behavior. I can't think of a reason why putting password2 in the
credentials file shouldn't be supported.
--
Take it easy,
Richard Sent
Making my computer weirder one commit at a time.
next prev parent reply other threads:[~2024-06-20 15:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-16 15:59 [bug#71594] [PATCH] file-systems: Allow specifying CIFS credentials in a file vicvbcun
2024-06-18 13:55 ` Richard Sent
2024-06-20 13:16 ` vicvbcun
2024-06-20 15:22 ` Richard Sent [this message]
2024-06-26 12:32 ` guix
2024-06-20 12:58 ` [bug#71594] [PATCH v2] " vicvbcun
2024-06-26 12:15 ` [bug#71594] [PATCH v3] " vicvbcun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v823r654.fsf@freakingpenguin.com \
--to=richard@freakingpenguin.com \
--cc=71594@debbugs.gnu.org \
--cc=guix@ikherbers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).