* [bug#71735] [PATCH] services: mpd: fix log to file
@ 2024-06-23 14:15 Yarl Baudig via Guix-patches via
2024-06-24 1:45 ` bug#71735: " Maxim Cournoyer
0 siblings, 1 reply; 2+ messages in thread
From: Yarl Baudig via Guix-patches via @ 2024-06-23 14:15 UTC (permalink / raw)
To: 71735; +Cc: Yarl Baudig
(match value (%unset-value ...)) is equivalent here to
(match value (_ ...)). Even if you set 'log-file to some path, it's always
"syslog" in the configuration file.
* gnu/services/audio.scm (mpd): fix buggy 'match'.
---
gnu/services/audio.scm | 16 ++++++----------
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/gnu/services/audio.scm b/gnu/services/audio.scm
index ae991ced4d..2c8af138e7 100644
--- a/gnu/services/audio.scm
+++ b/gnu/services/audio.scm
@@ -251,16 +251,12 @@ (define (mpd-group-sanitizer value)
(configuration-field-error #f 'group value))))
(define (mpd-log-file-sanitizer value)
- (match value
- (%unset-value
- ;; XXX: While leaving the 'sys_log' option out of the mpd.conf file is
- ;; supposed to cause logging to happen via systemd (elogind provides a
- ;; compatible interface), this doesn't work (nothing gets logged); use
- ;; syslog instead.
- "syslog")
- ((? string?)
- value)
- (_ (configuration-field-error #f 'log-file value))))
+ ;; XXX: While leaving the 'sys_log' option out of the mpd.conf file is
+ ;; supposed to cause logging to happen via systemd (elogind provides a
+ ;; compatible interface), this doesn't work (nothing gets logged); use
+ ;; syslog instead.
+ (let ((value (maybe-value value "syslog")))
+ (if (string? value) value (configuration-field-error #f 'log-file value))))
;;;
--
2.45.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#71735: [PATCH] services: mpd: fix log to file
2024-06-23 14:15 [bug#71735] [PATCH] services: mpd: fix log to file Yarl Baudig via Guix-patches via
@ 2024-06-24 1:45 ` Maxim Cournoyer
0 siblings, 0 replies; 2+ messages in thread
From: Maxim Cournoyer @ 2024-06-24 1:45 UTC (permalink / raw)
To: Yarl Baudig; +Cc: 71735-done
Hi Yarl,
Yarl Baudig <yarl-baudig@mailoo.org> writes:
> (match value (%unset-value ...)) is equivalent here to
> (match value (_ ...)). Even if you set 'log-file to some path, it's always
> "syslog" in the configuration file.
Interesting! It seems like using a variable in the pattern doesn't work
as I had expected... Thanks for the fix.
> * gnu/services/audio.scm (mpd): fix buggy 'match'.
> ---
> gnu/services/audio.scm | 16 ++++++----------
> 1 file changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/gnu/services/audio.scm b/gnu/services/audio.scm
> index ae991ced4d..2c8af138e7 100644
> --- a/gnu/services/audio.scm
> +++ b/gnu/services/audio.scm
> @@ -251,16 +251,12 @@ (define (mpd-group-sanitizer value)
> (configuration-field-error #f 'group value))))
>
> (define (mpd-log-file-sanitizer value)
> - (match value
> - (%unset-value
> - ;; XXX: While leaving the 'sys_log' option out of the mpd.conf file is
> - ;; supposed to cause logging to happen via systemd (elogind provides a
> - ;; compatible interface), this doesn't work (nothing gets logged); use
> - ;; syslog instead.
> - "syslog")
> - ((? string?)
> - value)
> - (_ (configuration-field-error #f 'log-file value))))
> + ;; XXX: While leaving the 'sys_log' option out of the mpd.conf file is
> + ;; supposed to cause logging to happen via systemd (elogind provides a
> + ;; compatible interface), this doesn't work (nothing gets logged); use
> + ;; syslog instead.
> + (let ((value (maybe-value value "syslog")))
> + (if (string? value) value (configuration-field-error #f 'log-file value))))
Applied, closing!
--
Thanks,
Maxim
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-24 1:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-23 14:15 [bug#71735] [PATCH] services: mpd: fix log to file Yarl Baudig via Guix-patches via
2024-06-24 1:45 ` bug#71735: " Maxim Cournoyer
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).