From: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
Cc: Josselin Poiret <dev@jpoiret.xyz>,
Simon Tournier <zimon.toutoune@gmail.com>,
Mathieu Othacehe <othacehe@gnu.org>,
Tobias Geerinckx-Rice <me@tobias.gr>,
Nigko Yerden <nigko.yerden@gmail.com>,
Christopher Baines <guix@cbaines.net>,
72867@debbugs.gnu.org
Subject: [bug#72867] [PATCH] gexp: Make 'local-file' follow symlinks.
Date: Thu, 29 Aug 2024 12:10:09 +0200 [thread overview]
Message-ID: <87v7zjbpxa.fsf@pelzflorian.de> (raw)
In-Reply-To: <87frqnhffj.fsf@gnu.org> ("Ludovic Courtès"'s message of "Thu, 29 Aug 2024 11:00:16 +0200")
Hello all. Thank you to Nigko for sending the patch.
Nigko Yerden <nigko.yerden@gmail.com> writes:
> This patch is the result of collective work of
> Florian Pelz <pelzflorian@pelzflorian.de> and
> Nigko Yerden <nigko.yerden@gmail.com>
All real contribution to this patch is Nigko’s work.
I contributed only the error location in a failed fix.
Ludovic Courtès <ludo@gnu.org> writes:
> I haven’t read the thread above. Could you come up with a test case
> that shows the problem being fixed? (That is, the test should fail when
> run on current ‘master’.)
Nigko sums up the fixed issue in
<https://lists.gnu.org/archive/html/guix-devel/2024-08/msg00071.html>:
> pelzflorian (Florian Pelz) wrote:
>> Nonsense; it must have worked; 7.7 Wrapping Up lists
>> https://git.savannah.gnu.org/cgit/guile.git/tree/.guix/modules/guile-package.scm?id=cd57379b3df636198d8cd8e76c1bfbc523762e79
>> as proof.
> […]
> For me pulling from this channel with subsequent
>
> $ guix build guile@3.0.99-git
>
> throws an error ("No such file or directory" "GUILE-VERSION"). However,
>
> $ GUILE_LOAD_PATH= guix build guile@3.0.99-git
>
> , which emulates system without [1] in Guile load path, works like a charm.
> Thus, this repository behaves exactly as does the main branch of [2].
>
> Perhaps many systems (e.g. Guix on foreign distributions) indeed does not
> have [1] in Guile load path, and thus recipe from the Cookbook works for them.
> Regards,
> Nigko
>
> [1] ~/.config/guix/current/share/guile/site/3.0/
> [2] https://gitlab.com/anigko/test-channel.git
There are currently no tests for `current-source-directory'.
To make a test case like in test/channels.scm, we would have to make
a new guile process or build process, I presume?
Regards,
Florian
next prev parent reply other threads:[~2024-08-29 10:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 6:06 [bug#72867] [PATCH] gexp: Make 'local-file' follow symlinks Nigko Yerden
2024-08-29 7:01 ` [bug#72867] when should local-file and current-source-directory not follow symlinks? Attila Lendvai
2024-08-29 9:00 ` [bug#72867] [PATCH] gexp: Make 'local-file' follow symlinks Ludovic Courtès
2024-08-29 10:10 ` pelzflorian (Florian Pelz) [this message]
2024-08-30 12:07 ` Nigko Yerden
2024-08-30 14:00 ` [bug#72867] when should local-file and current-source-directory not follow symlinks? Nigko Yerden
2024-08-31 17:10 ` pelzflorian (Florian Pelz)
2024-09-01 14:13 ` Tobias Geerinckx-Rice via Guix-patches via
2024-09-02 4:41 ` [bug#72867] [PATCH v2] gexp: Make 'local-file' follow symlinks Nigko Yerden
2024-09-02 7:53 ` [bug#72867] [PATCH v3] " Nigko Yerden
2024-09-03 15:05 ` pelzflorian (Florian Pelz)
2024-09-05 5:06 ` Nigko Yerden
2024-09-05 4:16 ` [bug#72867] [PATCH v4] " Nigko Yerden
2024-09-06 4:17 ` [bug#72867] [PATCH v5] " Nigko Yerden
2024-09-07 7:35 ` pelzflorian (Florian Pelz)
2024-09-25 5:16 ` pelzflorian (Florian Pelz)
2024-09-26 7:07 ` [bug#72867] [PATCH v6] " Nigko Yerden via Guix-patches
2024-10-02 16:15 ` Ludovic Courtès
2024-10-03 13:22 ` pelzflorian (Florian Pelz)
2024-10-06 7:09 ` pelzflorian (Florian Pelz)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v7zjbpxa.fsf@pelzflorian.de \
--to=pelzflorian@pelzflorian.de \
--cc=72867@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=guix@cbaines.net \
--cc=me@tobias.gr \
--cc=nigko.yerden@gmail.com \
--cc=othacehe@gnu.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).