unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
To: Nigko Yerden <nigko.yerden@gmail.com>
Cc: Attila Lendvai <attila@lendvai.name>, 72867@debbugs.gnu.org
Subject: [bug#72867] when should local-file and current-source-directory not follow symlinks?
Date: Sat, 31 Aug 2024 19:10:05 +0200	[thread overview]
Message-ID: <87v7zg1uvm.fsf@pelzflorian.de> (raw)
In-Reply-To: <486161ee-563b-4de8-8cef-a970f5862fd0@gmail.com> (Nigko Yerden's message of "Fri, 30 Aug 2024 19:00:38 +0500")

Nigko Yerden <nigko.yerden@gmail.com> writes:
> Attila Lendvai wrote:
>> pardon my ignorance, but can you give me a (plausible) example when
>> someone wants to load some files relative to a source file, and also
>> wants to be conscious of symlinks, and chose not to follow them? let
>> alone making that the default anywhere around such operations?
> No, I can't give you an example. The original 'current-source-directory' was
> designed not to follow symlinks. This wasn't my idea. By setting the default
> I just keep the original behavior.

I guess not following symlinks was not design but an oversight.

Profiles like .config/guix/current have lots of symlinks.  Perhaps
behavior might change when custom code is processing profiles.

If we ignored possible custom code breakage, this patch could be
simplified, but not to a one-liner, as it canonicalizes paths in both
`current-source-directory' (when not in the load-path) and
`absolute-dirname' (when in the load-path).

Regards,
Florian




  reply	other threads:[~2024-08-31 17:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-29  6:06 [bug#72867] [PATCH] gexp: Make 'local-file' follow symlinks Nigko Yerden
2024-08-29  7:01 ` [bug#72867] when should local-file and current-source-directory not follow symlinks? Attila Lendvai
2024-08-29  9:00 ` [bug#72867] [PATCH] gexp: Make 'local-file' follow symlinks Ludovic Courtès
2024-08-29 10:10   ` pelzflorian (Florian Pelz)
2024-08-30 12:07     ` Nigko Yerden
2024-08-30 14:00 ` [bug#72867] when should local-file and current-source-directory not follow symlinks? Nigko Yerden
2024-08-31 17:10   ` pelzflorian (Florian Pelz) [this message]
2024-09-01 14:13     ` Tobias Geerinckx-Rice via Guix-patches via
2024-09-02  4:41 ` [bug#72867] [PATCH v2] gexp: Make 'local-file' follow symlinks Nigko Yerden
2024-09-02  7:53 ` [bug#72867] [PATCH v3] " Nigko Yerden
2024-09-03 15:05   ` pelzflorian (Florian Pelz)
2024-09-05  5:06     ` Nigko Yerden
2024-09-05  4:16 ` [bug#72867] [PATCH v4] " Nigko Yerden
2024-09-06  4:17 ` [bug#72867] [PATCH v5] " Nigko Yerden
2024-09-07  7:35   ` pelzflorian (Florian Pelz)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v7zg1uvm.fsf@pelzflorian.de \
    --to=pelzflorian@pelzflorian.de \
    --cc=72867@debbugs.gnu.org \
    --cc=attila@lendvai.name \
    --cc=nigko.yerden@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).