From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 2KMWHVk01mZXJwEAqHPOHw:P1 (envelope-from ) for ; Mon, 02 Sep 2024 21:55:37 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id 2KMWHVk01mZXJwEAqHPOHw (envelope-from ) for ; Mon, 02 Sep 2024 23:55:37 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=K5sW5Mfg; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=TjabWuNZ; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1725314137; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=FNjtBXTrWTaK/GSBkZgPOVQZf+r7v4vAelw64edbQfY=; b=kSNdFmKNyXoPzJd91REBPd5VCFWVM9LR73YWu4BU5wZA18mUJjamijlyt0zE8EARJ8tvWA yawKtHi1Nez3I5rPmXZHH0+bVFfc/7nCSXje2bietUuV9wT0wqVFd0AhA7MqjCKbqQM5Yp C0WIBVAL4SSgV55453/Fdu6H4p9/WthXGshgXU+u4fMYwL5qbUQXsNNwIGtuGkMEJ63hJ1 h1GCKauFMrG3E7QRjH3ycYvZg5kzYa3PB2kaAGWV70rK4TMplg/I8b2hiuxGo8TnztRqpV 7Licg0eCjuODpZUyeI/tAhcyVtKGKu5ebxruvfdplkOtY0uSnoFBrCFWmb5NYQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=K5sW5Mfg; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=TjabWuNZ; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1725314137; a=rsa-sha256; cv=none; b=kzQdPnM4Bsx6ST2jDkK8p1jUuRByP3yLXLvCksGtfu2SLnTsw9plGSZ9FxkuiAcd1npLfz C/X1hm98HJwY01ld1LWiQuwxRJ6hbF40VUbYQTrVQt4bPWNW8GQD/Qg3rBgMmo8nigATUb MQH17lGqI7+bY6kChUJqR1TQLy7le9urpscxGFgfdvQmIKnZQS3BLborwQk6MSj/to1DRH FGJdaYtbDxZXNqIMqf5yUBqPlj4caA2BMlXsUh2gZNmyTwrUQZziXpnVIsq1NjKL/CIQOD JgEhvNl5wkmVZmLeWPkgLceoJEyMJ7hNhG+vpmpjQxx7ZyOMu3xVM1C1X+W5IQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5C0086D4B7 for ; Mon, 2 Sep 2024 23:55:37 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1slF0v-00031x-Fn; Mon, 02 Sep 2024 17:55:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1slF0n-00030y-J7 for guix-patches@gnu.org; Mon, 02 Sep 2024 17:55:02 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1slF0n-00019u-96 for guix-patches@gnu.org; Mon, 02 Sep 2024 17:55:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:From:Date:To:In-Reply-To:References:Subject; bh=FNjtBXTrWTaK/GSBkZgPOVQZf+r7v4vAelw64edbQfY=; b=K5sW5MfgTqGUpv5bYHtldCTRjpZuJ2pr8sFSm0UNx+IWIEjutEU+yTAgpGwEPobxPImIh3sDjDLY/AhL3IssC8BVCplLPJakSLJQ/BR8hxQjgwzsYoc9namV5eE2OxsCQGrkzVt0fF2BFuQmXasX5Q8AmbpscbWBoeOofbpHqu3xnQJbeDjcP7UDDiTtBEEPvIJ8/2vaQvoo1N252LYJVbpdpWAU08+rR4028b0tpqT7fWpejNRuo/yBKgG2crqlBpS1bjtrjOd7ElhO/oFypKSSFc5Sr57nQP31/kUpAA36ecv91nOZsFDmLa5LeoNBdHhKvZsbGNGMOM23Z0DTjg==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1slF1m-0007qX-ET for guix-patches@gnu.org; Mon, 02 Sep 2024 17:56:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72943] [PATCH] gnu: gd: Requires.private to propagated inputs References: <20240901191119.29870-1-rutherther@protonmail.com> In-Reply-To: <20240901191119.29870-1-rutherther@protonmail.com> Resent-From: Rutherther Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 02 Sep 2024 21:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72943 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 72943@debbugs.gnu.org Cc: Rutherther , Carlo Zancanaro , Tobias Geerinckx-Rice Received: via spool by 72943-submit@debbugs.gnu.org id=B72943.172531413730101 (code B ref 72943); Mon, 02 Sep 2024 21:56:02 +0000 Received: (at 72943) by debbugs.gnu.org; 2 Sep 2024 21:55:37 +0000 Received: from localhost ([127.0.0.1]:52808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slF1M-0007pJ-Tw for submit@debbugs.gnu.org; Mon, 02 Sep 2024 17:55:37 -0400 Received: from mail-4322.protonmail.ch ([185.70.43.22]:48409) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1slAn7-0006Mg-Io for 72943@debbugs.gnu.org; Mon, 02 Sep 2024 13:24:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1725297809; x=1725557009; bh=FNjtBXTrWTaK/GSBkZgPOVQZf+r7v4vAelw64edbQfY=; h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=TjabWuNZGGo4aVpfAe15mjH4uU/yGJGiM5f9kgnDVzEVr2Wgv7GErJlw5x8FUudf1 /x1Cg0zBCTfcd9jXJrbrl51DIHEIizVZdqaxr0AfB2uXUSdzgNK/+FCb/DL6lRWqlH Mvs/ONVlHaaucITuY9Blq+rt19lCsFxlZfaqreI+6brOeST6F207vo3OaxNoVIMq4g lILY1bi8Od9T3XX7oYYWGdyN6+dryqH0MwEodXeDN9Fp/A2wzsfVe4lePG51vTDC7i xAgizlgjBh9BINncV6ZhepR+OIut8pbXAQCS2tyYa4MQnlgIosna7YUGwtJ/LULglW aIEYWSblN36CQ== Date: Mon, 02 Sep 2024 17:23:22 +0000 Message-ID: <87v7zeezr1.fsf@protonmail.com> Feedback-ID: 8107604:user:proton X-Pm-Message-ID: 74f8fef67c21f962942449c2f96dc241a2292eca MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Mon, 02 Sep 2024 17:55:32 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Rutherther X-ACL-Warn: , Rutherther via Guix-patches From: Rutherther via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 5C0086D4B7 X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -6.98 X-Spam-Score: -6.98 X-TUID: xyYUHOyBkOMg Hello Carlo, thank you for finding that! That explains why this issue was caused in the first place, I was wondering how this could've been unspotted till now. It seems much better to me to not use propagated-inputs whenever possible, so I prefer your solution to this one. However, I do wonder about this: oth= er packages that have Requires.private do provide the libraries in these as propagated-input= s. Also the cookbook shows to do this with such libraries. What is the correct appr= oach here then? Maybe every package that has Requires.private could be patched like t= his, possibly somehow automatically instead of manual patches? I am quite new here, this is my first patch. So I am not really sure how to= go about this. Will you open a new issue with your patch, and maintainers will decide patc= h from which issue to use? Or is it enough it's in this issue? I am sending an updated patch with a comment for why specifying propagates-inputs would be necessary in the meantime, as Tobias suggested me in a review in #guix IRC channel. --- gnu/packages/gd.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gnu/packages/gd.scm b/gnu/packages/gd.scm index 98d34cfa71..1380493c44 100644 --- a/gnu/packages/gd.scm +++ b/gnu/packages/gd.scm @@ -85,7 +85,8 @@ (define-public gd "\\.la$"))))))) (native-inputs (list pkg-config)) - (inputs + ;; These libraries are in 'Requires.private' in libgd.pc. + (propagated-inputs (list fontconfig freetype libjpeg-turbo --=20 2.45.2