From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id IBUvGcf1D2eftQAAqHPOHw:P1 (envelope-from ) for ; Wed, 16 Oct 2024 17:20:07 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id IBUvGcf1D2eftQAAqHPOHw (envelope-from ) for ; Wed, 16 Oct 2024 19:20:07 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="Ls/dehtQ"; dkim=fail ("headers rsa verify failed") header.d=ngraves.fr header.s=ovhmo4487190-selector1 header.b=K+p4bhgV; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1729099207; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=4PVIWQxnit+eigMIaJCwOMAqRYF2dY4lgCVwJyTf2Nw=; b=W0h1leK7zuDlCkkahwotQ4LgoMy60tV+WKQDdOPkvSsFxL6h/rarEojwaenzAzxTXaoNl+ qT0fR4gM5Gz1Tgd/tTdHvmXnBjhPVmPXjIl1IkZc/ad5/R73fAnx+CM+jD+hVqpDjYvhUc by3H71sogLdmYQVuUqJI5NsIr1T8x+gMRndDHD45Nlg6cS1A1SOkQAebXMDexdU1icvXSR 8n1gGqyulNsWUIZJJ7mixNregGDWwxbRgknplTJNODvdnaxSlJ40K5PW5OpRsVBqVolvRs HtTz8hokUAQn2uanmxy5vq93gMaknSR2CakZh9fGy/QfNQwo/o9HQvPMCI4fTw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="Ls/dehtQ"; dkim=fail ("headers rsa verify failed") header.d=ngraves.fr header.s=ovhmo4487190-selector1 header.b=K+p4bhgV; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1729099207; a=rsa-sha256; cv=none; b=p+U2PsGxIDVYIFcUPGZasnDl8X8OqmY2PT9YDJ8UHAE7eXuTOKhGiQB9lCIYHl/XgdTIiP JcvjA7Wt3shGEN8besi9/sOymvs3jEn7j+fE0vWbFxKKHrkF7Rz49Z+PUpoI+yyXtTtWr0 q0YFh35Oj5QwsYY890aOdRvfFl6xK3xuY2sQtQxPHndvBR6wUkFt+Cq5J8q9UmNeq/TRDj UI3jxKcTyeJw2cawq9T8V2s7/yocLOhfSKlefraToBf/jGn8O6qMxOO4Lnvn5klI1Ujxr4 cUMNIqYalxDylDE5plghNqtF+p90GnL+keRb2zmzOHPrEat/K9jeyDpcL3Om0w== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E044278B2A for ; Wed, 16 Oct 2024 19:20:06 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t17gZ-000764-2I; Wed, 16 Oct 2024 13:19:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t17gW-00075o-AY for guix-patches@gnu.org; Wed, 16 Oct 2024 13:19:45 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t17gV-0004qC-NZ for guix-patches@gnu.org; Wed, 16 Oct 2024 13:19:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=4PVIWQxnit+eigMIaJCwOMAqRYF2dY4lgCVwJyTf2Nw=; b=Ls/dehtQ6R/bjvsqw7+wkItaZd3NhNOoFgmiIpfrrA55ZNs5LasRWWiYkR1x+hFvcdtgFmQJ7V3uvsiPf5UZNzMUeDCbRTEC/LhVMeFo3Zj2TNVDdaFHn69ABwAjI0j4ThQ45vyeHfbUAKsEt/UITboNkDz2H00SXdyGt2riEd5ruylP/i6R5cwiWfXQiWrfqlsTkLjFuydG5UjpkLRsWdaaH7AdTVBP/D40Z3oVxBjQpTa3TUSRq+wj9VDWwBtJL1IcGc1XdVgA8tbmZQ7q0/6AdWGdv2N8RayThvhS6lT/sBSXWh6uZkJ8OD6WkYDkAJguLmeIfeX/1cIIZ8UmKA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t17go-0003VN-Eg for guix-patches@gnu.org; Wed, 16 Oct 2024 13:20:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#73692] [PATCH v2] gnu: timescaledb: Ignore failing tests. Resent-From: Nicolas Graves Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 16 Oct 2024 17:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73692 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Z572 , 73692@debbugs.gnu.org Received: via spool by 73692-submit@debbugs.gnu.org id=B73692.172909918913447 (code B ref 73692); Wed, 16 Oct 2024 17:20:02 +0000 Received: (at 73692) by debbugs.gnu.org; 16 Oct 2024 17:19:49 +0000 Received: from localhost ([127.0.0.1]:60344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t17ga-0003Um-Rz for submit@debbugs.gnu.org; Wed, 16 Oct 2024 13:19:49 -0400 Received: from 3.mo583.mail-out.ovh.net ([46.105.40.108]:42069) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t17gX-0003UZ-1h for 73692@debbugs.gnu.org; Wed, 16 Oct 2024 13:19:47 -0400 Received: from director6.ghost.mail-out.ovh.net (unknown [10.109.148.49]) by mo583.mail-out.ovh.net (Postfix) with ESMTP id 4XTHkw1H17z1S66 for <73692@debbugs.gnu.org>; Wed, 16 Oct 2024 17:19:20 +0000 (UTC) Received: from ghost-submission-55b549bf7b-pstk7 (unknown [10.110.118.183]) by director6.ghost.mail-out.ovh.net (Postfix) with ESMTPS id D80A31FD97; Wed, 16 Oct 2024 17:19:19 +0000 (UTC) Received: from ngraves.fr ([37.59.142.109]) by ghost-submission-55b549bf7b-pstk7 with ESMTPSA id QaG/BZf1D2dk7gIArUSu5Q (envelope-from ); Wed, 16 Oct 2024 17:19:19 +0000 X-OVh-ClientIp: 90.110.172.34 In-Reply-To: <877ca844fz.fsf@iscas.ac.cn> References: <20241008062619.24136-1-ngraves@ngraves.fr> <20241016051210.9729-1-ngraves@ngraves.fr> <877ca844fz.fsf@iscas.ac.cn> Date: Wed, 16 Oct 2024 19:19:18 +0200 Message-ID: <87v7xsufs9.fsf@ngraves.fr> MIME-Version: 1.0 Content-Type: text/plain X-Ovh-Tracer-Id: 17696894739813425781 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeeftddrvdegledgudduvdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecunecujfgurhephffvufgjfhffkfggtgesthdtredttddttdenucfhrhhomheppfhitgholhgrshcuifhrrghvvghsuceonhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrqeenucggtffrrghtthgvrhhnpeeijefgffffudeivefgudeihfdtgfeljefhvdevhfegkeejvedthfdtfeeljeehgfenucfkphepuddvjedrtddrtddruddpledtrdduuddtrddujedvrdefgedpfeejrdehledrudegvddruddtleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepnhhgrhgrvhgvshesnhhgrhgrvhgvshdrfhhrpdhnsggprhgtphhtthhopedupdhrtghpthhtohepjeefieelvdesuggvsggsuhhgshdrghhnuhdrohhrghdpoffvtefjohhsthepmhhoheekfedpmhhouggvpehsmhhtphhouhht DKIM-Signature: a=rsa-sha256; bh=4PVIWQxnit+eigMIaJCwOMAqRYF2dY4lgCVwJyTf2Nw=; c=relaxed/relaxed; d=ngraves.fr; h=From; s=ovhmo4487190-selector1; t=1729099160; v=1; b=K+p4bhgVfWFDcJJcBlUAGMxRro/sM2voXD5u60If+uZSWW0vnK2IvsWqx2NF3lq1Iu3/1GNU CgHnnHZpks72dIz8L2wv9S9jfFLY2FLV9UnOKoeTSg+Ph8j4fMxmT8/VzARMgv181A4BmUidWgW SxXl7z1q1ptjG9SpWkTGvw8g5eFSz54EAF47p32sqMGlzfCLGAp/EPD8zfsfaKJkPgRBVCqT9ao jkVeGXORDCENleuNyWn0eXKkvISLn5vjO6+Eu6dtnznuy1rwC1uHGc3sHMsYrtF6/T/p0TZRmmM EGa+stUVUcvMGBS8AqwExbLTgU1+Dx2GHXjLEapTcYTFw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Nicolas Graves X-ACL-Warn: , Nicolas Graves via Guix-patches From: Nicolas Graves via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: -0.02 X-Spam-Score: -0.02 X-Migadu-Queue-Id: E044278B2A X-TUID: op8lBwyBgFUE On 2024-10-16 20:28, Z572 wrote: > Nicolas Graves via Guix-patches via writes: > >> * gnu/packages/databases.scm (timescaledb): >> [arguments]<#:phases>: Add phase 'patch-failing-tests. >> --- >> gnu/packages/databases.scm | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm >> index 43ec0641a0..80163cfdc0 100644 >> --- a/gnu/packages/databases.scm >> +++ b/gnu/packages/databases.scm >> @@ -1502,6 +1502,21 @@ (define-public timescaledb >> "-o" (string-append "-k " pg-data) >> "-l" (string-append pg-data "/db.log") >> "start")))) >> + #$@(if (not (target-x86-64?)) >> + #~((add-after 'unpack 'patch-failing-tests >> + (lambda _ >> + (substitute* "test/CMakeLists.txt" >> + (((format >> + #f "(~{~a|~})" > > I think it's best to keep it simple and not use overly complex > features. I agree but this bit is indeed particularly tricky. I can move from complex format to string-append + string-join, from cons* to append list, and drop the not, but ultimately I feel selectively ignoring tests by system is complex in itself. Let's see what QA says, then simplify that, but if you have a better solution, don't hesitate to put it forward ;) > >> + (cons* >> + "histogram_test\\.sql\\.in" >> + #$@(if (target-aarch64?) >> + #~((list "append\\.sql\\.in" >> + "chunk_adaptative\\.sql")) >> + #~((list))))) >> + all) >> + (string-append "#" all)))))) >> + #~()) >> (add-after 'prepare-tests 'check >> (assoc-ref %standard-phases 'check))))) >> (inputs (list openssl postgresql)) -- Best regards, Nicolas Graves