From: Nicolas Graves via Guix-patches via <guix-patches@gnu.org>
To: Z572 <zhengjunjie@iscas.ac.cn>, 73692@debbugs.gnu.org
Subject: [bug#73692] [PATCH v2] gnu: timescaledb: Ignore failing tests.
Date: Wed, 16 Oct 2024 19:19:18 +0200 [thread overview]
Message-ID: <87v7xsufs9.fsf@ngraves.fr> (raw)
In-Reply-To: <877ca844fz.fsf@iscas.ac.cn>
On 2024-10-16 20:28, Z572 wrote:
> Nicolas Graves via Guix-patches via <guix-patches@gnu.org> writes:
>
>> * gnu/packages/databases.scm (timescaledb):
>> [arguments]<#:phases>: Add phase 'patch-failing-tests.
>> ---
>> gnu/packages/databases.scm | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
>> index 43ec0641a0..80163cfdc0 100644
>> --- a/gnu/packages/databases.scm
>> +++ b/gnu/packages/databases.scm
>> @@ -1502,6 +1502,21 @@ (define-public timescaledb
>> "-o" (string-append "-k " pg-data)
>> "-l" (string-append pg-data "/db.log")
>> "start"))))
>> + #$@(if (not (target-x86-64?))
>> + #~((add-after 'unpack 'patch-failing-tests
>> + (lambda _
>> + (substitute* "test/CMakeLists.txt"
>> + (((format
>> + #f "(~{~a|~})"
>
> I think it's best to keep it simple and not use overly complex
> features.
I agree but this bit is indeed particularly tricky. I can move from
complex format to string-append + string-join, from cons* to append
list, and drop the not, but ultimately I feel selectively ignoring tests
by system is complex in itself. Let's see what QA says, then simplify
that, but if you have a better solution, don't hesitate to put it
forward ;)
>
>> + (cons*
>> + "histogram_test\\.sql\\.in"
>> + #$@(if (target-aarch64?)
>> + #~((list "append\\.sql\\.in"
>> + "chunk_adaptative\\.sql"))
>> + #~((list)))))
>> + all)
>> + (string-append "#" all))))))
>> + #~())
>> (add-after 'prepare-tests 'check
>> (assoc-ref %standard-phases 'check)))))
>> (inputs (list openssl postgresql))
--
Best regards,
Nicolas Graves
next prev parent reply other threads:[~2024-10-16 17:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 6:26 [bug#73692] [PATCH] gnu: timescaledb: Update to 2.16.1. [security fixes] Nicolas Graves via Guix-patches via
2024-10-16 5:12 ` [bug#73692] [PATCH v2] gnu: timescaledb: Ignore failing tests Nicolas Graves via Guix-patches via
2024-10-16 12:28 ` Z572
2024-10-16 17:19 ` Nicolas Graves via Guix-patches via [this message]
2024-10-16 23:24 ` [bug#73692] [PATCH v3 1/2] gnu: timescaledb: Update to 2.16.1. [security fixes] Nicolas Graves via Guix-patches via
2024-10-16 23:24 ` [bug#73692] [PATCH v3 2/2] gnu: timescaledb: Ignore failing tests Nicolas Graves via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v7xsufs9.fsf@ngraves.fr \
--to=guix-patches@gnu.org \
--cc=73692@debbugs.gnu.org \
--cc=ngraves@ngraves.fr \
--cc=zhengjunjie@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).