From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45894)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d6NIE-0004hw-L9
	for guix-patches@gnu.org; Thu, 04 May 2017 16:24:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d6NIA-0001tS-Kh
	for guix-patches@gnu.org; Thu, 04 May 2017 16:24:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:56702)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1d6NIA-0001tM-Gp
	for guix-patches@gnu.org; Thu, 04 May 2017 16:24:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d6NIA-0004UL-8j
	for guix-patches@gnu.org; Thu, 04 May 2017 16:24:02 -0400
Subject: bug#26645: [PATCH 4/9] guix: Add "potluck" command.
Resent-Message-ID: <handler.26645.B26645.149392943217233@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170424205923.27726-1-wingo@igalia.com>
	<20170424205923.27726-4-wingo@igalia.com>
Date: Thu, 04 May 2017 22:23:34 +0200
In-Reply-To: <20170424205923.27726-4-wingo@igalia.com> (Andy Wingo's message
	of "Mon, 24 Apr 2017 22:59:18 +0200")
Message-ID: <87tw509xrt.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Andy Wingo <wingo@igalia.com>
Cc: 26645@debbugs.gnu.org

Hello!

Andy Wingo <wingo@igalia.com> skribis:

> * guix/scripts/potluck.scm: New file.
> * Makefile.am: Add new file.

[...]

> +      (call-with-output-file (in-vicinity potluck-dir "README.md")
> +        (lambda (port)
> +          (format port
> +                  "\

Please add (G_ =E2=80=A6) for i18n, and also add the file to po/guix/POTFIL=
ES.in.

> +This directory defines potluck packages.  Each file in this directory sh=
ould
> +define one package.  See https://potluck.guixsd.org/ for more informatio=
n.

I=E2=80=99ll email guix-sysadmin so potluck.guixsd.org points to the same I=
P as
guix-potluck.org.  :-)

> +    (let* ((opts     (parse-command-line args %options
> +                                         (list %default-options)
> +                                         #:argument-handler
> +                                         parse-sub-command))

=E2=80=98parse-command-line=E2=80=99 honors $GUIX_BUILD_OPTIONS, which is u=
nnecessary
here.  Instead, we should use =E2=80=98args-fold*=E2=80=99 like in (guix sc=
ripts hash),
for instance.

Otherwise LGTM, thanks!

Ludo=E2=80=99.