From: "Clément Lassieur" <clement@lassieur.org>
To: Christopher Allan Webber <cwebber@dustycloud.org>
Cc: 26716-done@debbugs.gnu.org
Subject: bug#26716: Test nginx configuration
Date: Thu, 11 May 2017 17:53:46 +0200 [thread overview]
Message-ID: <87tw4rs839.fsf@lassieur.org> (raw)
In-Reply-To: <87lgqhd5zd.fsf@dustycloud.org>
Christopher Allan Webber <cwebber@dustycloud.org> writes:
> Julien Lepiller writes:
>
>>> So is the goal here that it will raise an exception if it doesn't
>>> exist, like so?
>>>
>>> ERROR: In procedure lstat: No such file or directory:
>>> "/tmp/no-such-file"
>>>
>>> That does seem like useful information to spit out.
>>>
>>> Maybe add a comment before the lstat explaining the call? If I didn't
>>> know that's why lstat was being used here I would have been confused.
>> exactly, I added a comment.
>
> Great!
>
>>> Oh, that's interesting. So in my experience earlier, it was proably
>>> *trying* to log some information, and failing I guess.
>>>
>>> It would be even nicer if they wrote to the same file by default, but
>>> I guess this probably isn't easy to do without actually patching nginx
>>> itself, which isn't likely worth it... is that right?
>> I tried using the -g option to give it some configuration options
>> (including error_log), but it doesn't seem to change that behaviour, so
>> I think we'll have to fix nginx to use the same configuration file.
>>
>> Of course it would be better to fail at reconfigure when the generated
>> configuration is not correct. That's what I'm trying to do with the
>> first patch, but that's only one possible mistake.
>
> Cool... yes I agree it's only one possible mistake. :)
>
> Looks good. I assume you've tried testing building with it? Assuming
> all builds and things also error out right now in the new and expected
> ways when the configuration needs updating, I say push it!
Closing it as it has been pushed. Thanks!
prev parent reply other threads:[~2017-05-11 15:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-30 10:04 bug#26716: Test nginx configuration Julien Lepiller
2017-04-30 15:29 ` Christopher Allan Webber
2017-04-30 17:35 ` Julien Lepiller
2017-04-30 19:56 ` Christopher Allan Webber
2017-05-11 15:53 ` Clément Lassieur [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tw4rs839.fsf@lassieur.org \
--to=clement@lassieur.org \
--cc=26716-done@debbugs.gnu.org \
--cc=cwebber@dustycloud.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).