From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33717) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d9JdN-000872-NT for guix-patches@gnu.org; Fri, 12 May 2017 19:06:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d9JdK-0004cl-Gk for guix-patches@gnu.org; Fri, 12 May 2017 19:06:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:38785) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d9JdK-0004cW-7c for guix-patches@gnu.org; Fri, 12 May 2017 19:06:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d9JdJ-0006Jq-Vn for guix-patches@gnu.org; Fri, 12 May 2017 19:06:01 -0400 Subject: bug#26840: [PATCH 2/3] gnu: go-1.4: Add missing module imports. Resent-Message-ID: From: Kei Kebreau References: <20170508195549.23372-1-slyfox@inbox.ru> <20170508195549.23372-3-slyfox@inbox.ru> <87poffi2tn.fsf@openmailbox.org> <87wp9l68vx.fsf@gnu.org> Date: Fri, 12 May 2017 19:05:22 -0400 In-Reply-To: <87wp9l68vx.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Fri, 12 May 2017 23:52:02 +0200") Message-ID: <87tw4phe19.fsf@openmailbox.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 26840@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Hi Kei, > > Kei Kebreau skribis: > >> Sergei Trofimovich writes: >> >>> * gnu/packages/golang.scm (go-1.4): Add missing modules to >>> %modify-phases call: srfi-1 >>> --- >>> gnu/packages/golang.scm | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm >>> index 00630ce06..d19aa65af 100644 >>> --- a/gnu/packages/golang.scm >>> +++ b/gnu/packages/golang.scm >>> @@ -62,7 +62,8 @@ >>> (arguments >>> `(#:modules ((ice-9 match) >>> (guix build gnu-build-system) >>> - (guix build utils)) >>> + (guix build utils) >>> + (srfi srfi-1)) >>> #:tests? #f ; Tests are run by the all.bash script. >>> #:phases >>> (modify-phases %standard-phases >> >> */me looks at git log and facepalms* >> >> Never mind my other email... I see that the reason these are already on >> master is because they were already pushed there. Feel free to close >> these! > > Though as discussed in another thread with Sergei, it=E2=80=99s not entir= ely > clear to me that these #:modules patches should be committed (and they > are for =E2=80=98core-updates=E2=80=99, not =E2=80=98master=E2=80=99.) > > I would rather see whether we can find a more generic solution to this > problem before patching every single instance. > > How does that sound? > > Ludo=E2=80=99. I have no objections. Should the patches already on master be reverted, or should they be left until further notice? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAlkWP7MACgkQ5qXuPBlG eg1AWQ//UKHSaNiaJP5aITgyRDXvKtANjyFlojPNbx0msiOblYnbz5d0Dc+fytHW oHJbo4ZJqSLvNn3oRPb4ZWoFvRTVj7v4zRzYQkkMOjWbg0S2pgusFM5jPVy+Mar8 NPWst1VOIbCxRpYqrbVj7HXW359Kci2w1kMj6dF/BuCxKEddDugbn+7C6Is3xjcQ cRp9qnRNHdbtVX6/+WoW11l2MfpeMfuJ70sP5LkPCT814AwDlyfMIeoArbU89Bsk 0SEYvjYQht/sExoXfpKxCQebaqfdAdYdMER1xJKLdXBqo1QrOQkavJqZNz6YJgRB nOW4D/D1EFZyabfaqOGdViVdhy+vOgIU+RNbcSMj4p4vHkX3IHf1KyL4u6aW4Vfi gQatPrlMvRS4kpX6OfmKVH4z4EWCIVb6QL65L2cGm+CyAxe858HmtrLlwfvW4cCR l8pUoxncBLj69Q3Qh73AWichwJWp77FoUpwW0CpoJpzVs8nqZ+tk1KMSxyd1t55i RMF5v+gx0i7tJn3GGSbJqCDoTlNSCthf60Zdur6UbUKx7CsurQykCeUsJPkijI3g a8ZK/SQHPssIu2Eegw6KH1bqW/JpPDkn/wf48L7rp2/EGStRU3ZeIc+7iPF8Fpnb 7z4qFp9kKALE+xUObeXKiIGAahSd+h97/9jBFixqG4ENbpItbyY= =QSo8 -----END PGP SIGNATURE----- --=-=-=--