From: Kei Kebreau <kei@openmailbox.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 26840@debbugs.gnu.org
Subject: bug#26840: [PATCH 2/3] gnu: go-1.4: Add missing module imports.
Date: Fri, 12 May 2017 19:05:22 -0400 [thread overview]
Message-ID: <87tw4phe19.fsf@openmailbox.org> (raw)
In-Reply-To: <87wp9l68vx.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Fri, 12 May 2017 23:52:02 +0200")
[-- Attachment #1: Type: text/plain, Size: 1634 bytes --]
ludo@gnu.org (Ludovic Courtès) writes:
> Hi Kei,
>
> Kei Kebreau <kei@openmailbox.org> skribis:
>
>> Sergei Trofimovich <slyfox@inbox.ru> writes:
>>
>>> * gnu/packages/golang.scm (go-1.4): Add missing modules to
>>> %modify-phases call: srfi-1
>>> ---
>>> gnu/packages/golang.scm | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
>>> index 00630ce06..d19aa65af 100644
>>> --- a/gnu/packages/golang.scm
>>> +++ b/gnu/packages/golang.scm
>>> @@ -62,7 +62,8 @@
>>> (arguments
>>> `(#:modules ((ice-9 match)
>>> (guix build gnu-build-system)
>>> - (guix build utils))
>>> + (guix build utils)
>>> + (srfi srfi-1))
>>> #:tests? #f ; Tests are run by the all.bash script.
>>> #:phases
>>> (modify-phases %standard-phases
>>
>> */me looks at git log and facepalms*
>>
>> Never mind my other email... I see that the reason these are already on
>> master is because they were already pushed there. Feel free to close
>> these!
>
> Though as discussed in another thread with Sergei, it’s not entirely
> clear to me that these #:modules patches should be committed (and they
> are for ‘core-updates’, not ‘master’.)
>
> I would rather see whether we can find a more generic solution to this
> problem before patching every single instance.
>
> How does that sound?
>
> Ludo’.
I have no objections. Should the patches already on master be reverted,
or should they be left until further notice?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2017-05-12 23:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-08 19:55 bug#26841: [PATCH 0/3] core-updates: more fixes for missing dependencies for %modify-phases Sergei Trofimovich
2017-05-08 19:55 ` bug#26842: [PATCH 1/3] gnu: zip: add missing '#:modules' imports Sergei Trofimovich
2017-05-11 19:53 ` Kei Kebreau
2017-05-08 19:55 ` bug#26840: [PATCH 2/3] gnu: go-1.4: Add missing module imports Sergei Trofimovich
2017-05-11 19:57 ` Kei Kebreau
2017-05-11 21:06 ` Danny Milosavljevic
2017-05-11 21:25 ` Kei Kebreau
2017-05-11 21:28 ` Leo Famulari
2017-05-11 22:19 ` Marius Bakke
2017-05-11 22:29 ` Danny Milosavljevic
2017-05-12 4:26 ` Leo Famulari
2017-05-12 21:52 ` Ludovic Courtès
2017-05-12 23:05 ` Kei Kebreau [this message]
2017-05-13 13:08 ` Ludovic Courtès
2017-05-08 19:55 ` bug#26843: [PATCH 3/3] gnu: sbcl: " Sergei Trofimovich
2017-05-09 15:53 ` bug#26841: [PATCH 0/3] core-updates: more fixes for missing dependencies for %modify-phases Danny Milosavljevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tw4phe19.fsf@openmailbox.org \
--to=kei@openmailbox.org \
--cc=26840@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).