From: Kei Kebreau <kei@openmailbox.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 27421@debbugs.gnu.org
Subject: [bug#27421] [PATCH 5/5] gnu: openttd-engine: Add 'install-data' phase.
Date: Sun, 18 Jun 2017 17:03:47 -0400 [thread overview]
Message-ID: <87tw3datzg.fsf@openmailbox.org> (raw)
In-Reply-To: <87d1a1f8n6.fsf@fastmail.com> (Marius Bakke's message of "Sun, 18 Jun 2017 20:33:33 +0200")
[-- Attachment #1.1: Type: text/plain, Size: 571 bytes --]
Marius Bakke <mbakke@fastmail.com> writes:
> Kei Kebreau <kei@openmailbox.org> writes:
>
>> * gnu/packages/games.scm (openttd-engine): Rename package to openttd.
>> [arguments]: Add it.
>> [native-inputs]: Add openttd-opengfx.
>
> This should also mention that the (openttd) variable is now gone.
> However, I would prefer keeping "openttd-engine" and only add these
> changes to the inherited "openttd" package. What do you think?
That would be a more logical progression given the comment about adding
openttd-opengfx. I've attached the change you're talking about.
[-- Attachment #1.2: 0001-gnu-openttd-Add-install-data-phase.patch --]
[-- Type: text/plain, Size: 1584 bytes --]
From d02c7d59d268199a04c2e57da0c9d2646052f980 Mon Sep 17 00:00:00 2001
From: Kei Kebreau <kei@openmailbox.org>
Date: Sun, 18 Jun 2017 13:45:19 -0400
Subject: [PATCH] gnu: openttd: Add 'install-data' phase.
* gnu/packages/games.scm (openttd)[arguments]: Add it.
[native-inputs]: Add openttd-opengfx.
---
gnu/packages/games.scm | 20 +++++++++++++++++++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index df680d11d..b8ca8dc15 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -2360,7 +2360,25 @@ OpenGFX provides you with...
(define-public openttd
(package
(inherit openttd-engine)
- (name "openttd")))
+ (name "openttd")
+ (arguments
+ (substitute-keyword-arguments (package-arguments openttd-engine)
+ ((#:phases phases)
+ `(modify-phases ,phases
+ (add-after 'install 'install-data
+ (lambda* (#:key inputs outputs #:allow-other-keys)
+ (let*
+ ((opengfx (assoc-ref inputs "opengfx"))
+ (out (assoc-ref outputs "out"))
+ (gfx-dir
+ (string-append out
+ "/share/games/openttd/baseset/opengfx")))
+ (mkdir-p gfx-dir)
+ (copy-recursively opengfx gfx-dir))
+ #t))))))
+ (native-inputs
+ `(("opengfx" ,openttd-opengfx)
+ ,@(package-native-inputs openttd-engine)))))
(define-public pinball
(package
--
2.13.1
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2017-06-18 21:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-18 17:37 [bug#27421] OpenTTD OpenGFX patches Kei Kebreau
2017-06-18 17:44 ` [bug#27421] [PATCH 1/5] gnu: Add nml Kei Kebreau
2017-06-18 18:01 ` Marius Bakke
2017-06-18 19:01 ` Kei Kebreau
2017-06-18 17:45 ` [bug#27421] [PATCH 2/5] gnu: Add dos2unix Kei Kebreau
2017-06-18 17:45 ` [bug#27421] [PATCH 3/5] gnu: Add grfcodec Kei Kebreau
2017-06-18 18:04 ` Marius Bakke
2017-06-18 17:45 ` [bug#27421] [PATCH 4/5] gnu: Add openttd-opengfx Kei Kebreau
2017-06-18 18:24 ` Marius Bakke
2017-06-18 18:51 ` Kei Kebreau
2017-06-18 17:45 ` [bug#27421] [PATCH 5/5] gnu: openttd-engine: Add 'install-data' phase Kei Kebreau
2017-06-18 18:33 ` Marius Bakke
2017-06-18 21:03 ` Kei Kebreau [this message]
2017-06-20 19:28 ` Marius Bakke
2017-06-20 23:51 ` bug#27421: " Kei Kebreau
2017-06-18 18:02 ` [bug#27421] [PATCH 2/5] gnu: Add dos2unix Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tw3datzg.fsf@openmailbox.org \
--to=kei@openmailbox.org \
--cc=27421@debbugs.gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).