From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dNPYK-0000Wk-Is for guix-patches@gnu.org; Tue, 20 Jun 2017 16:15:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dNPYE-0004iM-S6 for guix-patches@gnu.org; Tue, 20 Jun 2017 16:15:08 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:55801) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dNPYE-0004iB-P1 for guix-patches@gnu.org; Tue, 20 Jun 2017 16:15:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dNPYE-0001VO-Hd for guix-patches@gnu.org; Tue, 20 Jun 2017 16:15:02 -0400 Subject: [bug#26339] [PATCH] tests: Add syslinux gpt test. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20170402134916.2871-1-m.othacehe@gmail.com> <20170518102618.24842-1-m.othacehe@gmail.com> <87mv9d3q62.fsf@gnu.org> <87lgonkjdj.fsf@gmail.com> Date: Tue, 20 Jun 2017 22:13:49 +0200 In-Reply-To: <87lgonkjdj.fsf@gmail.com> (Mathieu Othacehe's message of "Mon, 19 Jun 2017 18:55:04 +0200") Message-ID: <87tw3al8n6.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Mathieu Othacehe Cc: 26339@debbugs.gnu.org Hello! Mathieu Othacehe skribis: >> I don=E2=80=99t think we should provide =E2=80=98syslinux=E2=80=99 in th= e installation image. >> The image is already fat enough. > > Yep you're right, I added it without really understanding why it has > necessary for the test to succeed. > > Now I understand why, it's because the image has no network access, so > every package that will be needed further has to be specified. I add a > packages list to "run-install" to solve this issue. Sounds good. > From 7cf07ec0e909d99030e2646db9fdfef09d655316 Mon Sep 17 00:00:00 2001 > From: Mathieu Othacehe > Date: Thu, 18 May 2017 12:19:53 +0200 > Subject: [PATCH] tests: Add extlinux gpt test. > > * gnu/tests/install.scm (%test-installed-extlinux-os): New exported > variable. > (%minimal-extlinux-os, %minimal-extlinux-os-source): New variables. > (%extlinux-gpt-installation-script): New variable. ^^ Extra space. :-) Please also mention the =E2=80=98run-install=E2=80=99 change. Otherwise LGTM, thanks for taking the time to write this test! Ludo=E2=80=99.