Pierre Neidhardt <ambrevar@gmail.com> writes:

> * gnu/package/disk.scm (libblockdev): New variable.

[...]

> +(define-public libblockdev
> +  (package
> +    (name "libblockdev")
> +    (version "2.18")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://github.com/storaged-project/libblockdev/archive/"
> +                                  version "-1.tar.gz"))
> +              (file-name (string-append name "-" version))
> +              (sha256
> +               (base32
> +                "1q8wh27yngrjvydm9bainda5fgifq8hbgzdsjipkn3nrrhbfy8p9"))))

Please use the uploaded release tarball instead of the autogenerated git
archive:

https://github.com/storaged-project/libblockdev/releases/download/2.18-1/libblockdev-2.18.tar.gz

Then you can remove (file-name ...) since it's already fine.

> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("autoconf" ,autoconf)
> +       ("automake" ,automake)
> +       ("libtool" ,libtool)

...and probably also these inputs.

Other than that LGTM, provided `guix lint` is happy!

> +       ("pkg-config" ,pkg-config)
> +       ("python" ,python-wrapper)
> +       ("util-linux" ,util-linux)))
> +    (inputs
> +     `(("btrfs-progs" ,btrfs-progs)
> +       ("cryptsetup" ,cryptsetup)
> +       ("dosfstools" ,dosfstools)
> +       ("dmraid" ,dmraid)
> +       ("eudev" ,eudev)
> +       ("glib" ,glib)
> +       ("gobject-introspection" ,gobject-introspection)
> +       ("kmod" ,kmod)
> +       ("libbytesize" ,libbytesize)
> +       ("libyaml" ,libyaml)
> +       ("lvm2" ,lvm2)
> +       ("mdadm" ,mdadm)
> +       ("ndctl" ,ndctl)
> +       ("nss" ,nss)
> +       ("parted" ,parted)
> +       ("volume-key" ,volume-key)
> +       ;; ("xfsprogs" ,xfsprogs) ; TODO: Package?
> +       ))
> +    (home-page "https://github.com/storaged-project/libblockdev")
> +    (synopsis "Library for manipulating block devices")
> +    (description
> +     "libblockdev is a C library supporting GObject introspection for
> +manipulation of block devices.  It has a plugin-based architecture where each
> +technology (like LVM, Btrfs, MD RAID, Swap...) is implemented in a separate
> +plugin, possibly with multiple implementations (e.g. using LVM CLI or the new
> +LVM D-Bus API).")
> +    ;; XXX: Copying says LGPL2.1, but the source files with license
> +    ;; information are GPL2+.
> +    (license license:gpl2+)))
> -- 
> 2.18.0