From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:55725) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gtS5v-0002Hz-Cp for guix-patches@gnu.org; Tue, 12 Feb 2019 02:03:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gtS5u-00035j-BH for guix-patches@gnu.org; Tue, 12 Feb 2019 02:03:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:45070) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gtS5u-00035O-3J for guix-patches@gnu.org; Tue, 12 Feb 2019 02:03:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gtS5t-0006Nf-Ud for guix-patches@gnu.org; Tue, 12 Feb 2019 02:03:01 -0500 Subject: [bug#34398] [PATCH] gnu: Add python-backports-shutil-which. Resent-Message-ID: From: Vagrant Cascadian In-Reply-To: <875ztq3rnr.fsf@ponder> References: <87k1i9v5ka.fsf@ponder> <20190211105421.3b77ef6b@scratchpost.org> <875ztq3rnr.fsf@ponder> Date: Mon, 11 Feb 2019 23:02:04 -0800 Message-ID: <87tvh9a3rn.fsf@ponder> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Danny Milosavljevic Cc: 34398@debbugs.gnu.org --=-=-= Content-Type: text/plain On 2019-02-11, Vagrant Cascadian wrote: > On 2019-02-11, Danny Milosavljevic wrote: >> On Fri, 08 Feb 2019 22:28:37 -0800 >> Vagrant Cascadian wrote: >>> + (synopsis >>> + "Backport of shutil.which from Python 3.3") >>> + (description >>> + "Python-backports-shutil-which provides a backport of shutil.which from >>> +Python 3.3") >> >> Why do we need this package? We have Python 3.7.0. >> Doesn't that contain the same module already? > > I found it odd as well, but I couldn't figure out how to get the newer > versions of python-trezor-agent to build without > python-backports-shutil-which without patching python-trezor-agent. > > I didn't spend too much effort looking into patching it; I'll take a > little deeper look. I don't see a need for this package anymore; I submitted an update for python-trezor-agent/trezor-agent that fixes the issue without using backports.shutil_which. A slightly deeper look into: Lacking backports.shutil_which caused "trezor-agent" to fail during tests as it tried to download the missing library, but there was no mention of shutil_which at all in any of it's code... turned out "python-trezor-agent" had an overly strict requires on the backported.shutil_which, even though "python-trezor-agent" supports the shutil_which included in newer python versions. Simply removing the backports.shutil_which from "python-trezor-agent" requires fixed the issue. Thanks! live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCXGJvbQAKCRDcUY/If5cW qm3wAPwMuO4nwcCzitgl4m4eBGQs8Iql3ZVdVSXhPiG/q+CUewD+IB3Fv1NUosQS yE0XR8PAbcTR9Pol0tDeqGrMJ7KICQs= =MpNM -----END PGP SIGNATURE----- --=-=-=--