From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:52669) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJV5I-0002Ox-30 for guix-patches@gnu.org; Wed, 24 Apr 2019 23:30:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJV5G-0007LO-G7 for guix-patches@gnu.org; Wed, 24 Apr 2019 23:30:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43539) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hJV5G-0007Jx-BC for guix-patches@gnu.org; Wed, 24 Apr 2019 23:30:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hJV5G-0003WF-0S for guix-patches@gnu.org; Wed, 24 Apr 2019 23:30:02 -0400 Subject: [bug#35423] [PATCH] gnu: Add julius. Resent-Message-ID: From: Tobias Geerinckx-Rice References: <3d5daf0540406554d3082f94fdc6079c@disroot.org> In-reply-to: <3d5daf0540406554d3082f94fdc6079c@disroot.org> Date: Thu, 25 Apr 2019 05:29:19 +0200 Message-ID: <87tvem225s.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 35423@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable nly, Thanks for the patch! Unfortunately, the indentation's buggered.=20 How did you create/send it? nly@disroot.org wrote: > Julius is a speech recognition tool. Package uses a custom=20 > license. > > From e01acf44822c57cf2af4678007ddd6a70b61ce1e Mon Sep 17=20 > 00:00:00 2001 > From: Amar Singh > Date: Sun, 21 Apr 2019 19:37:37 +0530 > Subject: [PATCH] gnu: Add julius. > > * gnu/packages/speech.scm (julius): New variable. > --- > gnu/packages/speech.scm | 39=20 > +++++++++++++++++++++++++++++++++++++++ > 1 file changed, 39 insertions(+) > > diff --git a/gnu/packages/speech.scm b/gnu/packages/speech.scm > index 2d6c63e3f9..a99be8a0aa 100644 > --- a/gnu/packages/speech.scm > +++ b/gnu/packages/speech.scm > @@ -33,9 +33,11 @@ > #:use-module (gnu packages gcc) > #:use-module (gnu packages glib) > #:use-module (gnu packages linux) > + #:use-module (gnu packages perl) > #:use-module (gnu packages pkg-config) > #:use-module (gnu packages pulseaudio) > #:use-module (gnu packages python) > + #:use-module (gnu packages sdl) > #:use-module (gnu packages textutils)) > (define-public espeak > @@ -119,6 +121,43 @@ It is based on the eSpeak engine and=20 > supports spectral and Klatt formant > synthesis, and the ability to use MBROLA voices.") > (license license:gpl3+))) > +(define-public julius > + (package > + (name "julius") > + (version "8c60cb8c") Package versions must be monotonically increasing over time so=20 Guix (and users) can determine which is newer. Git commits=20 aren't. We also prefer to package upstream releases whenever possible, and=20 I see there's a 4.5 release on GitHub. Would that do? If not, can you use GIT-VERSION (with "4.5" as the first argument)=20 instead? Examples abound in (gnu packages). > + (source > + (origin > + (method git-fetch) > + (uri > + (git-reference > + (url "https://github.com/julius-speech/julius") > + (commit version))) > + (file-name > + (git-file-name name version)) This can remain unchanged even if you'd switch to GIT-VERSION. > + (sha256 > + (base32 > + "11qbp9kid251lx6li4fv1r6l0pixxcs1m00sax1z057bhcv4jc7a")))) > + (build-system gnu-build-system) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (delete 'check)))) > + (inputs > + `(("alsa-lib" ,alsa-lib) > + ("zlib" ,zlib) > + ("sdl2" ,sdl2) > + ("perl" ,perl))) Nitpick: might as wel sort these before they go in. > + (home-page "https://github.com/julius-speech/") According to the README, the =E2=80=98official=E2=80=99 home page is just https://github.com/julius-speech/julius > + (synopsis "Open-Source Large Vocabulary Continuous Speech > +Recognition Engine") Everything in Guix is =E2=80=98Open Source=E2=80=99 (not a term we should b= e=20 promoting anyway :-) so we don't mention it in synopses or=20 descriptions. I don't think the capitalisation is helpful (even if =E2=80=98LVCSR=E2=80= =99 were=20 a common initialism, =E2=80=98Engine=E2=80=99 wouldn't be capitalised). > + (description > + "Julius is a high-performance, small-footprint large=20 > vocabulary continuous > + speech recognition (LVCSR) decoder software for speech-related=20 > researchers and > +developers.") Here you can use @acronym{LVCSR, large vocabulary continuous=20 speech recognition} if you like. This description is awfully short. Since you're familiar with the=20 software, would you mind expanding it? You can re-use the most=20 relevant parts of the README or other documentation. > + (license > + (license:non-copyleft "http://julius.osdn.jp/LICENSE.txt" > + "Julius-Modified-BSD-4Clause")))) Hmm. I'm not sure if clauses 3 and 5 could be problematic. Has=20 this licence been previously discussed elsewhere in the FSDG=20 world? Thanks! T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQT12iAyS4c9C3o4dnINsP+IT1VteQUCXMEpjwAKCRANsP+IT1Vt eSOeAP0QyqgtKVPa5N7BYncAQXF8z20gDFZ4M8WDWXZJc4Ch0wD/ZMfolLLYqox0 slm/f6cKrjpND0rEMgodNHEsMauGMwk= =A9q1 -----END PGP SIGNATURE----- --=-=-=--