unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Tobias Geerinckx-Rice <me@tobias.gr>
To: 36141@debbugs.gnu.org
Subject: [bug#36141] [PATCH] installer: Unblock relevant rfkill switches.
Date: Sat, 08 Jun 2019 20:14:40 +0200	[thread overview]
Message-ID: <87tvd054hb.fsf@nckx> (raw)
In-Reply-To: <20190608175505.11162-1-me@tobias.gr>

[-- Attachment #1: Type: text/plain, Size: 835 bytes --]

Oh…

Tobias Geerinckx-Rice wrote:
> +         (connman-rfkill-types `(("bluetooth" . "bluetooth")
> +                                 ("wifi" . "wlan")))
> +         (rfkill-type (assoc-ref connman-rfkill-types type)))

Turns out that util-linux allows ‘wifi’ as a special alias for 
‘wlan’:

  // only result for ‘grep -riw wifi’:
  static const struct rfkill_type_str rfkill_type_strings[] = {
    { .type = RFKILL_TYPE_ALL,       .name = "all"  },
    { .type = RFKILL_TYPE_WLAN,      .name = "wlan",
      .desc = "Wireless LAN" },
    { .type = RFKILL_TYPE_WLAN,      .name = "wifi" }, /* alias */

…so we could drop connman-rfkill-types completely and rely on that 
(undocumented!) quirk.

Of course I don't believe we should, but now you know as much as I 
do :-)

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

  reply	other threads:[~2019-06-08 18:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-08 17:55 [bug#36141] [PATCH] installer: Unblock relevant rfkill switches Tobias Geerinckx-Rice
2019-06-08 18:14 ` Tobias Geerinckx-Rice [this message]
2019-06-09  0:20   ` Tobias Geerinckx-Rice
2021-08-03 19:34     ` bug#36141: " Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tvd054hb.fsf@nckx \
    --to=me@tobias.gr \
    --cc=36141@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).