From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:43578)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hdhPA-0007Lp-NY
 for guix-patches@gnu.org; Wed, 19 Jun 2019 16:42:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hdhP8-00031i-N6
 for guix-patches@gnu.org; Wed, 19 Jun 2019 16:42:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:33945)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hdhP7-0002zU-SU
 for guix-patches@gnu.org; Wed, 19 Jun 2019 16:42:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hdhP7-0001bH-M8
 for guix-patches@gnu.org; Wed, 19 Jun 2019 16:42:01 -0400
Subject: [bug#36239] [PATCH] opensmtpd-service-type to extend pam
Resent-Message-ID: <handler.36239.B36239.15609768626068@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <87sgsaxn6t.fsf@walletsworth.com>
Date: Wed, 19 Jun 2019 22:40:45 +0200
In-Reply-To: <87sgsaxn6t.fsf@walletsworth.com> (Kristofer Buffington's message
 of "Sat, 15 Jun 2019 22:45:46 -0400")
Message-ID: <87tvcl1f76.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Kristofer Buffington <kristofer@walletsworth.com>
Cc: 36239@debbugs.gnu.org

Hi Kristofer,

Kristofer Buffington <kristofer@walletsworth.com> skribis:

> +(define %opensmtpd-pam-services
> +  (list (unix-pam-service "smtpd")))
> +
>  (define opensmtpd-service-type
>    (service-type
>     (name 'opensmtpd)
> @@ -1675,6 +1679,8 @@ accept from local for any relay
>                               (const %opensmtpd-accounts))
>            (service-extension activation-service-type
>                               opensmtpd-activation)
> +          (service-extension pam-root-service-type
> +                             (const %opensmtpd-pam-services))

Could you explain why the PAM service is needed and what went wrong
before that?

I haven=E2=80=99t use this service (yet) but I=E2=80=99m surprised it needs=
 a PAM hook.

Thanks for your patch,
Ludo=E2=80=99.