From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:52321) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlGVk-0003Ia-Jn for guix-patches@gnu.org; Wed, 10 Jul 2019 13:36:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hlGVi-00061q-8L for guix-patches@gnu.org; Wed, 10 Jul 2019 13:36:07 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55985) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hlGVe-0005t2-4C for guix-patches@gnu.org; Wed, 10 Jul 2019 13:36:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hlGVd-0001mT-TJ for guix-patches@gnu.org; Wed, 10 Jul 2019 13:36:01 -0400 Subject: [bug#36535] [PATCH] gnu: gobject-introspection: Update absolute-shlib-path.patch. Resent-Message-ID: From: Marius Bakke In-Reply-To: <87zhlopjzv.fsf@devup.no> References: <20190707104803.23662-1-mail@cbaines.net> <87d0il9deh.fsf@cbaines.net> <875zocr4hl.fsf@devup.no> <87bly4a566.fsf@cbaines.net> <87zhlopjzv.fsf@devup.no> Date: Wed, 10 Jul 2019 19:35:21 +0200 Message-ID: <87tvbtn67a.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Baines Cc: 36535@debbugs.gnu.org --=-=-= Content-Type: text/plain Marius Bakke writes: > Christopher Baines writes: > >> Marius Bakke writes: >> >>> Hi Chris, >>> >>> Christopher Baines writes: >>> >>>> Christopher Baines writes: >>>> >>>>> Incorporate some changes from nixpkgs to the gobject-introspection package >>>>> patches. This is motivated by looking at issues with libsoup and lollypop. >>>>> This changes means that the share/gir-1.0/Soup-2.4.gir file within libsoup >>>>> references libsoup-2.4.so.1 with an absolute filename, whereas previously, the >>>>> filename wasn't absolute. >>>>> >>>>> * gnu/packages/patches/gobject-introspection-absolute-shlib-path.patch: >>>>> Incorporate changes from nixpkgs. >>>>> --- >>>>> ...ct-introspection-absolute-shlib-path.patch | 141 +++++++++++++++++- >>>>> 1 file changed, 137 insertions(+), 4 deletions(-) >>>>> >>>> >>>> I've pushed this as [1] to core-updates now, as I wanted to get it in >>>> before the freeze. >>> >>> Thank you for addressing this. IIUC previously lollypop failed to >>> retain a reference to libsoup-2.4.so.1, whereas with this patch it does? >> >> Not quite... I think lollypop was reading the typelib in libsoup, but >> the shared library was just referenced by filename, not the absolute >> filename, and I think this was causing issues when trying to use libsoup >> from lollypop. > > I see, thanks for explaining. In Guix, we usually resolve these > situations by native-search-paths, do you know if gobject-introspection > supports looking up the 'share/gir-1.0' directory from an environment > variable (similar to how GI_TYPELIB_PATH works today)? However... Errh, ignore this, I need to study the GObject stuff one of these days... Do you think you'll have time to update the patch within the coming days? The only important part is the NIX_STORE bits; the rest can be dealt with later. TIA! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl0mIdkACgkQoqBt8qM6 VPpGzQf/eOscS/CyNZCfeOiA2+4+hRCC3Bo4MEv6wbG/7pyrPdqagRUxQIL7pa57 7fJJl2P2yb9gohelnLe5BlJSleiqGBcfSCpHzOATIR8z92nc1JTIRPg6XkC4+Ib0 fwYQ2tkgMkRIWp5BJLMWkSR1d3OVgniCQ0A+RX/S3A8yZW2b3q1MpRXVy6i/gfLS T9vxP6IThfj5CL+NZ+jOkBxfiq80mYlWsmt2vH3P068ds3ZZ/pYyFNrII/JMLYNp 2cluEKRUCFr1HM22Pj3xFBQUHjfkSQvlXCwRCQg0vW9RTsRArPAjmIy7Ze6I+x+/ 2/dmMahu9fZc+72TozU65yYhX55+rQ== =mrFo -----END PGP SIGNATURE----- --=-=-=--