From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:49017) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmjAJ-0005jJ-Us for guix-patches@gnu.org; Sun, 14 Jul 2019 14:24:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hmjAJ-0008L2-1s for guix-patches@gnu.org; Sun, 14 Jul 2019 14:24:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37115) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hmjAI-0008Kw-VA for guix-patches@gnu.org; Sun, 14 Jul 2019 14:24:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hmjAI-0001AK-OG for guix-patches@gnu.org; Sun, 14 Jul 2019 14:24:02 -0400 Subject: [bug#35790] [PATCH 1/2] lint: Move the linting code to a different module. Resent-Message-ID: References: <87a7dyoryh.fsf@gnu.org> <20190702192542.16179-1-mail@cbaines.net> <87pnmfgw03.fsf@gnu.org> <87wogkh4s0.fsf@cbaines.net> From: Christopher Baines In-reply-to: <87wogkh4s0.fsf@cbaines.net> Date: Sun, 14 Jul 2019 19:23:29 +0100 Message-ID: <87tvboh3vi.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 35790@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Christopher Baines writes: > Ludovic Court=C3=A8s writes: > >> Christopher Baines skribis: >> >>> To try and move towards making programatic access to the linting code e= asier, >>> this commit separates out the linting script, from the linting function= ality >>> that it uses. >> >> For the final version, please write a change log. > > Sure, any suggestions about how to write it? I wasn't sure whether to > list everything that had been moved from (guix scripts lint) to (guix > lint), or say that the file has moved, and list the things that have > been moved back. Actually, now that I've run make, that's spotted some problems in some checks. guix/lint.scm:198:17: warning: possibly unbound variable `texi->plain-text' guix/lint.scm:406:8: warning: possibly unbound variable `texi->plain-text' guix/lint.scm:737:36: warning: possibly unbound variable `fill-paragraph' guix/lint.scm:738:36: warning: possibly unbound variable `fill-paragraph' guix/lint.scm:743:20: warning: possibly unbound variable `fill-paragraph' I don't think these are as easy to solve, as these functions come from (guix ui). --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl0rcyFfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xfdew//WiTScSUFcgIhLiSbLJGI0aMcXq65NB/naDNfy/bl9nhRTX/shzj4gwCL HG2QnEZEsXmk0tK0XW62BWIT1GSiR/2+f/U7Z2p+aa6sjU1xdsZrWv8GiEb3PbZt FLR48M7AXrJ+MV6YKWOBM8ruMNv3z+eybRYbqh1SLkTyPfvuhtg9rcPRKZJB3k9i /3F50xl/gT9JPNQv3beb895x7dRkVMVofvPFMN5BOfXFp4BZz8Gi8VJaMI0i4bmV nFsS+k9xBC+gBCHU6av2n1/0xIuVft86c7QOV5TcRkQS7zSywfpN5nlYlk7Oshoq opo+sabRa3d5/rwK3D2pLZ1fjyY0Yo1mMNaGuBpqeY+jZYgjMJpK6o++Vzo9Zh/t Ygk+vz+LQbteprTc6f4ay8Q8cTIzVNN5oTDxyeYaktjiAyJEMxSWCxCATsivlny0 UKfBMneQUFSgmiDQUxEDx8vJS+IMXwmu3SAfcH1SNfK++UDNulZTGQ4yZURoU9OS hjgfSOBIcwUGtetXNK/qIS8JHioHwHL5RutDHmsAL89bMSjeJoy3UuO3IQGN7fOs vICJ0FTwCht/CfbtsKLax/ZJtKS1cXHz0uJZyT0YLvlHZYkEytHPbJK7ATFk5cw6 cC1KsJVUZX0yfu9ThX+9G1oouqkl83S3xd9eK+P1NE7zSgjFQWM= =yfsP -----END PGP SIGNATURE----- --=-=-=--