From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:50537)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hn79C-0003CR-HP
 for guix-patches@gnu.org; Mon, 15 Jul 2019 16:00:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hn78w-0002yR-ON
 for guix-patches@gnu.org; Mon, 15 Jul 2019 16:00:26 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:40386)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hn78l-0002vR-0J
 for guix-patches@gnu.org; Mon, 15 Jul 2019 16:00:05 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hn78k-0000ZK-Nf
 for guix-patches@gnu.org; Mon, 15 Jul 2019 16:00:02 -0400
Subject: [bug#36615] [PATCH] gnu: Add opencascade-occt.
Resent-Message-ID: <handler.36615.B36615.15632207762126@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <1562926068-5497-1-git-send-email-pgarlick@tourbillion-technology.com>
 <87blxydiqk.fsf@gnu.org>
 <3458feeb2324ad0285fea2ac4b16330c64e59b99.camel@tourbillion-technology.com>
Date: Mon, 15 Jul 2019 21:59:23 +0200
In-Reply-To: <3458feeb2324ad0285fea2ac4b16330c64e59b99.camel@tourbillion-technology.com>
 (Paul Garlick's message of "Mon, 15 Jul 2019 19:33:20 +0100")
Message-ID: <87tvbnhxwk.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Paul Garlick <pgarlick@tourbillion-technology.com>
Cc: 36615@debbugs.gnu.org

Hi Paul,

Paul Garlick <pgarlick@tourbillion-technology.com> skribis:

>> Sometimes CMake-based packages have a configure-time option like
>> -DWITH_TESTS=3DON.  Is there something like that here?
>
> Not in this case, AFAICS.  There is a test system that is accessible
> after installation, via a shell script, so I have included a comment
> and a link to the documentation for that.

OK, sounds good.

> This version of OpenCASCADE is the upstream version.  In recent times
> it has been updated more regularly than the oce version.

I see.

> From 3f50efc7447e7d511cca0ca05ec3539df73838fa Mon Sep 17 00:00:00 2001
> From: Paul Garlick <pgarlick@tourbillion-technology.com>
> Date: Fri, 12 Jul 2019 10:56:41 +0100
> Subject: [PATCH] gnu: Add opencascade-occt.
>
> * gnu/packages/maths.scm (opencascade-occt): New variable.

[...]

> +    (version "7.3.0p3")
> +    (source
> +      (origin
> +        (method git-fetch)
> +        (uri (git-reference
> +              (url "https://git.dev.opencascade.org/repos/occt.git")
> +              (commit "e1c158598a585694ad769cde5fe705a23dd586f0")))

If there=E2=80=99s a =E2=80=9Cv7.3.0p3=E2=80=9D tag or similar, please use =
that in the =E2=80=98commit=E2=80=99
field to make it clear that the commit matches the version string.

> +            ;; Remove references to deleted files.
> +            (substitute* "dox/FILES_HTML.txt"
> +                         ((".*standard.*") "" )
> +                         ((".*UIKitSample.*") ""))
                            ^
Nitpick: this is usually aligned below the first =E2=80=98u=E2=80=99 of =E2=
=80=98substitute*=E2=80=99.
:-)

OK to push with these changes, thank you!

Ludo=E2=80=99.