From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:41311)
 by lists.gnu.org with esmtp (Exim 4.86_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hqj35-0005ia-O7
 for guix-patches@gnu.org; Thu, 25 Jul 2019 15:05:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hqj34-0001Jv-Ox
 for guix-patches@gnu.org; Thu, 25 Jul 2019 15:05:07 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:59857)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1hqj30-0001HR-KK
 for guix-patches@gnu.org; Thu, 25 Jul 2019 15:05:03 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1hqj30-0000gz-DE
 for guix-patches@gnu.org; Thu, 25 Jul 2019 15:05:02 -0400
Subject: [bug#36477] [PATCH 27/31] gnu: pkg-config: Fix cross-compilation.
Resent-Message-ID: <handler.36477.B36477.15640814742617@debbugs.gnu.org>
References: <20190708095913.3460-1-m.othacehe@gmail.com>
 <20190708095913.3460-28-m.othacehe@gmail.com> <87d0iknzvw.fsf@devup.no>
 <87h87ai16x.fsf@gmail.com>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <87h87ai16x.fsf@gmail.com>
Date: Thu, 25 Jul 2019 21:04:24 +0200
Message-ID: <87tvba7x6v.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: m.othacehe@gmail.com
Cc: 36477@debbugs.gnu.org


Mathieu Othacehe <m.othacehe@gmail.com> writes:

>> Are these indicative of a problem in our cross stack, or a bug in the
>> pkg-config build system/code?
>>
>> LGTM anyway.
>
> No those bits seems to be needed because of a problem in pkg-config
> itself. See this nixpkg pkg-config package snippet:
>
> --8<---------------cut here---------------start------------->8---
>   configureFlags =3D [ "--with-internal-glib" ]
>     ++ optional (stdenv.isSunOS) [ "--with-libiconv=3Dgnu" "--with-system=
-library-path" "--with-system-include-path" "CFLAGS=3D-DENABLE_NLS" ]
>        # Can't run these tests while cross-compiling
>     ++ optional (stdenv.hostPlatform !=3D stdenv.buildPlatform)
>        [ "glib_cv_stack_grows=3Dno"
>          "glib_cv_uscore=3Dno"
>          "ac_cv_func_posix_getpwuid_r=3Dyes"
>          "ac_cv_func_posix_getgrgid_r=3Dyes"
>        ];
> --8<---------------cut here---------------end--------------->8---

In this case it would be good to add a comment so that our future selves
won=E2=80=99t be confused.

Thanks!

--=20
Ricardo