* [bug#29301] [PATCH] substitute* hard-coded paths with paths from "out" @ 2017-11-15 0:41 Kristofer Buffington 2017-11-23 21:59 ` Ludovic Courtès 2019-09-27 13:07 ` [bug#29301] " Tobias Geerinckx-Rice via Guix-patches via 0 siblings, 2 replies; 10+ messages in thread From: Kristofer Buffington @ 2017-11-15 0:41 UTC (permalink / raw) To: 29301 * gnu/packages/guile.scm used substitute* to correct some hardcoded paths in the artanis package --- gnu/packages/guile.scm | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm index abcefd32e..b7c2dd4c7 100644 --- a/gnu/packages/guile.scm +++ b/gnu/packages/guile.scm @@ -15,6 +15,7 @@ ;;; Copyright © 2017 Mathieu Othacehe <m.othacehe@gmail.com> ;;; Copyright © 2017 Theodoros Foradis <theodoros@foradis.org> ;;; Copyright © 2017 ng0 <ng0@infotropique.org> +;;; Copyright © 2017 Kristofer Buffington <kristoferbuffington@gmail.com> ;;; ;;; This file is part of GNU Guix. ;;; @@ -431,7 +432,8 @@ program can be installed in one go.") post))) (substitute* "artanis/artanis.scm" (("[[:punct:][:space:]]+->json-string[[:punct:][:space:]]+") - "")))))) + "")) + )))) (build-system gnu-build-system) ;; TODO: Add guile-dbi and guile-dbd optional dependencies. (inputs `(("guile" ,guile-2.2) @@ -458,6 +460,14 @@ program can be installed in one go.") ((" /etc/bash.bashrc") " /dev/null")) (substitute* "Makefile" ;set the root of config files to OUT ((" /etc") (string-append " " out "/etc"))) + (substitute* "artanis/config.scm" + (("/etc/artanis/artanis.conf") + (string-append out "/etc/artanis.conf")) + (("/etc/artanis/pages") + (string-append out "/etc/artanis"))) + (substitute* "etc/artanis/artanis.conf" + (("/etc/artanis/pages") + (string-append out "/etc/artanis"))) (mkdir-p (string-append out "/bin")) ;for the `art' executable #t))) (add-after 'install 'wrap-art -- 2.15.0 Message-ID: <877euscq0y.fsf@gmail.com> ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [bug#29301] [PATCH] substitute* hard-coded paths with paths from "out" 2017-11-15 0:41 [bug#29301] [PATCH] substitute* hard-coded paths with paths from "out" Kristofer Buffington @ 2017-11-23 21:59 ` Ludovic Courtès [not found] ` <CAN1Dt4RZ3Mv5HBarSCPqoVRrXqa7bojZ-SRyEOrr2CqaaTu8cA@mail.gmail.com> 2019-09-27 13:07 ` [bug#29301] " Tobias Geerinckx-Rice via Guix-patches via 1 sibling, 1 reply; 10+ messages in thread From: Ludovic Courtès @ 2017-11-23 21:59 UTC (permalink / raw) To: Kristofer Buffington; +Cc: 29301 Hi Kristofer, Kristofer Buffington <kristoferbuffington@gmail.com> skribis: > * gnu/packages/guile.scm > used substitute* to correct some hardcoded paths in the artanis package [...] > + (substitute* "artanis/config.scm" > + (("/etc/artanis/artanis.conf") > + (string-append out "/etc/artanis.conf")) > + (("/etc/artanis/pages") > + (string-append out "/etc/artanis"))) > + (substitute* "etc/artanis/artanis.conf" > + (("/etc/artanis/pages") > + (string-append out "/etc/artanis"))) Shouldn’t we instead configure it with --sysconfdir=/etc? That would allow users to provide custom configuration files, whereas currently OUTPUT/etc/artanis contains immutable configuration files. WDYT? Thanks, Ludo’. ^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <CAN1Dt4RZ3Mv5HBarSCPqoVRrXqa7bojZ-SRyEOrr2CqaaTu8cA@mail.gmail.com>]
* [bug#29301] Fwd: [bug#29301] [PATCH] substitute* hard-coded paths with paths from "out" [not found] ` <CAN1Dt4RZ3Mv5HBarSCPqoVRrXqa7bojZ-SRyEOrr2CqaaTu8cA@mail.gmail.com> @ 2017-11-27 1:31 ` Kristofer Buffington 2017-11-27 8:51 ` Ludovic Courtès 1 sibling, 0 replies; 10+ messages in thread From: Kristofer Buffington @ 2017-11-27 1:31 UTC (permalink / raw) To: 29301 [-- Attachment #1: Type: text/plain, Size: 1629 bytes --] ---------- Forwarded message ---------- From: Kristofer Buffington <kristoferbuffington@gmail.com> Date: Sun, Nov 26, 2017 at 8:30 PM Subject: Re: [bug#29301] [PATCH] substitute* hard-coded paths with paths from "out" To: Ludovic Courtès <ludo@gnu.org> I will investigate. There are some hard coded paths in artanis/config.scm looking for the configuration file in /etc/artanis/artanis.conf -- I don't believe the --sysconfdir flag will have any impact on the hard-coded paths. Perhaps I should send a patch upstream to eliminate the hard paths? Then the substitute* would be unnecessary? Thanks! Kris On Thu, Nov 23, 2017 at 4:59 PM, Ludovic Courtès <ludo@gnu.org> wrote: > Hi Kristofer, > > Kristofer Buffington <kristoferbuffington@gmail.com> skribis: > > > * gnu/packages/guile.scm > > used substitute* to correct some hardcoded paths in the artanis package > > [...] > > > + (substitute* "artanis/config.scm" > > + (("/etc/artanis/artanis.conf") > > + (string-append out "/etc/artanis.conf")) > > + (("/etc/artanis/pages") > > + (string-append out "/etc/artanis"))) > > + (substitute* "etc/artanis/artanis.conf" > > + (("/etc/artanis/pages") > > + (string-append out "/etc/artanis"))) > > Shouldn’t we instead configure it with --sysconfdir=/etc? That would > allow users to provide custom configuration files, whereas currently > OUTPUT/etc/artanis contains immutable configuration files. > > WDYT? > > Thanks, > Ludo’. > [-- Attachment #2: Type: text/html, Size: 2594 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* [bug#29301] [PATCH] substitute* hard-coded paths with paths from "out" [not found] ` <CAN1Dt4RZ3Mv5HBarSCPqoVRrXqa7bojZ-SRyEOrr2CqaaTu8cA@mail.gmail.com> 2017-11-27 1:31 ` [bug#29301] Fwd: " Kristofer Buffington @ 2017-11-27 8:51 ` Ludovic Courtès 2017-11-28 21:10 ` Kristofer Buffington 1 sibling, 1 reply; 10+ messages in thread From: Ludovic Courtès @ 2017-11-27 8:51 UTC (permalink / raw) To: Kristofer Buffington; +Cc: 29301 Hi, (Please always keep the bug Cc’d.) Kristofer Buffington <kristoferbuffington@gmail.com> skribis: > I will investigate. There are some hard coded paths in artanis/config.scm > looking for the configuration file in /etc/artanis/artanis.conf -- I don't > believe the --sysconfdir flag will have any impact on the hard-coded paths. > Perhaps I should send a patch upstream to eliminate the hard paths? Then > the substitute* would be unnecessary? --sysconfdir would not change the hard-coded file names, but it would actually make those hard-coded file names valid. And again, using /etc as the sysconfdir would allow people to have a writable artanis.conf file, for instance, so that’s definitely something we should do. Thanks, Ludo’. ^ permalink raw reply [flat|nested] 10+ messages in thread
* [bug#29301] [PATCH] substitute* hard-coded paths with paths from "out" 2017-11-27 8:51 ` Ludovic Courtès @ 2017-11-28 21:10 ` Kristofer Buffington 2018-02-06 15:13 ` Ludovic Courtès 0 siblings, 1 reply; 10+ messages in thread From: Kristofer Buffington @ 2017-11-28 21:10 UTC (permalink / raw) To: Ludovic Courtès; +Cc: 29301 [-- Attachment #1: Type: text/plain, Size: 1002 bytes --] Cool! I am not very familiar with autotools. I appreciate the help! I will follow up with a new patch. Thanks Kris On Nov 27, 2017 3:52 AM, "Ludovic Courtès" <ludo@gnu.org> wrote: > Hi, > > (Please always keep the bug Cc’d.) > > Kristofer Buffington <kristoferbuffington@gmail.com> skribis: > > > I will investigate. There are some hard coded paths in artanis/config.scm > > looking for the configuration file in /etc/artanis/artanis.conf -- I > don't > > believe the --sysconfdir flag will have any impact on the hard-coded > paths. > > Perhaps I should send a patch upstream to eliminate the hard paths? Then > > the substitute* would be unnecessary? > > --sysconfdir would not change the hard-coded file names, but it would > actually make those hard-coded file names valid. And again, using /etc > as the sysconfdir would allow people to have a writable artanis.conf > file, for instance, so that’s definitely something we should do. > > Thanks, > Ludo’. > [-- Attachment #2: Type: text/html, Size: 1451 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* [bug#29301] [PATCH] substitute* hard-coded paths with paths from "out" 2017-11-28 21:10 ` Kristofer Buffington @ 2018-02-06 15:13 ` Ludovic Courtès [not found] ` <CAN1Dt4QCrNX3HT6w-zn5AkXTKMJ_WZYxmmHgfzKVBb4jkhSUcQ@mail.gmail.com> 2022-01-13 15:56 ` zimoun 0 siblings, 2 replies; 10+ messages in thread From: Ludovic Courtès @ 2018-02-06 15:13 UTC (permalink / raw) To: Kristofer Buffington; +Cc: 29301 Hi Kristofer, Kristofer Buffington <kristoferbuffington@gmail.com> skribis: > Cool! I am not very familiar with autotools. I appreciate the help! I will > follow up with a new patch. Any update on this? :-) Ludo’. ^ permalink raw reply [flat|nested] 10+ messages in thread
[parent not found: <CAN1Dt4QCrNX3HT6w-zn5AkXTKMJ_WZYxmmHgfzKVBb4jkhSUcQ@mail.gmail.com>]
* [bug#29301] [PATCH] substitute* hard-coded paths with paths from "out" [not found] ` <CAN1Dt4QCrNX3HT6w-zn5AkXTKMJ_WZYxmmHgfzKVBb4jkhSUcQ@mail.gmail.com> @ 2018-02-09 14:15 ` Kristofer Buffington 0 siblings, 0 replies; 10+ messages in thread From: Kristofer Buffington @ 2018-02-09 14:15 UTC (permalink / raw) To: Ludovic Courtès; +Cc: 29301 [-- Attachment #1: Type: text/plain, Size: 517 bytes --] Sorry I haven't had a stable internet connection since early december and haven't been coding much as a result. I will be back at the computer in about 3 weeks to revisit this. Kristofer On Feb 6, 2018 10:13 AM, "Ludovic Courtès" <ludo@gnu.org> wrote: > Hi Kristofer, > > Kristofer Buffington <kristoferbuffington@gmail.com> skribis: > > > Cool! I am not very familiar with autotools. I appreciate the help! I > will > > follow up with a new patch. > > Any update on this? :-) > > Ludo’. > [-- Attachment #2: Type: text/html, Size: 956 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* [bug#29301] [PATCH] substitute* hard-coded paths with paths from "out" 2018-02-06 15:13 ` Ludovic Courtès [not found] ` <CAN1Dt4QCrNX3HT6w-zn5AkXTKMJ_WZYxmmHgfzKVBb4jkhSUcQ@mail.gmail.com> @ 2022-01-13 15:56 ` zimoun 2022-01-17 13:18 ` bug#29301: " Ludovic Courtès 1 sibling, 1 reply; 10+ messages in thread From: zimoun @ 2022-01-13 15:56 UTC (permalink / raw) To: Ludovic Courtès; +Cc: 29301, Kristofer Buffington Hi, The patch #29301 [1] had been submitted on 2017 and… On Tue, 06 Feb 2018 at 16:13, ludo@gnu.org (Ludovic Courtès) wrote: > Any update on this? :-) …this last message is from 2018. I am proposing to close. 1: <http://issues.guix.gnu.org/issue/29301> Cheers, simon ^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#29301: [PATCH] substitute* hard-coded paths with paths from "out" 2022-01-13 15:56 ` zimoun @ 2022-01-17 13:18 ` Ludovic Courtès 0 siblings, 0 replies; 10+ messages in thread From: Ludovic Courtès @ 2022-01-17 13:18 UTC (permalink / raw) To: zimoun; +Cc: 29301-done, Kristofer Buffington Hi, zimoun <zimon.toutoune@gmail.com> skribis: > The patch #29301 [1] had been submitted on 2017 and… > > On Tue, 06 Feb 2018 at 16:13, ludo@gnu.org (Ludovic Courtès) wrote: > >> Any update on this? :-) > > …this last message is from 2018. I am proposing to close. > > > 1: <http://issues.guix.gnu.org/issue/29301> Agreed, and done (it may not even apply to current Artanis). Thanks, Ludo’. ^ permalink raw reply [flat|nested] 10+ messages in thread
* [bug#29301] [PATCH] substitute* hard-coded paths with paths from "out" 2017-11-15 0:41 [bug#29301] [PATCH] substitute* hard-coded paths with paths from "out" Kristofer Buffington 2017-11-23 21:59 ` Ludovic Courtès @ 2019-09-27 13:07 ` Tobias Geerinckx-Rice via Guix-patches via 1 sibling, 0 replies; 10+ messages in thread From: Tobias Geerinckx-Rice via Guix-patches via @ 2019-09-27 13:07 UTC (permalink / raw) To: 29301; +Cc: kristoferbuffington [-- Attachment #1: Type: text/plain, Size: 166 bytes --] Kristofer Buffington 写道： > I will be back at the computer in about 3 weeks to revisit this. …ping :-) Is this still relevant? Kind regards, T G-R [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 832 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-01-17 14:13 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-15 0:41 [bug#29301] [PATCH] substitute* hard-coded paths with paths from "out" Kristofer Buffington
2017-11-23 21:59 ` Ludovic Courtès
[not found] ` <CAN1Dt4RZ3Mv5HBarSCPqoVRrXqa7bojZ-SRyEOrr2CqaaTu8cA@mail.gmail.com>
2017-11-27 1:31 ` [bug#29301] Fwd: " Kristofer Buffington
2017-11-27 8:51 ` Ludovic Courtès
2017-11-28 21:10 ` Kristofer Buffington
2018-02-06 15:13 ` Ludovic Courtès
[not found] ` <CAN1Dt4QCrNX3HT6w-zn5AkXTKMJ_WZYxmmHgfzKVBb4jkhSUcQ@mail.gmail.com>
2018-02-09 14:15 ` Kristofer Buffington
2022-01-13 15:56 ` zimoun
2022-01-17 13:18 ` bug#29301: " Ludovic Courtès
2019-09-27 13:07 ` [bug#29301] " Tobias Geerinckx-Rice via Guix-patches via
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/guix.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).