From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:35946) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLWux-0008MH-UU for guix-patches@gnu.org; Fri, 18 Oct 2019 14:24:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iLWuw-0005il-PX for guix-patches@gnu.org; Fri, 18 Oct 2019 14:24:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42722) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iLWuw-0005iV-H4 for guix-patches@gnu.org; Fri, 18 Oct 2019 14:24:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iLWuw-0005oa-Bs for guix-patches@gnu.org; Fri, 18 Oct 2019 14:24:02 -0400 Subject: [bug#37717] [PATCH 1/3] gnu: Add ghc-atomic-primops. Resent-Message-ID: From: Marius Bakke In-Reply-To: References: <4551b258-a4e3-49f8-9c22-5840edbbd3a7@www.fastmail.com> Date: Fri, 18 Oct 2019 20:23:22 +0200 Message-ID: <87tv85ykth.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Alex Griffin , 37717@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable "Alex Griffin" writes: > From 77ff329dd34d307f19629086baf44c1623858fa1 Mon Sep 17 00:00:00 2001 > From: Alex Griffin > Date: Sat, 12 Oct 2019 13:34:43 -0500 > Subject: [PATCH 1/3] gnu: Add ghc-atomic-primops. > > * gnu/packages/haskell-xyz.scm (ghc-atomic-primops): New variable. [...] > diff --git a/gnu/packages/haskell-xyz.scm b/gnu/packages/haskell-xyz.scm > index 2977398880..37df2ed909 100644 > --- a/gnu/packages/haskell-xyz.scm > +++ b/gnu/packages/haskell-xyz.scm > @@ -381,6 +382,31 @@ over threads in Haskell, in which @code{Async a} is = a concurrent thread that > will eventually deliver a value of type @code{a}.") > (license license:bsd-3))) >=20=20 > +(define-public ghc-atomic-primops > + (package > + (name "ghc-atomic-primops") > + (version "0.8.3") Note: we follow the Stackage LTS versions for GHC 7.4, currently 12.26. So I think we should take version 0.8.2 instead: https://www.stackage.org/lts-12.26/package/atomic-primops-0.8.2 (hopefully Timothy or someone can correct me if I'm wrong here) > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "https://hackage.haskell.org/package/atomic-primops/atomic-= primops-" > + version > + ".tar.gz")) Can you align these lines a bit? > + (sha256 > + (base32 > + "03n5dmyplrqgbyf8dr91izkxci7gkl3i3fnp82i5ld869zrgjfh0")))) > + (build-system haskell-build-system) > + (inputs `(("ghc-primitive" ,ghc-primitive))) > + (home-page "https://github.com/rrnewton/haskell-lockfree/wiki") > + (synopsis "Safe approach to CAS and other atomic ops") > + (description > + "After GHC 7.4 a new @code{casMutVar#} primop became available, but= it's > +difficult to use safely, because pointer equality is a highly unstable p= roperty > +in Haskell. This library provides a safer method based on the concept of > +@code{Ticket}s.") Can you try to adjust the first sentence so that it reads better? Perhaps something along the lines of "GHC 7.4 introduced a new @code{casMutVar#} PrimOp which is difficult to use safely, because ...". --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl2qAxoACgkQoqBt8qM6 VPrNmQgAwd5jJ3iv0l70VWQiUFVV/6QRxHnOceExSU/jxRHVMGsHk3Ew4LhLcgWd uV6xlftMo6+f7UfUlix9UXJs1Qzuvy875h1bXFMRXOscqIsV67Xn8RwgkY8PTFBJ TIMxvDn7P87dbtjZf8AMQsEKbZdDqutExCHG/+Rc8CI4M1QxsueBsPffhcfC86EV YVwwPCPlyxEcck6V/lHUfaruhXqZD2VIl+1VLCYXspn0O7cfT92tWGokEKtXS2Bb +n3VRAYv9sDy8YOaZWBsUbEIwPOtol1JG713gAZ3szvEdQWpYjRZpGRQvTWwBvFZ xVgNp9Nx5o7MQnLKqRdNwfcifkNgxA== =boy/ -----END PGP SIGNATURE----- --=-=-=--