From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:34472) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPkml-00084E-Ar for guix-patches@gnu.org; Wed, 30 Oct 2019 06:01:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iPkmk-00007C-9q for guix-patches@gnu.org; Wed, 30 Oct 2019 06:01:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40449) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iPkmk-00006w-6Z for guix-patches@gnu.org; Wed, 30 Oct 2019 06:01:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iPkmk-0004of-3k for guix-patches@gnu.org; Wed, 30 Oct 2019 06:01:02 -0400 Subject: [bug#37987] Add gitg Resent-Message-ID: References: From: Mathieu Othacehe In-reply-to: Date: Wed, 30 Oct 2019 11:00:11 +0100 Message-ID: <87tv7qbljo.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 37987@debbugs.gnu.org Hello Leo, > The package contains failing tests, so I've disabled them altogether > for now. I've tried setting up an X display, thinking it could aid the > situation, but that only leads to a timeout in another test. I'm a bit > at a loss here. Your patch LGTM. About failing test, I see that nix runs them and has a small fix to substitute bash path: --8<---------------cut here---------------start------------->8--- substituteInPlace tests/libgitg/test-commit.vala --replace "/bin/bash" "${bash}/bin/bash" --8<---------------cut here---------------end--------------->8--- Have you tried something like that? Thanks, Mathieu