unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <m.othacehe@gmail.com>
To: 37987@debbugs.gnu.org
Subject: [bug#37987] Add gitg
Date: Wed, 30 Oct 2019 11:00:11 +0100	[thread overview]
Message-ID: <87tv7qbljo.fsf@gmail.com> (raw)
In-Reply-To: <d8c6f7121f05e579f20456a41048ea818a4cefd2.camel@student.tugraz.at>


Hello Leo,

> The package contains failing tests, so I've disabled them altogether
> for now.  I've tried setting up an X display, thinking it could aid the
> situation, but that only leads to a timeout in another test.  I'm a bit
> at a loss here.

Your patch LGTM. About failing test, I see that nix runs them and has a
small fix to substitute bash path:

--8<---------------cut here---------------start------------->8---
    substituteInPlace tests/libgitg/test-commit.vala --replace "/bin/bash" "${bash}/bin/bash"
--8<---------------cut here---------------end--------------->8---

Have you tried something like that?

Thanks,

Mathieu

  reply	other threads:[~2019-10-30 10:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-30  9:35 [bug#37987] Add gitg Leo Prikler
2019-10-30 10:00 ` Mathieu Othacehe [this message]
2019-10-30 12:56 ` Leo Prikler
2019-10-30 16:18   ` bug#37987: " Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tv7qbljo.fsf@gmail.com \
    --to=m.othacehe@gmail.com \
    --cc=37987@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).