unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Brice Waegeneire <brice@waegenei.re>
Cc: 37927-done@debbugs.gnu.org, 37928-done@debbugs.gnu.org
Subject: bug#37927: [bug#37928] [PATCH v2] import: crate: Better handle license expressions.
Date: Wed, 11 Dec 2019 12:24:04 +0100	[thread overview]
Message-ID: <87tv67jeaz.fsf@gnu.org> (raw)
In-Reply-To: <20191126201721.7370-2-brice@waegenei.re> (Brice Waegeneire's message of "Tue, 26 Nov 2019 21:17:21 +0100")

Hi Brice,

Brice Waegeneire <brice@waegenei.re> skribis:

> * guix/import/crate.scm (%dual-license-rx): Removed function.
> (crate->guix-package): Handle most of the multi-licensing cases.
> * tests/crate.scm (licenses): Add tests for some licenses.

Thanks for the updated patch!

> +(define (string->license string)
> +    (map
> +     spdx-string->license
> +     (filter (lambda (license)
> +               (and (not (string-null? license))
> +                   (not (any (lambda (elem) (string=? elem license))
> +                             '("AND" "OR" "WITH")))))
> +            (string-split string (string->char-set " /")))))

I changed that to use ‘filter-map’ instead and pushed as
263a267b75e472cb84428571580dabd99d5dff0c.

Thanks!

Ludo’.

      reply	other threads:[~2019-12-11 13:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-25 20:27 [bug#37927] Brice Waegeneire
2019-10-25 20:27 ` [bug#37928] [PATCH] import: crate: Fix licenses Brice Waegeneire
2019-11-04 22:27   ` [bug#37927] " Ludovic Courtès
2019-11-16 16:37     ` Ludovic Courtès
2019-11-26 20:17   ` [bug#37928] Brice Waegeneire
2019-11-26 20:17     ` [bug#37928] [PATCH v2] import: crate: Better handle license expressions Brice Waegeneire
2019-12-11 11:24       ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tv67jeaz.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=37927-done@debbugs.gnu.org \
    --cc=37928-done@debbugs.gnu.org \
    --cc=brice@waegenei.re \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).