From: Christopher Baines <mail@cbaines.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 40162@debbugs.gnu.org
Subject: [bug#40162] [PATCH] gnu: guix-data-service: Update to 0.0.1-19.d12909d.
Date: Thu, 26 Mar 2020 21:28:05 +0000 [thread overview]
Message-ID: <87tv2akdqy.fsf@cbaines.net> (raw)
In-Reply-To: <874kuhxtrp.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1426 bytes --]
Ludovic Courtès <ludo@gnu.org> writes:
> Hi!
>
> Christopher Baines <mail@cbaines.net> skribis:
>
>> These changes support the guix-data-service-backup-database and
>> guix-data-service-create-small-backup scripts. These are shell scripts, so
>> require coreutils from the build environment at runtime as well as binaries
>> from postgresql, ephemeralpg and optionally util-linux (for ionice and
>> renice).
>>
>> * gnu/packages/web.scm (guix-data-service): Update to 0.0.1-19.d12909d.
>> [arguments]: Add (ice-9 ftw) and (ice-9 match) to #:modules, change the
>> 'install phase to wrap all bin files with the PATH at build time.
>> [inputs]: Add util-linux and include ephemeralpg from native-inputs.
>> [native-inputs]: Move ephemeralpg to inputs.
>
> [...]
>
>> (lambda (file)
>> + (simple-format (current-error-port)
>> + "wrapping: ~A\n"
>> + (string-append bin "/" file))
>> (wrap-program (string-append bin "/" file)
>> `("PATH" ":" prefix
>> - (,bin))
>> + (,bin ,(getenv "PATH")))
>
> If I’m not mistaken, this would keep references to GCC, etc.
>
> What about explicitly listing the things that you list above?
Indeed, I've sent another patch which explicitly lists some inputs.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]
next prev parent reply other threads:[~2020-03-26 21:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-21 9:22 [bug#40162] [PATCH] gnu: guix-data-service: Update to 0.0.1-19.d12909d Christopher Baines
2020-03-21 21:50 ` Ludovic Courtès
2020-03-26 21:28 ` Christopher Baines [this message]
2020-03-26 21:26 ` Christopher Baines
2020-03-26 21:33 ` Ludovic Courtès
2020-03-26 22:53 ` bug#40162: " Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tv2akdqy.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=40162@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).