From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:57418)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jRBwF-0004Ad-6g
 for guix-patches@gnu.org; Wed, 22 Apr 2020 05:45:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jRBwE-0007ZF-Ov
 for guix-patches@gnu.org; Wed, 22 Apr 2020 05:45:02 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:39795)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jRBwD-0007XN-Qa
 for guix-patches@gnu.org; Wed, 22 Apr 2020 05:45:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jRBwD-00079U-O8
 for guix-patches@gnu.org; Wed, 22 Apr 2020 05:45:01 -0400
Subject: [bug#40677] [PATCH 18/18] gnu: pjproject-jami: Add the missing,
 linux-only "--enable-epoll" flag.
Resent-Message-ID: <handler.40677.B40677.158754867427436@debbugs.gnu.org>
From: Mathieu Othacehe <m.othacehe@gmail.com>
References: <20200421161032.1847-1-tona_kosmicznego_smiecia@interia.pl>
 <20200421161032.1847-18-tona_kosmicznego_smiecia@interia.pl>
Date: Wed, 22 Apr 2020 11:44:24 +0200
In-Reply-To: <20200421161032.1847-18-tona_kosmicznego_smiecia@interia.pl> (Jan
 Wielkiewicz's message of "Tue, 21 Apr 2020 18:10:32 +0200")
Message-ID: <87tv1bonwn.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Jan Wielkiewicz <tona_kosmicznego_smiecia@interia.pl>
Cc: 40677@debbugs.gnu.org


> -             "--disable-l16-codec"
> -             "--disable-gsm-codec"
> -             "--disable-g722-codec"
> -             "--disable-g7221-codec"
> -             "--disable-speex-codec"

You should fix indentation in a separate commit, otherwise its hard to
see get what's going on here.

> +        ;; The following flag is linux specific
> +        ,@(if (hurd-triplet? (or (%current-system)
> +                                 (%current-target-system)))
> +              '("--enable-epoll")
> +              '())

Don't we want to add this flag only on Linux platform? I think you
should transpose the if branches.

Thanks,

Mathieu