unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>
To: 41024@debbugs.gnu.org
Subject: [bug#41024] [PATCH] gnu: tmux: Update to 3.1.b.
Date: Sat, 02 May 2020 15:32:51 +0200	[thread overview]
Message-ID: <87tv0ypim4.fsf@nckx> (raw)
In-Reply-To: <20200502125143.3594-1-brice@waegenei.re>

[-- Attachment #1: Type: text/plain, Size: 1301 bytes --]

Brice,

Brice Waegeneire 写道:
> * gnu/packages/tmux.scm (tmux)[version]: Update to 3.1.b.

You can drop [version] here.

We treat the version + hash bump as a package-level operation to 
avoid noise like ‘[source]: Update SHA256.’ every time. 
Explicitly listing non-routine changes is correct:

> [source]: Fetch from git instead of a tarball.
> [native-inputs]: Add 'autoconf', 'automake', 'bison' and 
> 'pkg-config'.

> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/tmux/tmux.git")
> +                    (commit version)))
> +              (sha256
> +               (base32
> + 
> "0d8c7f1v75khgq06hlmhsxlxl7jf0mf767aw0makhqg8mxana8by"))))

I'd add a comment to revert to the (hopefully…) bootstrapped 3.2 
tarball when it lands so these new native-inputs and module 
imports can be removed.

When migrating to GIT-FETCH, add a

  (file-name (git-file-name name version))

to the end to turn

  $ guix build --source tmux
  /gnu/store/xndh3x1qj0b59bxg6za0bcllnxvk2wpl-git-checkout

into

  $ guix build --source tmux
  /gnu/store/ns97s45k3qv6vjw3p5xh9bz0bqg1dhia-tmux-3.1b-checkout

purely for humans' sake.

OK with these changes.  Thanks!

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

  reply	other threads:[~2020-05-02 13:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-02 12:51 [bug#41024] [PATCH] gnu: tmux: Update to 3.1.b Brice Waegeneire
2020-05-02 13:32 ` Tobias Geerinckx-Rice via Guix-patches via [this message]
2020-05-06  9:56 ` bug#41024: Done #41024 " Brice Waegeneire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tv0ypim4.fsf@nckx \
    --to=guix-patches@gnu.org \
    --cc=41024@debbugs.gnu.org \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).