[bug#41228] [PATCH 0/2] gnu: radio: Simplify instalation instructions

[bug#41228] [PATCH 0/2] gnu: radio: Simplify instalation instructions

[Brice Waegeneire]

Brice Waegeneire (2):
  gnu: rtl-sdr: Simplify installation instructions.
  gnu: hackrf: Simplify installation instructions.

 gnu/packages/radio.scm | 31 ++++++-------------------------
 1 file changed, 6 insertions(+), 25 deletions(-)

-- 
2.26.2

[bug#41228] [PATCH 1/2] gnu: rtl-sdr: Simplify installation instructions.

[Brice Waegeneire]

* gnu/packages/radio.scm (rtl-sdr)[description]: Replace
'modify-services' snippet with 'udev-rules-service'.
---
 gnu/packages/radio.scm | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/gnu/packages/radio.scm b/gnu/packages/radio.scm
index 41105fb8c5..1e50be1bcc 100644
--- a/gnu/packages/radio.scm
+++ b/gnu/packages/radio.scm
@@ -152,17 +152,8 @@ system configuration:
 (kernel-arguments '(\"modprobe.blacklist=dvb_usb_rtl28xxu\"))
 @end lisp
 
-To install the rtl-sdr udev rules, you must add this package in the
-configuration of the udev system service. E.g.:
-
-@lisp
-(services
- (modify-services %desktop-services
-  (udev-service-type config =>
-   (udev-configuration (inherit config)
-    (rules (cons rtl-sdr
-            (udev-configuration-rules config)))))))
-@end lisp")
+To install the rtl-sdr udev rules, you must extend 'udev-service-type' with
+this package.  E.g.: @code{(udev-rules-service 'rtl-sdr rtl-sdr)}")
     (license license:gpl2+)))
 
 (define-public chirp
-- 
2.26.2

[bug#41228] [PATCH 2/2] gnu: hackrf: Simplify installation instructions.

[Brice Waegeneire]

* gnu/packages/radio.scm (hackrf)[description]: Replace
'modify-services' snippet with 'udev-rules-service'.
---
 gnu/packages/radio.scm | 18 ++++--------------
 1 file changed, 4 insertions(+), 14 deletions(-)

diff --git a/gnu/packages/radio.scm b/gnu/packages/radio.scm
index 1e50be1bcc..6a919548f0 100644
--- a/gnu/packages/radio.scm
+++ b/gnu/packages/radio.scm
@@ -741,20 +741,10 @@ for correctness.")
      (synopsis "User-space library and utilities for HackRF SDR")
      (description
       "Command line utilities and a C library for controlling the HackRF
-Software Defined Radio (SDR) over USB.  Installing this package installs
-the userspace hackrf utilities and C library.  To install the hackrf
-udev rules, you must add this package as a system service via
-modify-services.  E.g.:
-
-@lisp
-(services
- (modify-services
-  %desktop-services
-  (udev-service-type config =>
-   (udev-configuration (inherit config)
-    (rules (cons hackrf
-            (udev-configuration-rules config)))))))
-@end lisp")
+Software Defined Radio (SDR) over USB.  Installing this package installs the
+userspace hackrf utilities and C library.  To install the hackrf udev rules,
+you must extend 'udev-service-type' with this package.  E.g.:
+@code{(udev-rules-service 'hackrf hackrf #:groups '(\"dialout\"))}.")
      (license license:gpl2))))
 
 (define-public hamlib
-- 
2.26.2

[bug#41228] [PATCH 0/2] gnu: radio: Simplify instalation instructions

[Guillaume Le Vaillant]

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]


Brice Waegeneire <brice@waegenei.re> skribis:

> Brice Waegeneire (2):
>   gnu: rtl-sdr: Simplify installation instructions.
>   gnu: hackrf: Simplify installation instructions.
>
>  gnu/packages/radio.scm | 31 ++++++-------------------------
>  1 file changed, 6 insertions(+), 25 deletions(-)

It looks good to me.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

bug#41228: [PATCH 0/2] gnu: radio: Simplify instalation instructions

[Brice Waegeneire]

On 2020-05-14 09:02, Guillaume Le Vaillant wrote:
> Brice Waegeneire <brice@waegenei.re> skribis:
> 
>> Brice Waegeneire (2):
>>   gnu: rtl-sdr: Simplify installation instructions.
>>   gnu: hackrf: Simplify installation instructions.
>> 
>>  gnu/packages/radio.scm | 31 ++++++-------------------------
>>  1 file changed, 6 insertions(+), 25 deletions(-)
> 
> It looks good to me.

Thanks for the review Guillaume.

Pushed as 32290b2c35 and aee7d000f8.