From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id iNX1MwpuyV7jegAA0tVLHw (envelope-from ) for ; Sat, 23 May 2020 18:40:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id aAbkLwpuyV5YbwAAB5/wlQ (envelope-from ) for ; Sat, 23 May 2020 18:40:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 58FBE94042C for ; Sat, 23 May 2020 18:40:10 +0000 (UTC) Received: from localhost ([::1]:55804 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jcZ45-0005ZJ-By for larch@yhetil.org; Sat, 23 May 2020 14:40:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52158) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jcZ3y-0005YZ-GT for guix-patches@gnu.org; Sat, 23 May 2020 14:40:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52260) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jcZ3y-000349-7E for guix-patches@gnu.org; Sat, 23 May 2020 14:40:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jcZ3y-0008AN-5P for guix-patches@gnu.org; Sat, 23 May 2020 14:40:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41395] [PATCH 2/2] gnu: Add python-questionary Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 23 May 2020 18:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41395 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Edouard Klein , 41395@debbugs.gnu.org Received: via spool by 41395-submit@debbugs.gnu.org id=B41395.159025916831345 (code B ref 41395); Sat, 23 May 2020 18:40:02 +0000 Received: (at 41395) by debbugs.gnu.org; 23 May 2020 18:39:28 +0000 Received: from localhost ([127.0.0.1]:35573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcZ3Q-00089V-96 for submit@debbugs.gnu.org; Sat, 23 May 2020 14:39:28 -0400 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:41955) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcZ3N-00089I-QY for 41395@debbugs.gnu.org; Sat, 23 May 2020 14:39:26 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id E4C31746; Sat, 23 May 2020 14:39:19 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sat, 23 May 2020 14:39:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm3; bh=F2KUgpE9Qg9aB3smizjccm1YuV CbcI/Ws9bWVV2CBMk=; b=J6WQlAx+MnhlktyfyR5NQtGdju1V4X9Zlq2kUUxYS8 T5uPgJNwW/S8+XKfPOE/lVWtPsPfsEC/oRGwHFbry/UBROhhyGwGjehq21yTxPZG EUj3O6DWRhnbY5cQdjnnqodRrhIQPKXm/fJhO2DGNpws2SoAMJIx0neZ7tC/BpvZ bjmBgitpDWm/JXEACRMDIbxcDg5tX5UmRN3u9fQNRHNzf0X4xmi8NIxPFt+l0nlB e29vEl2KQBA3U26ghxlXPejcFsjwmiKEtY+SVmJrw3dlnoQElWeIItVvlWFYK5HM q+m9XHxV2xFh2WxbD3jQfX5Kh4INAV96WSSYH9uwfLAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=F2KUgp E9Qg9aB3smizjccm1YuVCbcI/Ws9bWVV2CBMk=; b=hHhDsciKQp9G7BK8QDBA70 N61jaFONdc3thS0lZaBne4MFNT2AM5uBfkfA051NoVCpVZB/3cdyCnA23Pqt7sUu lS1BjrKqOwCTNDlV8YphKNSB2JVc7w3K9fqlaKN9hB++00VpJ2VPBOgLfVW2vsM1 bByaX+ZYYhp3li3ydw0uzOhe7jM+VJvfAtFE/1kSbmxntLY6OACzep+qiF1njjkW q6YLuqGofjK5nuTZ3GZur03yuqldLW1UlUGj6ycxL2C197FvP0IlM+EIuEzT2EJE A8SkZzNb6xiWzE311CPMdtbTGIvicdh8JA9ilMO+9xPTraQDVv1qqLJ2weME6icA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudduhedguddvjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffujghffgffkfggtgesghdtreertdertdenucfhrhhomhepofgrrhhi uhhsuceurghkkhgvuceomhgsrghkkhgvsehfrghsthhmrghilhdrtghomheqnecuggftrf grthhtvghrnhepjeekfeekleegveejteehleejueetudeuledvffevudefvedtvdefveei feehvedtnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkphepkeegrddvtddvrd eikedrjeehnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhho mhepmhgsrghkkhgvsehfrghsthhmrghilhdrtghomh X-ME-Proxy: Received: from localhost (ti0006q161-2604.bb.online.no [84.202.68.75]) by mail.messagingengine.com (Postfix) with ESMTPA id 04FEE3066500; Sat, 23 May 2020 14:39:18 -0400 (EDT) From: Marius Bakke In-Reply-To: <87pnb0ckjh.fsf@alice.lan> References: <87v9ksckt3.fsf@alice.lan> <87pnb0ckjh.fsf@alice.lan> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Sat, 23 May 2020 20:39:17 +0200 Message-ID: <87tv067ay2.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=fastmail.com header.s=fm3 header.b=J6WQlAx+; dkim=fail (rsa verify failed) header.d=messagingengine.com header.s=fm2 header.b=hHhDsciK; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fastmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -2.01 X-TUID: WfuV7ROJuGuK --=-=-= Content-Type: text/plain Edouard Klein writes: > * /gnu/packages/python-xyz.scm (python-questionary): New variable > * /gnu/packages/python-check.scm (python-pytest-pycodestyle): New variable Can you submit these packages as two separate patches? [...] > +(define-public python-pytest-pycodestyle > + (package > + (name "python-pytest-pycodestyle") > + (version "2.0.0") ;; Any version higher than that requires python-pytest~=5.4 > + ;; (python-pytest is at version 5.3.5 as I write this comment > + ;; and 5478 packages depend on it.) You can create a 'python-pytest-5.4' variable instead of sticking to this old version, we'll probably need it sooner or later. No strong opinion though. [...] > +(define-public python-questionary > + (package > + (name "python-questionary") > + (version "1.5.2") > + (source > + (origin > + (method url-fetch) > + (uri (pypi-uri "questionary" version)) > + (sha256 > + (base32 > + "09n737qmvzbibl8hmbd5zfg1502fd9n0r8qjzz1y0vy8nqv1xr7n")))) > + (build-system python-build-system) > + (propagated-inputs > + `(("python-prompt-toolkit" ,python-prompt-toolkit))) > + (native-inputs > + `(("python-coveralls" ,python-coveralls) > + ("python-pytest-cov" ,python-pytest-cov) > + ("python-pytest-pycodestyle" > + ,python-pytest-pycodestyle) > + )) These parens feel lonely. :-) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (replace 'check > + (lambda _ > + (invoke "py.test")))))) > + (home-page "https://github.com/tmbo/questionary") > + (synopsis > + "Pretty command line user prompts") The line break here is not necessary. LGTM with these changes, can you send updated patches? Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl7JbdUACgkQoqBt8qM6 VPp4TQgAojbjmRrpPWKmEC8jwZd4XEcheft2ogEGsrcelRNnvBKbt0W92dyOgQnj ZrLgVX1AK6wjpaTm1/MZR8nOaMaPUe3Pl8wD0SiRNBy6nJCf0dzDGS/xuPWiJUiG eVRA3ncxpEMR75X1aaZyyRCbKC9BINkRFzTYNCO/k44vULlkcV2EzKbSeRgQ5v7R kHnZlhIxo946PGe3w8NvbPaEEyy/0xDV2oLcHEHhfvVArd2Rcq8FdFImarTgof9f HjFOO5L0Dy3mijf9P0CAv4piVcinSR6L2RpatC+aolTbe6U32fQQtgKlbtNcoqim n0SLvrfuV/X4//3fPlDaUPrC59KUCg== =vjdF -----END PGP SIGNATURE----- --=-=-=--