From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id MGJ7Lr4uyV5TNgAA0tVLHw (envelope-from ) for ; Sat, 23 May 2020 14:10:06 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id IJFbKr4uyV6UNgAAB5/wlQ (envelope-from ) for ; Sat, 23 May 2020 14:10:06 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 495C89404CD for ; Sat, 23 May 2020 14:10:06 +0000 (UTC) Received: from localhost ([::1]:38166 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jcUqj-0004Vr-9v for larch@yhetil.org; Sat, 23 May 2020 10:10:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60054) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jcUqg-0004Vi-Me for guix-patches@gnu.org; Sat, 23 May 2020 10:10:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51923) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jcUqg-0005FU-Dq for guix-patches@gnu.org; Sat, 23 May 2020 10:10:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jcUqg-0001Vg-9K for guix-patches@gnu.org; Sat, 23 May 2020 10:10:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41360] [PATCH 09/12] gnu: java-openjfx-web: Add new variable. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 23 May 2020 14:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41360 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Alexey Abramov Cc: 41360@debbugs.gnu.org Received: via spool by 41360-submit@debbugs.gnu.org id=B41360.15902429965788 (code B ref 41360); Sat, 23 May 2020 14:10:02 +0000 Received: (at 41360) by debbugs.gnu.org; 23 May 2020 14:09:56 +0000 Received: from localhost ([127.0.0.1]:35236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcUqa-0001VI-IY for submit@debbugs.gnu.org; Sat, 23 May 2020 10:09:56 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcUqZ-0001V6-5m for 41360@debbugs.gnu.org; Sat, 23 May 2020 10:09:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43508) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jcUqT-0005FG-VD; Sat, 23 May 2020 10:09:49 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=52244 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jcUqT-0007jl-Fv; Sat, 23 May 2020 10:09:49 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200517135138.1651512-1-levenson@mmer.org> <20200517135138.1651512-9-levenson@mmer.org> Date: Sat, 23 May 2020 16:09:47 +0200 In-Reply-To: <20200517135138.1651512-9-levenson@mmer.org> (Alexey Abramov's message of "Sun, 17 May 2020 15:51:38 +0200") Message-ID: <87tv0668us.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: Q2WNjir+HeJ7 Alexey Abramov skribis: > --- > gnu/packages/java.scm | 165 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 165 insertions(+) Please add a commit log. [...] > + (add-after 'build 'generate-headers > + (lambda* (#:key inputs #:allow-other-keys) Could you add a comment explaining what this phase does and why we=E2=80=99= re doing all this? (Same for the other phases.) > + (let* ((module (string-append (getcwd) "/modules/web")) > + (classes (string-append module "/build/classes/java/= main")) > + (web-generated-headers (string-append module "/build= /generated-src/headers")) > + (web-generated-classes '("com.sun.webkit.ContextMenu" > + "com.sun.webkit.ContextMenu= Item" > + "com.sun.webkit.CursorManag= er" Perhaps add a comment explaining how you obtained this list of classes so that our future selves know how to update it. Since this is a Web thing, could you check whether it contains pre-built (=E2=80=9Cminified=E2=80=9D) JavaScript? If it does, that=E2=80=99s a prob= lem because we generally provide only software built from source. Could you send an updated patch series? Thank you for the hard work! Ludo=E2=80=99.