* [bug#41566] [PATCH] gnu: Add emacs-erc-status-sidebar.
@ 2020-05-27 17:34 Michael Rohleder
2020-05-30 14:00 ` Marius Bakke
0 siblings, 1 reply; 4+ messages in thread
From: Michael Rohleder @ 2020-05-27 17:34 UTC (permalink / raw)
To: 41566
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.1: [PATCH] gnu: Add emacs-erc-status-sidebar. --]
[-- Type: text/x-patch, Size: 1673 bytes --]
From 2c47a49177ab0a8ceee52910007a998b73f3bf81 Mon Sep 17 00:00:00 2001
From: Michael Rohleder <mike@rohleder.de>
Date: Wed, 27 May 2020 19:31:46 +0200
Subject: [PATCH] gnu: Add emacs-erc-status-sidebar.
* gnu/packages/emacs-xyz.scm (emacs-erc-status-sidebar): New variable.
---
gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 45a10f4689..338bd270e0 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -3216,6 +3216,28 @@ appropriate console.")
IRC bouncer with ERC.")
(license license:expat)))
+(define-public emacs-erc-status-sidebar
+ (package
+ (name "emacs-erc-status-sidebar")
+ (version "20171223.2124")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "https://melpa.org/packages/erc-status-sidebar-"
+ version ".el"))
+ (sha256
+ (base32 "1jjz4zs4fx45i9nvy2h7nfzkv0qrpp1pfhr8fx3hb6wxvi6zjis0"))))
+ (build-system emacs-build-system)
+ (propagated-inputs `(("emacs-seq" ,emacs-seq)))
+ (home-page "https://github.com/drewbarbs/erc-status-sidebar")
+ (synopsis "Hexchat-like activity overview for ERC channels")
+ (description
+ "This package is provides a hexchat-like status bar for joined
+channels in ERC. It relies on the @code{erc-track} module, and displays
+all the same information erc-track does in the mode line, but in an
+alternative format.")
+ (license license:gpl3)))
+
(define-public emacs-shut-up
(package
(name "emacs-shut-up")
--
2.26.2
[-- Attachment #1.2: Type: text/plain, Size: 142 bytes --]
--
A vegan, an IntelliJ user, a Mac user, and a Linux user walked into a bar.
How do I know?
AFTER 2 MINUTES, THE WHOLE DARN BAR KNEW!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#41566] [PATCH] gnu: Add emacs-erc-status-sidebar.
2020-05-27 17:34 [bug#41566] [PATCH] gnu: Add emacs-erc-status-sidebar Michael Rohleder
@ 2020-05-30 14:00 ` Marius Bakke
2020-06-02 6:27 ` Michael Rohleder
0 siblings, 1 reply; 4+ messages in thread
From: Marius Bakke @ 2020-05-30 14:00 UTC (permalink / raw)
To: Michael Rohleder, 41566
[-- Attachment #1: Type: text/plain, Size: 1692 bytes --]
Michael Rohleder <mike@rohleder.de> writes:
> From 2c47a49177ab0a8ceee52910007a998b73f3bf81 Mon Sep 17 00:00:00 2001
> From: Michael Rohleder <mike@rohleder.de>
> Date: Wed, 27 May 2020 19:31:46 +0200
> Subject: [PATCH] gnu: Add emacs-erc-status-sidebar.
>
> * gnu/packages/emacs-xyz.scm (emacs-erc-status-sidebar): New variable.
Thanks!
> +(define-public emacs-erc-status-sidebar
> + (package
> + (name "emacs-erc-status-sidebar")
> + (version "20171223.2124")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "https://melpa.org/packages/erc-status-sidebar-"
> + version ".el"))
> + (sha256
> + (base32 "1jjz4zs4fx45i9nvy2h7nfzkv0qrpp1pfhr8fx3hb6wxvi6zjis0"))))
IIRC melpa.org purges old versions, so we should probably change to
'git-fetch' here.
> + (build-system emacs-build-system)
> + (propagated-inputs `(("emacs-seq" ,emacs-seq)))
> + (home-page "https://github.com/drewbarbs/erc-status-sidebar")
> + (synopsis "Hexchat-like activity overview for ERC channels")
> + (description
> + "This package is provides a hexchat-like status bar for joined
> +channels in ERC. It relies on the @code{erc-track} module, and displays
> +all the same information erc-track does in the mode line, but in an
> +alternative format.")
> + (license license:gpl3)))
Well this is awkward, the LICENSE file is GPL3, but the headers in
erc-status-sidebar.el actually uses the Expat license. So this should
be license:expat.
It would be good to notify upstream about this inconstency, but not a
blocking issue.
Can you send an updated patch?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#41566] [PATCH] gnu: Add emacs-erc-status-sidebar.
2020-05-30 14:00 ` Marius Bakke
@ 2020-06-02 6:27 ` Michael Rohleder
2020-06-14 21:05 ` bug#41566: " Ludovic Courtès
0 siblings, 1 reply; 4+ messages in thread
From: Michael Rohleder @ 2020-06-02 6:27 UTC (permalink / raw)
To: Marius Bakke; +Cc: 41566
[-- Attachment #1.1: Type: text/plain, Size: 401 bytes --]
Hi Marius,
thank you reviewing!
Marius Bakke <marius@gnu.org> writes:
> IIRC melpa.org purges old versions, so we should probably change to
> 'git-fetch' here.
done.
>> + (license license:gpl3)))
>
> Well this is awkward, the LICENSE file is GPL3, but the headers in
> erc-status-sidebar.el actually uses the Expat license. So this should
> be license:expat.
oh, good catch, I didnt notice!
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: [PATCH] gnu: Add emacs-erc-status-sidebar. --]
[-- Type: text/x-patch, Size: 1832 bytes --]
From 5da5a1e7322dc00f8900724060de3d5fe2a826e0 Mon Sep 17 00:00:00 2001
From: Michael Rohleder <mike@rohleder.de>
Date: Tue, 2 Jun 2020 08:20:18 +0200
Subject: [PATCH] gnu: Add emacs-erc-status-sidebar.
* gnu/packages/emacs-xyz.scm (emacs-erc-status-sidebar): New variable.
---
gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b64a964916..76c67d859e 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -3280,6 +3280,31 @@ appropriate console.")
IRC bouncer with ERC.")
(license license:expat)))
+(define-public emacs-erc-status-sidebar
+ (let ((commit "ea4189a1dbfe60117359c36e681ad7c389e2968c")
+ (revision "1"))
+ (package
+ (name "emacs-erc-status-sidebar")
+ (version (git-version "0.1" revision commit))
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/drewbarbs/erc-status-sidebar.git")
+ (commit commit)))
+ (sha256
+ (base32 "1hwlhzgx03z8891sblz56zdp8zj0izh72kxykgcnz5rrkyc3vfi3"))))
+ (build-system emacs-build-system)
+ (propagated-inputs `(("emacs-seq" ,emacs-seq)))
+ (home-page "https://github.com/drewbarbs/erc-status-sidebar")
+ (synopsis "A hexchat-like activity overview for ERC channels")
+ (description
+ "This package is provides a hexchat-like status bar for joined
+channels in ERC. It relies on the `erc-track' module, and displays
+all the same information erc-track does in the mode line, but in an
+alternative format.")
+ (license license:expat))))
+
(define-public emacs-shut-up
(package
(name "emacs-shut-up")
--
2.26.2
[-- Attachment #1.3: Type: text/plain, Size: 184 bytes --]
--
In most countries selling harmful things like drugs is punishable.
Then howcome people can sell Microsoft software and go unpunished?
(By hasku@rost.abo.fi, Hasse Skrifvars)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#41566: [PATCH] gnu: Add emacs-erc-status-sidebar.
2020-06-02 6:27 ` Michael Rohleder
@ 2020-06-14 21:05 ` Ludovic Courtès
0 siblings, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2020-06-14 21:05 UTC (permalink / raw)
To: Michael Rohleder; +Cc: 41566-done, Marius Bakke
Hi Michael,
Michael Rohleder <mike@rohleder.de> skribis:
> From 5da5a1e7322dc00f8900724060de3d5fe2a826e0 Mon Sep 17 00:00:00 2001
> From: Michael Rohleder <mike@rohleder.de>
> Date: Tue, 2 Jun 2020 08:20:18 +0200
> Subject: [PATCH] gnu: Add emacs-erc-status-sidebar.
>
> * gnu/packages/emacs-xyz.scm (emacs-erc-status-sidebar): New variable.
> ---
> gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
This seems to address what Marius commented on so I went ahead and
applied it. I followed up with small changes to placate ‘guix lint’.
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-14 21:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-27 17:34 [bug#41566] [PATCH] gnu: Add emacs-erc-status-sidebar Michael Rohleder
2020-05-30 14:00 ` Marius Bakke
2020-06-02 6:27 ` Michael Rohleder
2020-06-14 21:05 ` bug#41566: " Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).