From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id UP/0KUcq714xIgAA0tVLHw (envelope-from ) for ; Sun, 21 Jun 2020 09:37:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 4NuRJUcq717IYwAAbx9fmQ (envelope-from ) for ; Sun, 21 Jun 2020 09:37:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1B6719401AE for ; Sun, 21 Jun 2020 09:37:11 +0000 (UTC) Received: from localhost ([::1]:59210 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jmwPW-0007oH-13 for larch@yhetil.org; Sun, 21 Jun 2020 05:37:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49694) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jmwPO-0007nM-RK for guix-patches@gnu.org; Sun, 21 Jun 2020 05:37:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47700) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jmwPO-0002Ek-IE for guix-patches@gnu.org; Sun, 21 Jun 2020 05:37:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jmwPO-0008LY-Ek for guix-patches@gnu.org; Sun, 21 Jun 2020 05:37:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41820] [PATCH] file-systems: Add record type for a file system device. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 21 Jun 2020 09:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41820 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Stefan Cc: Danny Milosavljevic , 41820@debbugs.gnu.org Received: via spool by 41820-submit@debbugs.gnu.org id=B41820.159273218132032 (code B ref 41820); Sun, 21 Jun 2020 09:37:02 +0000 Received: (at 41820) by debbugs.gnu.org; 21 Jun 2020 09:36:21 +0000 Received: from localhost ([127.0.0.1]:59246 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmwOj-0008Ka-Hn for submit@debbugs.gnu.org; Sun, 21 Jun 2020 05:36:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35222) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmwOf-0008KH-QQ for 41820@debbugs.gnu.org; Sun, 21 Jun 2020 05:36:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51396) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jmwOY-0001zz-MM; Sun, 21 Jun 2020 05:36:10 -0400 Received: from [2a01:e0a:fa:a50:34a1:eac3:9800:4a6e] (port=53124 helo=meru) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jmwOO-0008Aw-It; Sun, 21 Jun 2020 05:36:10 -0400 From: Mathieu Othacehe References: Date: Sun, 21 Jun 2020 11:35:59 +0200 In-Reply-To: (Stefan's message of "Fri, 12 Jun 2020 01:37:06 +0200") Message-ID: <87tuz44v7k.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: hV7ql1seF1s+ Hello Stefan, Thanks a lot for this patch, overall it look nice! Without going into details here are a few remarks: * As you probably noticed the bootloading & system part of Guix is moving a lot recently. This patch does not apply on master, so it would be nice if you could rebase it and pass "--base=auto" option to "git format-patch" so that it's easier to apply it. * It would be nice to have tests for this functionality. There's already a (gnu tests nfs) module, testing the NFS service. Maybe you could add a test case of a marionette booting from a local NFS share. * Finally, now that file-system "device" field can be a label, a UUID, a "/dev" node and an "nfs-share", it makes me think that we could need a new layer of abstraction here, but this can come later and I need to think more about it. Thanks, Mathieu