From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id GGPwJVkS+16rUAAA0tVLHw (envelope-from ) for ; Tue, 30 Jun 2020 10:22:17 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id kL63IVkS+16JKgAAbx9fmQ (envelope-from ) for ; Tue, 30 Jun 2020 10:22:17 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F166A940630 for ; Tue, 30 Jun 2020 10:22:16 +0000 (UTC) Received: from localhost ([::1]:44566 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jqDP4-0006TH-2N for larch@yhetil.org; Tue, 30 Jun 2020 06:22:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59170) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jqD9P-0006Du-1Q for guix-patches@gnu.org; Tue, 30 Jun 2020 06:06:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38662) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jqD9O-00058h-Lp for guix-patches@gnu.org; Tue, 30 Jun 2020 06:06:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jqD9O-0002Yw-H0 for guix-patches@gnu.org; Tue, 30 Jun 2020 06:06:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42067] [PATCH] gnu: darktable: Add optional dependencies. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 30 Jun 2020 10:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42067 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vinicius Monego Cc: 42067-done@debbugs.gnu.org Received: via spool by 42067-done@debbugs.gnu.org id=D42067.15935115169789 (code D ref 42067); Tue, 30 Jun 2020 10:06:02 +0000 Received: (at 42067-done) by debbugs.gnu.org; 30 Jun 2020 10:05:16 +0000 Received: from localhost ([127.0.0.1]:50208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jqD8d-0002Xp-U8 for submit@debbugs.gnu.org; Tue, 30 Jun 2020 06:05:16 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jqD8b-0002Xc-Rd for 42067-done@debbugs.gnu.org; Tue, 30 Jun 2020 06:05:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48138) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jqD8W-0004tT-KJ; Tue, 30 Jun 2020 06:05:08 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=45200 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jqD8W-0000Uy-02; Tue, 30 Jun 2020 06:05:08 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200626203904.16748-1-monego@posteo.net> <87eepxa5zu.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 13 Messidor an 228 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 30 Jun 2020 12:05:06 +0200 In-Reply-To: (Vinicius Monego's message of "Mon, 29 Jun 2020 23:42:06 -0300") Message-ID: <87tuys7tt9.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: n/E66Yf8iVbO Hi Vinicius, Vinicius Monego skribis: >> BTW, why are we building with Clang? >>=20 > > This was briefly discussed in the version update thread (2020- > 06/msg00651). To be more descriptive: Oh sorry, I have overlooked that. > DT 3+ requires GCC/Clang 8+ and will fail to build with the default GCC > 7.5.0. We have to load a newer version of GCC, or use Clang. Marius > attempted to build it with gcc-9 and "ran into other problems" although > I have succesfully built DT3 with the same compiler and version a while > ago. > > Meanwhile, DT's CMakeLists.txt checks for LLVM to enable "test- > compilation of OpenCL programs". If LLVM is not found, this test- > compilation is skipped. If LLVM is found, it checks for Clang, and the > required opencl header is located inside Clang's directory. Because we > "have to have" Clang this way, it made more sense to me to compile with > it. > > Anyways, OpenCL is optional. To build with GCC only, we would have to > load the gcc module and skip the test-compilation. It may be possible > to use both gcc and clang, but that would add redundancy. What=E2=80=99s the =E2=80=9Ctest-compilation of OpenCL programs=E2=80=9D? = Are we just talking about the test suite? Either way, I guess my main points are (1) it=E2=80=99d be nice to add a co= mment on why we=E2=80=99re using Clang, and (2) if we can use GCC instead, that s= hould be our default choice. I=E2=80=99m not saying we should address this right away, but we should keep it in mind. Thanks, Ludo=E2=80=99.