unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Vinicius Monego <monego@posteo.net>
Cc: 42067-done@debbugs.gnu.org
Subject: [bug#42067] [PATCH] gnu: darktable: Add optional dependencies.
Date: Tue, 30 Jun 2020 12:05:06 +0200	[thread overview]
Message-ID: <87tuys7tt9.fsf@gnu.org> (raw)
In-Reply-To: <f51dc393e5c6450534f3c970784765fa23850034.camel@posteo.net> (Vinicius Monego's message of "Mon, 29 Jun 2020 23:42:06 -0300")

Hi Vinicius,

Vinicius Monego <monego@posteo.net> skribis:

>> BTW, why are we building with Clang?
>> 
>
> This was briefly discussed in the version update thread (2020-
> 06/msg00651). To be more descriptive:

Oh sorry, I have overlooked that.

> DT 3+ requires GCC/Clang 8+ and will fail to build with the default GCC
> 7.5.0. We have to load a newer version of GCC, or use Clang. Marius
> attempted to build it with gcc-9 and "ran into other problems" although
> I have succesfully built DT3 with the same compiler and version a while
> ago.
>
> Meanwhile, DT's CMakeLists.txt checks for LLVM to enable "test-
> compilation of OpenCL programs". If LLVM is not found, this test-
> compilation is skipped. If LLVM is found, it checks for Clang, and the
> required opencl header is located inside Clang's directory. Because we
> "have to have" Clang this way, it made more sense to me to compile with
> it.
>
> Anyways, OpenCL is optional. To build with GCC only, we would have to
> load the gcc module and skip the test-compilation. It may be possible
> to use both gcc and clang, but that would add redundancy.

What’s the “test-compilation of OpenCL programs”?  Are we just talking
about the test suite?

Either way, I guess my main points are (1) it’d be nice to add a comment
on why we’re using Clang, and (2) if we can use GCC instead, that should
be our default choice.  I’m not saying we should address this right
away, but we should keep it in mind.

Thanks,
Ludo’.




      reply	other threads:[~2020-06-30 10:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-26 20:39 [bug#42067] [PATCH] gnu: darktable: Add optional dependencies Vinicius Monego
2020-06-29 21:59 ` bug#42067: " Ludovic Courtès
2020-06-30  2:42   ` [bug#42067] " Vinicius Monego
2020-06-30 10:05     ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tuys7tt9.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=42067-done@debbugs.gnu.org \
    --cc=monego@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).