From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id ERyBEz0gTF80IQAA0tVLHw (envelope-from ) for ; Sun, 30 Aug 2020 21:55:09 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id YK6wDj0gTF8acQAAbx9fmQ (envelope-from ) for ; Sun, 30 Aug 2020 21:55:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C7A8094053E for ; Sun, 30 Aug 2020 21:55:08 +0000 (UTC) Received: from localhost ([::1]:48428 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCVI3-0008T3-Je for larch@yhetil.org; Sun, 30 Aug 2020 17:55:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56930) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kCVHy-0008Sp-Gv for guix-patches@gnu.org; Sun, 30 Aug 2020 17:55:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39362) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kCVHy-0003JL-7c for guix-patches@gnu.org; Sun, 30 Aug 2020 17:55:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kCVHy-0008W4-6i for guix-patches@gnu.org; Sun, 30 Aug 2020 17:55:02 -0400 Subject: bug#43034: [PATCH] environment: Set USER and LOGNAME in container Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Sun, 30 Aug 2020 21:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 43034 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Lars-Dominik Braun Cc: 43034-done@debbugs.gnu.org Mail-Followup-To: 43034@debbugs.gnu.org, ludo@gnu.org, ldb@leibniz-psychology.org Received: via spool by 43034-done@debbugs.gnu.org id=D43034.159882448132704 (code D ref 43034); Sun, 30 Aug 2020 21:55:02 +0000 Received: (at 43034-done) by debbugs.gnu.org; 30 Aug 2020 21:54:41 +0000 Received: from localhost ([127.0.0.1]:50907 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCVHd-0008VO-Gh for submit@debbugs.gnu.org; Sun, 30 Aug 2020 17:54:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46754) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCVHW-0008V7-EY for 43034-done@debbugs.gnu.org; Sun, 30 Aug 2020 17:54:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45709) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCVHQ-0003Ge-VW; Sun, 30 Aug 2020 17:54:28 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=44076 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kCVHQ-0001wM-IN; Sun, 30 Aug 2020 17:54:28 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200825085824.GA3150@zpidnp36> Date: Sun, 30 Aug 2020 23:54:26 +0200 In-Reply-To: <20200825085824.GA3150@zpidnp36> (Lars-Dominik Braun's message of "Tue, 25 Aug 2020 10:58:24 +0200") Message-ID: <87tuwjg5pp.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: DAMCN7pKup9F Hi Lars, Lars-Dominik Braun skribis: > From 516fecf81c980a020906533cd5135c6a7603a0a1 Mon Sep 17 00:00:00 2001 > From: Lars-Dominik Braun > Date: Tue, 25 Aug 2020 10:52:21 +0200 > Subject: [PATCH] environment: Set USER and LOGNAME in container > > * guix/scripts/environment.scm (launch-environment/container): Set > username environment variables. Applied! > ;; The same variables as in Nix's 'build.cc'. > '("TMPDIR" "TEMPDIR" "TMP" "TEMP")) >=20=20 > + ;; Some programs expect USER and/or LOGNAME to be set. > + (setenv "LOGNAME" logname) > + (setenv "USER" logname) I was hesitant because so far we were more or less following the set of variables exported by the daemon (see nix/libstore/build.cc), but there were already exceptions (HOME, GUIX_ENVIRONMENT, PS1), and I think making =E2=80=98guix environment -C=E2=80=99 more convenient is what matter= s. Thanks, Ludo=E2=80=99.