unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Vinicius Monego <monego@posteo.net>
Cc: 42807-done@debbugs.gnu.org
Subject: bug#42807: [PATCH v2 1/2] gnu: darktable: Update to 3.2.1.
Date: Fri, 04 Sep 2020 11:06:14 +0200	[thread overview]
Message-ID: <87tuwdvrll.fsf@gnu.org> (raw)
In-Reply-To: <20200813145916.38243-1-monego@posteo.net> (Vinicius Monego's message of "Thu, 13 Aug 2020 11:59:15 -0300")

Hi,

Vinicius Monego <monego@posteo.net> skribis:

> * gnu/packages/photo.scm (darktable): Update to 3.2.1.

[...]

> * gnu/packages/photo.scm (darktable)[inputs]: Add libavif, ocl-icd.
> [arguments]: Set LD_LIBRARY_PATH for OpenCL.
> [supported-systems]: Remove i686 which is not supported anymore.

Thanks, applied!

> +             (wrap-program (string-append (assoc-ref outputs "out")
> +                                          "/bin/darktable")
> +               ;; For GtkFileChooserDialog.
> +               `("GSETTINGS_SCHEMA_DIR" =
> +                 (,(string-append (assoc-ref inputs "gtk+")
> +                                  "/share/glib-2.0/schemas")))
> +               ;; For libOpenCL.so.
> +               `("LD_LIBRARY_PATH" =
> +                 (,(string-append (assoc-ref inputs "ocl-icd")
> +                                  "/lib"))))

It’s weird that LD_LIBRARY_PATH needs to be specified here.  Isn’t the
binary already linked against libOpenCL?  If so, it should have it in
as NEEDed and its its RUNPATH, no?

Ludo’.




  parent reply	other threads:[~2020-09-04  9:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-10 23:23 [bug#42807] [PATCH 1/2] gnu: darktable: Update to 3.2.1 Vinicius Monego
2020-08-10 23:25 ` [bug#42807] [PATCH 2/2] gnu: darktable: Add dependency on libavif, ocl-icd Vinicius Monego
2020-08-10 23:31 ` [bug#42807] [PATCH 1/2] gnu: darktable: Update to 3.2.1 Brett Gilio
2020-08-11  1:12   ` Vinicius Monego
2020-08-12  1:01     ` Vinicius Monego
2020-09-04  9:06       ` Ludovic Courtès
2020-08-13 14:59 ` [bug#42807] [PATCH v2 " Vinicius Monego
2020-08-13 14:59   ` [bug#42807] [PATCH v2 2/2] gnu: darktable: Add dependency on libavif, ocl-icd Vinicius Monego
2020-09-04  9:06   ` Ludovic Courtès [this message]
2020-09-05 18:17     ` [bug#42807] [PATCH v2 1/2] gnu: darktable: Update to 3.2.1 Vinicius Monego

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tuwdvrll.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=42807-done@debbugs.gnu.org \
    --cc=monego@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).