From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 0BX7N8wnbV84dAAA0tVLHw (envelope-from ) for ; Thu, 24 Sep 2020 23:12:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id GDHOM8wnbV9xUQAAbx9fmQ (envelope-from ) for ; Thu, 24 Sep 2020 23:12:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4CA0B9406B7 for ; Thu, 24 Sep 2020 23:12:12 +0000 (UTC) Received: from localhost ([::1]:39422 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLaPL-0001by-AE for larch@yhetil.org; Thu, 24 Sep 2020 19:12:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36156) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLaPC-0001aZ-KZ for guix-patches@gnu.org; Thu, 24 Sep 2020 19:12:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58681) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kLaPC-00080P-Au for guix-patches@gnu.org; Thu, 24 Sep 2020 19:12:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kLaPC-0000FV-2g for guix-patches@gnu.org; Thu, 24 Sep 2020 19:12:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43591] [PATCH core-updates] gnu: glibc-final: Catch all cases of a glibc user not requesting 64-bit offsets and then using readdir. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 24 Sep 2020 23:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43591 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Danny Milosavljevic Cc: 43591@debbugs.gnu.org Received: via spool by 43591-submit@debbugs.gnu.org id=B43591.1600989093919 (code B ref 43591); Thu, 24 Sep 2020 23:12:02 +0000 Received: (at 43591) by debbugs.gnu.org; 24 Sep 2020 23:11:33 +0000 Received: from localhost ([127.0.0.1]:41993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLaOj-0000El-Ct for submit@debbugs.gnu.org; Thu, 24 Sep 2020 19:11:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLaOe-0000EV-OI for 43591@debbugs.gnu.org; Thu, 24 Sep 2020 19:11:32 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42922) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLaOY-0007yp-RZ; Thu, 24 Sep 2020 19:11:22 -0400 Received: from ti0006q161-3115.bb.online.no ([88.95.106.80]:42864 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kLaOX-0003cp-DI; Thu, 24 Sep 2020 19:11:22 -0400 From: Marius Bakke In-Reply-To: <20200924222711.2f22281a@scratchpost.org> References: <20200924141211.21649-1-dannym@scratchpost.org> <87363759at.fsf@gnu.org> <20200924222711.2f22281a@scratchpost.org> Date: Fri, 25 Sep 2020 01:11:18 +0200 Message-ID: <87tuvm4vop.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -3.61 X-TUID: XxZ60AJH9Bmh --=-=-= Content-Type: text/plain Danny Milosavljevic writes: > Hi Marius, > > On Thu, 24 Sep 2020 20:17:14 +0200 > Marius Bakke wrote: > >> As mentioned in that issue, and which this patch states on no uncertain >> terms, a workaround is to use -D_FILE_OFFSET_BITS=64 on 32-bit platforms. > > Yeah. The problem is how to find all those places where we need to add it, > and how to keep finding them as we maintain stuff (read: as upstream changes > stuff). > >> Won't this break _everything_ that uses readdir() without 64-bit >> offsets? > > That's the goal of that patch. Because it won't work at runtime anyway, when > run on a guix x86_64 build machine, building for ARM (which is the usual way > we build stuff for ARM). Why is this not an issue with i686 on x86_64 kernels? Or armhf on AArch64? This problem only manifests when using QEMUs syscall emulation, right? > Maybe we can find out whether dirent.h is #included for compiling for one of > the main Guix platforms (I prefer this latter solution, if possible). > > It's either that or we stop qemu transparent emulation on the build farm, > because the result isn't reliable. This time it was "caught" because of > an overabundance of caution on behalf of the glibc people. We won't be > so lucky next time. Arguably running code for foreign architectures through QEMU binfmt is something of a hack. Mandating that every package *must* be patched to support it seems user-hostile. I'm more in favor of dropping it on the build farm, or just keep fixing things on a per-package basis. A less user-hostile solution could perhaps be to (setenv "CFLAGS" "-D_FILE_OFFSET_BITS=64") on 32-bit architectures in gnu-build-system. Not sure whether that could cause any adverse effects. But again, I don't like the idea of optimizing for QEMUs user-mode emulation. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl9tJ5YACgkQoqBt8qM6 VPrAYQgAnI3/88H0lcjkCiUbehr3AmthzPh1jGgIFAxv0XL1+YoCqtsHWCScxMzF IsNCSMo2cYGplTDbQNyb+vNy1nQrIZecGm2mE8G5kPKir/ofSb05pQckCy7xDONt /KMOAByMtQEueIbemyr+PdXi5jpTR+pG/Ef2ZjvBDLO7Fl9ZlYgiQx9V6vIjaikI OWYRzanDMZkLB97DoM6lAAdtSMeSxbDj2n64rbxTdlVBnnrdagereSwWVpsNCeF4 k/z1isflAZxAiPWatsHoOmNPIxqGuPuytrNleHha4xVBEZn7ombTHeRI3qyYScWD K0owVdK6pO+PUxiG2hzLq5dPmRI2LQ== =aEhD -----END PGP SIGNATURE----- --=-=-=--