From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id eP29DRpRdF+BZgAA0tVLHw (envelope-from ) for ; Wed, 30 Sep 2020 09:34:18 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 4AygCRpRdF/dCAAA1q6Kng (envelope-from ) for ; Wed, 30 Sep 2020 09:34:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A35789401D0 for ; Wed, 30 Sep 2020 09:34:17 +0000 (UTC) Received: from localhost ([::1]:40224 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNYV6-00041b-I4 for larch@yhetil.org; Wed, 30 Sep 2020 05:34:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35008) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNYUs-00041N-1A for guix-patches@gnu.org; Wed, 30 Sep 2020 05:34:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46688) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kNYUr-0002zR-Nq for guix-patches@gnu.org; Wed, 30 Sep 2020 05:34:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kNYUr-0006UR-Lw for guix-patches@gnu.org; Wed, 30 Sep 2020 05:34:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43591] [PATCH core-updates] gnu: glibc-final: Catch all cases of a glibc user not requesting 64-bit offsets and then using readdir. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 30 Sep 2020 09:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43591 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Danny Milosavljevic Cc: 43591@debbugs.gnu.org, Marius Bakke Received: via spool by 43591-submit@debbugs.gnu.org id=B43591.160145839224895 (code B ref 43591); Wed, 30 Sep 2020 09:34:01 +0000 Received: (at 43591) by debbugs.gnu.org; 30 Sep 2020 09:33:12 +0000 Received: from localhost ([127.0.0.1]:58234 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNYU4-0006TR-38 for submit@debbugs.gnu.org; Wed, 30 Sep 2020 05:33:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56102) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNYU2-0006TF-21 for 43591@debbugs.gnu.org; Wed, 30 Sep 2020 05:33:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58764) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNYTu-0002ua-QK; Wed, 30 Sep 2020 05:33:02 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=58754 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kNYTr-0003Gb-Dd; Wed, 30 Sep 2020 05:33:00 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200924141211.21649-1-dannym@scratchpost.org> <87363759at.fsf@gnu.org> <20200924222711.2f22281a@scratchpost.org> <87tuvm4vop.fsf@gnu.org> <87h7rg4879.fsf@gnu.org> <20200930000934.6812b7c8@scratchpost.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 9 =?UTF-8?Q?Vend=C3=A9miaire?= an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Wed, 30 Sep 2020 11:32:58 +0200 In-Reply-To: <20200930000934.6812b7c8@scratchpost.org> (Danny Milosavljevic's message of "Wed, 30 Sep 2020 00:09:34 +0200") Message-ID: <87tuvf1uet.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: shQhKCOEX4EX Hi, Danny Milosavljevic skribis: > On Tue, 29 Sep 2020 22:52:10 +0200 > Ludovic Court=C3=A8s wrote: > >> Marius Bakke skribis: >>=20 >> > Arguably running code for foreign architectures through QEMU binfmt is >> > something of a hack. Mandating that every package *must* be patched to >> > support it seems user-hostile. I'm more in favor of dropping it on the >> > build farm, or just keep fixing things on a per-package basis.=20=20 >>=20 >> I=E2=80=99m fine with dropping things on the build farm; it=E2=80=99s ju= st about >> modifying machines-for-berlin.scm in maintenance.git. Any takers? :-) > > I don't know what "dropping things on the build farm" means in this conte= xt. > Dropping what exactly? Dropping emulated builds, or at least 32-bit emulated builds. We just need to remove build machines from the file above. >> The above would override the default CFLAGS in Autoconf-generated >> configure scripts (which is =E2=80=9C-O2 -g=E2=80=9D).=20=20 > > That is correct. I'm currently working on v2 (testing a patchset already) > and I totally forgot to add "-g -O2" the first time around. Also, glibc > itself must NOT have -D_FILE_OFFSET_BITS=3D64 (it makes sense not to, too= ). > >>So we=E2=80=99d have to be cautious. >> But I think a global solution is preferable to adding >> -D_FILE_OFFSET_BITS=3D64 to tens of packages. > > I agree. > > I still would like to see what actually changes--and I think with > guix-data-services it should actually be possible to compare derivations > before-and-after and find out which derivations of which packages changed > at all because of the global -D_FILE_OFFSET_BITS=3D64. I'd like some help > using guix-data-services to find that out. Otherwise a risk estimation > cannot be done. A change in gnu-build-system would change all the derivations. I don=E2=80= =99t think the Data Service can help us here. > Technically, if a package used direct assembly offsets (for some unfathom= able > reason), it could have an undetectable problem with the size change of of= f_t > (and also struct dirent). So examining the source code of the most essen= tial > packages manually is still good. That's what I did in > branch wip-file-offsets-64. Yeah. > I'm in the process of testing a patchset that globally sets > > CFLAGS=3D"-D_FILE_OFFSET_BITS=3D64 -g -O2" > > instead. OK. > That alone is not enough since there are a lot of non-autotools projects = that > just ignore the environment variable entirely--not to mention languages o= ther > than C. Yeah=E2=80=A6 I have mixed feelings: fixing packages one by one doesn=E2=80=99t sound gre= at, but OTOH setting the =E2=80=98CFLAGS=E2=80=99 environment variable globally= can have unexpected side effects in some cases (overriding package-specific CFLAGS) and zero effects in other cases (for non-Autoconf packages or badly-written =E2=80=98configure.ac=E2=80=99 files), both of which would be= hard to detect. ~~~ If we take a step back: what=E2=80=99s the problem? We have a problem with emulated 32-bit architectures on 64-bit architectures. But that=E2=80=99s = OK, we can stop those emulations for now. Then we have packages that do not support large files; it=E2=80=99s not great but evidently we can live with = it. :-) Ideally, we=E2=80=99d report it upstream when we encounter it. So to me that hints at targeted fixes: fixing key packages like CMake (roughly what you already did) where lack of large file support can be problematic. Thoughts? Ludo=E2=80=99.