From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id CC6BKoySjV/mcwAA0tVLHw (envelope-from ) for ; Mon, 19 Oct 2020 13:20:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 4PxHJoySjV/UGwAAbx9fmQ (envelope-from ) for ; Mon, 19 Oct 2020 13:20:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2602494023B for ; Mon, 19 Oct 2020 13:20:12 +0000 (UTC) Received: from localhost ([::1]:33822 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUV58-0005if-Ki for larch@yhetil.org; Mon, 19 Oct 2020 09:20:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41272) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUV52-0005iZ-EG for guix-patches@gnu.org; Mon, 19 Oct 2020 09:20:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56918) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kUV50-000471-7D for guix-patches@gnu.org; Mon, 19 Oct 2020 09:20:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kUV50-0005Df-2L for guix-patches@gnu.org; Mon, 19 Oct 2020 09:20:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#44075] [PATCH] gnu: Add make-glibc-locales-collection. Resent-From: Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 19 Oct 2020 13:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44075 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: 44075@debbugs.gnu.org Received: via spool by 44075-submit@debbugs.gnu.org id=B44075.160311354919975 (code B ref 44075); Mon, 19 Oct 2020 13:20:02 +0000 Received: (at 44075) by debbugs.gnu.org; 19 Oct 2020 13:19:09 +0000 Received: from localhost ([127.0.0.1]:40231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUV49-0005C6-GB for submit@debbugs.gnu.org; Mon, 19 Oct 2020 09:19:09 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:34375) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUV46-0005BX-Eg for 44075@debbugs.gnu.org; Mon, 19 Oct 2020 09:19:07 -0400 Received: by mail-wr1-f68.google.com with SMTP id i1so11428405wro.1 for <44075@debbugs.gnu.org>; Mon, 19 Oct 2020 06:19:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=LDPSti9WyLl7H2ORU/Pv+HgeK2bf7hJrqbFNNqqPHIE=; b=FGA56l3pl4j77/6FNm5g9M6vuq+22EKPraOFMqmFjblJOjnxfVNyiasLzRPSkHwVgq nb5SHgBtnf/Y17J39EPU5n33JmhmyKUN8BqHnW04RarX/xq6VtMEtijbE6CX87B1h6vC DsGk7nyL1bdj8u4tZudrFFqg5ZpTpoU0jwvULw4vNQUPr30ObKYg39ieAKL/A+3cVB8O IWftQPZK6TMPPYu16shrPCPbw796mibFGYIHX4lMQVZRYZ/3yQUpCRaCAo1sKt31vqxN /yIhMmNNVwum+3qDJ1GB5158MHlyfxbn+RO/gRGcQqhJDMn9NrbGWM2QukDGijx5JIsl 2ecw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=LDPSti9WyLl7H2ORU/Pv+HgeK2bf7hJrqbFNNqqPHIE=; b=qBseB+SEB2avVPjbx4sTLmEDXnXN0gnNwVJW4hLs47y6c38SnJpM6agkLoGvc4eadZ mCx8JCqfz7H77xsTKIcsRmnVkMtryrYkg+P/fvMaUf5qG/amciHlPyKcDLmQ8j+IB5IE Czc10TqaKIsGq2S9XGN+pC4WNSpUdxgn1hMY3tuksAHavEnSdsQ1O9d22K08aNQJBvxr NHY8wwmIuWXvy7xVRnMVI8n7eR76fYX+UWMwpKMnBvZs+kDake63JWKdeHUVpYRjTnlu 0inku23aLMASjpSc36+n7Dd0TEyJA3CrvQq7dtcZcCCL3tmm129o5iqAGMY24rMZysmw DT6w== X-Gm-Message-State: AOAM530TogC4jLc+4tlb01iTHllPOpaXYOxECqN6ZEFcf4AbRMXoW+vd QMm3Oa0sur1c9F7DcYqBUL5HMZ6iy8OjBgJi X-Google-Smtp-Source: ABdhPJx5anCdut6R1Uvo8KmBz92K3h1jex9k1cy6J1IK7vsry/UaqH/Zm7P1Xt0wpYFJ0kCArMab2Q== X-Received: by 2002:a5d:4010:: with SMTP id n16mr18902249wrp.97.1603113540302; Mon, 19 Oct 2020 06:19:00 -0700 (PDT) Received: from unfall (218.139.134.37.dynamic.jazztel.es. [37.134.139.218]) by smtp.gmail.com with ESMTPSA id p9sm9383wma.12.2020.10.19.06.18.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2020 06:18:59 -0700 (PDT) From: Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas References: <20201019064739.4736-1-efraim@flashner.co.il> Date: Mon, 19 Oct 2020 15:17:54 +0200 In-Reply-To: <20201019064739.4736-1-efraim@flashner.co.il> (Efraim Flashner's message of "Mon, 19 Oct 2020 09:47:39 +0300") Message-ID: <87tuuqnym5.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -0.8 (/) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=FGA56l3p; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -2.01 X-TUID: zLEG703T/tEt --=-=-= Content-Type: text/plain Hi Efraim, I've been taking a look into your patch. One issue are the comments about utf8 and UTF-8, as the issue is already explained in make-glibc[-utf8]-locales. Other point is: Efraim Flashner writes: > +(define* (make-glibc-locales-collection > + glibc > + #:optional (locales > + '(list "en_US.utf8" "en_US.ISO-8859-1"))) > (... Removed for clarity ...) > + ,locales) I would have used list there like (list ,@locales) or '(,@locales), this looks a bit odd to my eyes at least. I'd expect this kind of calling code: (let ((locales '("de_CH.utf8" ... "de_DE.utf8")) (my-glibc ...)) (make-glibc-locales-collection myglibc locales)) Enforcing an extra quotation for no real reason on the calling site, as strings are self-evaluating objects, and the use of the symbol list, whose meaning depends on other context of execution, doesn't seem necessary. Even worse, my example would raise an error as "de_CH.utf8" is not a procedure. What do you think about replacing make-glibc-utf8-locales with a call of the new function (using that code) ensuring that the generated derivation stays the same for that case (i.e. it's optimized for the UTF-8 case)? Happy hacking! Miguel --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAEBCgAdFiEEiIeExBRZrMuD5+hMY0xuiXn6vsIFAl+NkgIACgkQY0xuiXn6 vsIPmgv7BmwzC3IaxvbOLJbgKF5MYvOFJoZHoUQuKsJAT/6UwJZ3J9H6dZ1kNJuO Sgm/pKuCmrTMDqOIIp5SrYulGjBnjP4vTsO8bwBEFyJ7y5cWREXDgoOp4J9vQXyH S4Yjy72GwNO+WBK8S1ZyquNnLr0vuA1kuNGoaaTw8ACtirlOAQoLKTmSsLZNZIk1 fJQUOfz08gUwg0Y/AMzTgDGhflQA+rHMDC/Qs1uwnmB64xhxfHC2jemC8ZttklqB edhc2Hw4AJAKoBLwnANM5d/q73vief2FL7Y3tZiP5+V/qVRVaZOhGnSQyCQd9cnF kB9dlqLmJwC47b78oOQxK/fDicKbhoi7XJHkkRrRB/6Adf8LfJVJQ8T1iLgCu8zw rT+1eTd2FkOyNYRV4j8FVATjUB/wabDLB23BgeOpiAaLMFj7A8QEgLV0WRlTJoBK aqCD/zXVGmd/SDVX1jxxKmLJ7+0veD5dXgYoCoecBBWibjBhf5j07maphuttXIsq 9dNtpxXo =o6XK -----END PGP SIGNATURE----- --=-=-=--