From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 8NoUNCYqwF/JFQAA0tVLHw (envelope-from ) for ; Thu, 26 Nov 2020 22:20:22 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id kOHvLyYqwF8XYgAAbx9fmQ (envelope-from ) for ; Thu, 26 Nov 2020 22:20:22 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 63477940485 for ; Thu, 26 Nov 2020 22:20:22 +0000 (UTC) Received: from localhost ([::1]:41428 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiPcj-0003bf-CQ for larch@yhetil.org; Thu, 26 Nov 2020 17:20:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41262) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiPcQ-0003Zr-Rd for guix-patches@gnu.org; Thu, 26 Nov 2020 17:20:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:59802) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kiPcQ-0007GG-JP for guix-patches@gnu.org; Thu, 26 Nov 2020 17:20:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kiPcQ-00082i-En for guix-patches@gnu.org; Thu, 26 Nov 2020 17:20:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44722] [PATCH] gnu: web: add uriparser Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 26 Nov 2020 22:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44722 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: lspangler Cc: 44722@debbugs.gnu.org Received: via spool by 44722-submit@debbugs.gnu.org id=B44722.160642916730848 (code B ref 44722); Thu, 26 Nov 2020 22:20:02 +0000 Received: (at 44722) by debbugs.gnu.org; 26 Nov 2020 22:19:27 +0000 Received: from localhost ([127.0.0.1]:43115 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kiPbr-00081U-3M for submit@debbugs.gnu.org; Thu, 26 Nov 2020 17:19:27 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51202) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kiPbp-00081B-Lp for 44722@debbugs.gnu.org; Thu, 26 Nov 2020 17:19:26 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51919) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiPbj-00072a-HO; Thu, 26 Nov 2020 17:19:19 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=45448 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kiPbj-0005hT-1t; Thu, 26 Nov 2020 17:19:19 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <61GMcRudrqz0j9_UV7ajK_jffCV3On0vlQzjLrU6Ly3fS-n5F9aQvtH41aL2clXwcIpH0xi3B8iEL9iiCxjFvv_fUMet1_J95kMaYn0hnQ4=@protonmail.com> Date: Thu, 26 Nov 2020 23:19:17 +0100 In-Reply-To: <61GMcRudrqz0j9_UV7ajK_jffCV3On0vlQzjLrU6Ly3fS-n5F9aQvtH41aL2clXwcIpH0xi3B8iEL9iiCxjFvv_fUMet1_J95kMaYn0hnQ4=@protonmail.com> (lspangler@protonmail.com's message of "Wed, 18 Nov 2020 13:48:42 +0000") Message-ID: <87tutbzrq2.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.76 X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-TUID: DfU+j/LA3LY7 Hello Lane, lspangler skribis: > From 1141a871635f048147faf022a9b649d6f8553080 Mon Sep 17 00:00:00 2001 > From: Lane Spangler > Date: Tue, 17 Nov 2020 17:50:06 +0100 > Subject: [PATCH] gnu: web: add uriparser > > --- > gnu/packages/web.scm | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) It looks like the patch was mangled on the way. Could you send it as an attachment or using =E2=80=98git send-email=E2=80=99? Some minor issues below: > +(define-public uriparser > + (let [(commit "9e1fba08c231f1990fdee13545ab3a0ac804bd3c") > + (revision "1")] Normally we pick upstream releases. If there=E2=80=99s a good reason to pi= ck this commit rather than the latest release, could you please add a comment above it explaining why? Nitpick: Please use only regular parentheses, for consistency. > + (synopsis "Strictly RFC 3986 compliant URI parsing and handling > + library written in C89") What about making it shorter: =E2=80=9CRFC 3986 compliant URI parsing and handling library=E2=80=9D? > + (description "uriparser is a strictly RFC 3986 compliant URI > + parsing and handling library written in C89 (\"ANSI C\"). > +uriparser is cross-platform, fast, and supports Unicode") I think you can omit =E2=80=9Ccross-platform=E2=80=9D since that=E2=80=99s = not relevant from a Guix user standpoint. Please add a period at the end of the sentence. Could you send an updated patch? Thanks! Ludo=E2=80=99.