unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#44722] [PATCH] gnu: web: add uriparser
@ 2020-11-18 13:48 lspangler via Guix-patches via
  2020-11-26 22:19 ` Ludovic Courtès
  2020-12-08 17:57 ` [bug#44722] (No Subject) lspangler via Guix-patches via
  0 siblings, 2 replies; 4+ messages in thread
From: lspangler via Guix-patches via @ 2020-11-18 13:48 UTC (permalink / raw)
  To: 44722

[-- Attachment #1: Type: text/plain, Size: 1842 bytes --]

From 1141a871635f048147faf022a9b649d6f8553080 Mon Sep 17 00:00:00 2001
From: Lane Spangler <lspangler@protonmail.com>
Date: Tue, 17 Nov 2020 17:50:06 +0100
Subject: [PATCH] gnu: web: add uriparser

---
gnu/packages/web.scm | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)

diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index edb7bd5da1..d79877c78a 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -111,6 +111,7 @@
#:use-module (gnu packages gnupg)
#:use-module (gnu packages golang)
#:use-module (gnu packages gperf)
+ #:use-module (gnu packages graphviz)
#:use-module (gnu packages gtk)
#:use-module (gnu packages guile)
#:use-module (gnu packages guile-xyz)
@@ -7747,3 +7748,30 @@ solution for any project's interface needs:
(description "gmnisrv is a simple Gemini protocol server written in C.")
(license (list license:gpl3+
license:bsd-3))))) ;; for ini.c and ini.h
+
+(define-public uriparser
+ (let [(commit "9e1fba08c231f1990fdee13545ab3a0ac804bd3c")
+ (revision "1")]
+ (package
+ (name "uriparser")
+ (version (git-version "0.9.4" revision commit))
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/uriparser/uriparser")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "13spkcsi8p5732bviy41y8dv5aw4vg83gqdclbsb9ayfbr2ybjx0"))))
+ (build-system cmake-build-system)
+ (native-inputs `(("gtest" ,googletest)
+ ("doxygen" ,doxygen)
+ ("graphviz" ,graphviz)))
+ (synopsis "Strictly RFC 3986 compliant URI parsing and handling
+ library written in C89")
+ (description "uriparser is a strictly RFC 3986 compliant URI
+ parsing and handling library written in C89 (\"ANSI C\").
+uriparser is cross-platform, fast, and supports Unicode")
+ (home-page "https://uriparser.github.io/")
+ (license license:bsd-3))))
--
2.29.2

[-- Attachment #2: Type: text/html, Size: 4472 bytes --]

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#44722] [PATCH] gnu: web: add uriparser
  2020-11-18 13:48 [bug#44722] [PATCH] gnu: web: add uriparser lspangler via Guix-patches via
@ 2020-11-26 22:19 ` Ludovic Courtès
  2020-12-08 17:57 ` [bug#44722] (No Subject) lspangler via Guix-patches via
  1 sibling, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2020-11-26 22:19 UTC (permalink / raw)
  To: lspangler; +Cc: 44722

Hello Lane,

lspangler <lspangler@protonmail.com> skribis:

> From 1141a871635f048147faf022a9b649d6f8553080 Mon Sep 17 00:00:00 2001
> From: Lane Spangler <lspangler@protonmail.com>
> Date: Tue, 17 Nov 2020 17:50:06 +0100
> Subject: [PATCH] gnu: web: add uriparser
>
> ---
> gnu/packages/web.scm | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)

It looks like the patch was mangled on the way.  Could you send it
as an attachment or using ‘git send-email’?

Some minor issues below:

> +(define-public uriparser
> +  (let [(commit "9e1fba08c231f1990fdee13545ab3a0ac804bd3c")
> +        (revision "1")]

Normally we pick upstream releases.  If there’s a good reason to pick
this commit rather than the latest release, could you please add a
comment above it explaining why?

Nitpick: Please use only regular parentheses, for consistency.

> +      (synopsis "Strictly RFC 3986 compliant URI parsing and handling
> + library written in C89")

What about making it shorter: “RFC 3986 compliant URI parsing and
handling library”?

> +      (description "uriparser is a strictly RFC 3986 compliant URI
> + parsing and handling library written in C89 (\"ANSI C\").
> +uriparser is cross-platform, fast, and supports Unicode")

I think you can omit “cross-platform” since that’s not relevant from a
Guix user standpoint.  Please add a period at the end of the sentence.

Could you send an updated patch?

Thanks!

Ludo’.




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#44722] (No Subject)
  2020-11-18 13:48 [bug#44722] [PATCH] gnu: web: add uriparser lspangler via Guix-patches via
  2020-11-26 22:19 ` Ludovic Courtès
@ 2020-12-08 17:57 ` lspangler via Guix-patches via
  2020-12-23 16:14   ` bug#44722: " Ludovic Courtès
  1 sibling, 1 reply; 4+ messages in thread
From: lspangler via Guix-patches via @ 2020-12-08 17:57 UTC (permalink / raw)
  To: 44722@debbugs.gnu.org


[-- Attachment #1.1: Type: text/plain, Size: 86 bytes --]

Hi Ludo,

Thanks for reviewing! I've made the suggested changes in the attached patch.

[-- Attachment #1.2: Type: text/html, Size: 129 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-web-Add-uriparser.patch --]
[-- Type: text/x-patch; name=0001-gnu-web-Add-uriparser.patch, Size: 2084 bytes --]

From d3aedc37d0970b38464c69e66263473f19565dd9 Mon Sep 17 00:00:00 2001
From: lsp <lsp@ableton.com>
Date: Tue, 17 Nov 2020 17:50:06 +0100
Subject: [PATCH] gnu: web: Add uriparser

---
 gnu/packages/web.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index edb7bd5da1..c0ff3c8b5c 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -111,6 +111,7 @@
   #:use-module (gnu packages gnupg)
   #:use-module (gnu packages golang)
   #:use-module (gnu packages gperf)
+  #:use-module (gnu packages graphviz)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages guile)
   #:use-module (gnu packages guile-xyz)
@@ -7747,3 +7748,29 @@ solution for any project's interface needs:
       (description "gmnisrv is a simple Gemini protocol server written in C.")
       (license (list license:gpl3+
                      license:bsd-3))))) ;; for ini.c and ini.h
+
+(define-public uriparser
+  (let ((commit "25dddb16cf044a7df27884e7ad3911baaaca3d7c")
+        (revision "1"))
+    (package
+      (name "uriparser")
+      (version (git-version "0.9.4" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/uriparser/uriparser")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "1ffzia679axcsccx2fxjpxhb0i5xc42zxn446x6c1170w6v69qf6"))))
+      (build-system cmake-build-system)
+      (native-inputs `(("gtest" ,googletest)
+                       ("doxygen" ,doxygen)
+                       ("graphviz" ,graphviz)))
+      (synopsis "Strictly RFC 3986 compliant URI parsing and handling library")
+      (description "uriparser is a strictly RFC 3986 compliant URI
+ parsing and handling library written in C89 (\"ANSI C\").
+uriparser is fast and supports Unicode.")
+      (home-page "https://uriparser.github.io/")
+      (license license:bsd-3))))
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* bug#44722: (No Subject)
  2020-12-08 17:57 ` [bug#44722] (No Subject) lspangler via Guix-patches via
@ 2020-12-23 16:14   ` Ludovic Courtès
  0 siblings, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2020-12-23 16:14 UTC (permalink / raw)
  To: lspangler; +Cc: 44722@debbugs.gnu.org

Hi,

lspangler <lspangler@protonmail.com> skribis:

> From d3aedc37d0970b38464c69e66263473f19565dd9 Mon Sep 17 00:00:00 2001
> From: lsp <lsp@ableton.com>
> Date: Tue, 17 Nov 2020 17:50:06 +0100
> Subject: [PATCH] gnu: web: Add uriparser
>
> ---
>  gnu/packages/web.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)

I added a commit log and applied.  Thanks and apologies for the delay!

Ludo’.




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-12-23 16:16 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-18 13:48 [bug#44722] [PATCH] gnu: web: add uriparser lspangler via Guix-patches via
2020-11-26 22:19 ` Ludovic Courtès
2020-12-08 17:57 ` [bug#44722] (No Subject) lspangler via Guix-patches via
2020-12-23 16:14   ` bug#44722: " Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).