From: "Ludovic Courtès" <ludo@gnu.org>
To: lspangler <lspangler@protonmail.com>
Cc: 44722@debbugs.gnu.org
Subject: [bug#44722] [PATCH] gnu: web: add uriparser
Date: Thu, 26 Nov 2020 23:19:17 +0100 [thread overview]
Message-ID: <87tutbzrq2.fsf@gnu.org> (raw)
In-Reply-To: <61GMcRudrqz0j9_UV7ajK_jffCV3On0vlQzjLrU6Ly3fS-n5F9aQvtH41aL2clXwcIpH0xi3B8iEL9iiCxjFvv_fUMet1_J95kMaYn0hnQ4=@protonmail.com> (lspangler@protonmail.com's message of "Wed, 18 Nov 2020 13:48:42 +0000")
Hello Lane,
lspangler <lspangler@protonmail.com> skribis:
> From 1141a871635f048147faf022a9b649d6f8553080 Mon Sep 17 00:00:00 2001
> From: Lane Spangler <lspangler@protonmail.com>
> Date: Tue, 17 Nov 2020 17:50:06 +0100
> Subject: [PATCH] gnu: web: add uriparser
>
> ---
> gnu/packages/web.scm | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
It looks like the patch was mangled on the way. Could you send it
as an attachment or using ‘git send-email’?
Some minor issues below:
> +(define-public uriparser
> + (let [(commit "9e1fba08c231f1990fdee13545ab3a0ac804bd3c")
> + (revision "1")]
Normally we pick upstream releases. If there’s a good reason to pick
this commit rather than the latest release, could you please add a
comment above it explaining why?
Nitpick: Please use only regular parentheses, for consistency.
> + (synopsis "Strictly RFC 3986 compliant URI parsing and handling
> + library written in C89")
What about making it shorter: “RFC 3986 compliant URI parsing and
handling library”?
> + (description "uriparser is a strictly RFC 3986 compliant URI
> + parsing and handling library written in C89 (\"ANSI C\").
> +uriparser is cross-platform, fast, and supports Unicode")
I think you can omit “cross-platform” since that’s not relevant from a
Guix user standpoint. Please add a period at the end of the sentence.
Could you send an updated patch?
Thanks!
Ludo’.
next prev parent reply other threads:[~2020-11-26 22:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 13:48 [bug#44722] [PATCH] gnu: web: add uriparser lspangler via Guix-patches via
2020-11-26 22:19 ` Ludovic Courtès [this message]
2020-12-08 17:57 ` [bug#44722] (No Subject) lspangler via Guix-patches via
2020-12-23 16:14 ` bug#44722: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tutbzrq2.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=44722@debbugs.gnu.org \
--cc=lspangler@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).