From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 8Pw0C++pEmA1VwAA0tVLHw (envelope-from ) for ; Thu, 28 Jan 2021 12:11:27 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id qNYBB++pEmDgaQAA1q6Kng (envelope-from ) for ; Thu, 28 Jan 2021 12:11:27 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7138D940105 for ; Thu, 28 Jan 2021 12:11:26 +0000 (UTC) Received: from localhost ([::1]:51660 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l568z-0000fd-DB for larch@yhetil.org; Thu, 28 Jan 2021 07:11:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35692) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l55sA-00016X-8w for guix-patches@gnu.org; Thu, 28 Jan 2021 06:54:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:35879) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l55sA-0001T9-0W for guix-patches@gnu.org; Thu, 28 Jan 2021 06:54:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l55s9-0000Kf-W9 for guix-patches@gnu.org; Thu, 28 Jan 2021 06:54:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46100] [PATCH 0/4] Memoize inferior package access. Resent-From: Ricardo Wurmus Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 28 Jan 2021 11:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46100 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 46100-submit@debbugs.gnu.org id=B46100.16118348201230 (code B ref 46100); Thu, 28 Jan 2021 11:54:01 +0000 Received: (at 46100) by debbugs.gnu.org; 28 Jan 2021 11:53:40 +0000 Received: from localhost ([127.0.0.1]:47424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l55rn-0000Jh-RB for submit@debbugs.gnu.org; Thu, 28 Jan 2021 06:53:40 -0500 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l55ra-0000JL-J5 for 46100@debbugs.gnu.org; Thu, 28 Jan 2021 06:53:27 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1611834798; cv=none; d=zohomail.com; s=zohoarc; b=YvGk+l5BIdmtgJC3PivXd+TpChRXPlTOUVShnzta4Z0XPZ+QRh5Q9GpQKV5nRrUuWUPPN9irZijAvIEhI4toMDsGPHG3r2uHbKIIe6uximecoqd3mIwQjV2sG4Rt1JvDzNAAnjLpdpDgdyftM7ViQw4CpGn+TyEvOTXg3ykBr0w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611834798; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=7Q4md1eZUW774FEz96oyRqxgiCUWBnDR9KY4gZ7RzJo=; b=e7ABIV6sqasKK6cEkdbDaNAeY/Tsp8j3a7/29h9oneJCnNZ2+HO6zBf5nG8PycCmDhaGthvAf6TR1krM4CaWUjrW4ibE74ziJMs0O2ngqbrUwwCXkYkUiL4aglv+IRDqWiPmcC4xw3+URgXkrq9JQumeeMXlku1MEJBf9IVVdP4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1611834798; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=7Q4md1eZUW774FEz96oyRqxgiCUWBnDR9KY4gZ7RzJo=; b=AimJG4gP7kH1c0zEQYloxEaVFUlWNWAIZGKkgqkP6d3sIgqqZHXW9WWeMDAB4JVj IlzNe40CWQCPhBNuvg4oVb42aJ/kH7VauDCqgu1MhUlsAhdT0HfyQVi2NP3dkdBjQKs eOZUA1BmMDK7Mgyz+KPbLzljGOuyRSpR/vLqx89g= Received: from localhost (p54ad4fb2.dip0.t-ipconnect.de [84.173.79.178]) by mx.zohomail.com with SMTPS id 1611834796276426.2873760675275; Thu, 28 Jan 2021 03:53:16 -0800 (PST) References: <20210125133738.15609-1-rekado@elephly.net> <20210125133738.15609-2-rekado@elephly.net> <878s8g0yln.fsf_-_@gnu.org> <874kj40wbp.fsf_-_@gnu.org> <87y2gfj2ks.fsf@elephly.net> <87sg6mrmtr.fsf@gnu.org> User-agent: mu4e 1.4.13; emacs 27.1 From: Ricardo Wurmus In-reply-to: <87sg6mrmtr.fsf@gnu.org> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Thu, 28 Jan 2021 12:53:12 +0100 Message-ID: <87tur1i8gn.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 46100@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: 0.65 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=AimJG4gP; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 7138D940105 X-Spam-Score: 0.65 X-Migadu-Scanner: scn1.migadu.com X-TUID: uvg/vjbbWgC7 Ludovic Court=C3=A8s writes: > I pushed it as 0f20b3fa2050ba6e442e340a204516b9375cd231. Thanks! > I wonder if the other patches improve the situation. If you run the > same test case with: > > GUIX_PROFILING=3Dmemoization > > what hit rates does it show for these spots? Memoization: 15 tables, 2 non-empty guix/inferior.scm:438:2: 403 entries, 403 lookups, 0% hits guix/inferior.scm:392:2: 403 entries, 403 lookups, 0% hits So, I guess we can drop those two patches. --=20 Ricardo